You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/08/14 18:13:44 UTC
[GitHub] [camel] ctataryn opened a new pull request #4092: Added reference to Bean Binding documentation
ctataryn opened a new pull request #4092:
URL: https://github.com/apache/camel/pull/4092
Within this document there is a reference to a "Bean Binding" mechanism. I have added a link to the documentation explaining the mechanism.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] zregvart commented on a change in pull request #4092: Added reference to Bean Binding documentation
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #4092:
URL: https://github.com/apache/camel/pull/4092#discussion_r470820566
##########
File path: docs/components/modules/ROOT/pages/bean-component.adoc
##########
@@ -167,7 +167,7 @@ from("direct:start").bean(ExampleBean.class);
How bean methods to be invoked are chosen (if they are not specified
explicitly through the *method* parameter) and how parameter values are
constructed from the Message are all defined by the
-Bean Binding mechanism which is used throughout
+https://camel.apache.org/manual/latest/bean-binding.html[Bean Binding] mechanism which is used throughout
Review comment:
We're using [Antora](https://antora.org/) to build the documentation, so we need to adhere to the [xref syntax](https://docs.antora.org/antora/2.3/page/page-id/#whats-a-cross-reference) for linking to pages.
```suggestion
xref:ROOT:bean-binding.adoc[Bean Binding] mechanism which is used throughout
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] ctataryn commented on a change in pull request #4092: Added reference to Bean Binding documentation
Posted by GitBox <gi...@apache.org>.
ctataryn commented on a change in pull request #4092:
URL: https://github.com/apache/camel/pull/4092#discussion_r471005166
##########
File path: docs/components/modules/ROOT/pages/bean-component.adoc
##########
@@ -167,7 +167,7 @@ from("direct:start").bean(ExampleBean.class);
How bean methods to be invoked are chosen (if they are not specified
explicitly through the *method* parameter) and how parameter values are
constructed from the Message are all defined by the
-Bean Binding mechanism which is used throughout
+https://camel.apache.org/manual/latest/bean-binding.html[Bean Binding] mechanism which is used throughout
Review comment:
@zregvart Thank you
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #4092: Added reference to Bean Binding documentation
Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #4092:
URL: https://github.com/apache/camel/pull/4092#issuecomment-674414730
Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd merged pull request #4092: Added reference to Bean Binding documentation
Posted by GitBox <gi...@apache.org>.
oscerd merged pull request #4092:
URL: https://github.com/apache/camel/pull/4092
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org