You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by GitBox <gi...@apache.org> on 2020/04/23 18:05:45 UTC

[GitHub] [storm] agresch commented on a change in pull request #3254: STORM-3596 use send assignment status in blacklist scheduling

agresch commented on a change in pull request #3254:
URL: https://github.com/apache/storm/pull/3254#discussion_r414011898



##########
File path: storm-server/src/main/java/org/apache/storm/scheduler/blacklist/BlacklistScheduler.java
##########
@@ -155,6 +163,18 @@ private void badSupervisors(Map<String, SupervisorDetails> supervisors) {
         badSupervisorsToleranceSlidingWindow.add(badSupervisors);
     }
 
+    private void trackAssignmentFailures() {
+        if (!blacklistSendAssignentFailures) {
+            return;
+        }
+        Map<String, Integer> assignmentFailureWindow = new HashMap<>();
+        assignmentFailureWindow.putAll(this.assignmentFailures);
+        synchronized (assignmentFailures) {

Review comment:
       yes




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org