You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/01/05 23:36:25 UTC
[GitHub] [hbase] HorizonNet opened a new pull request #990: HBASE-23646
Resolved remaining Checkstyle violations in tests of hbase-rest
HorizonNet opened a new pull request #990: HBASE-23646 Resolved remaining Checkstyle violations in tests of hbase-rest
URL: https://github.com/apache/hbase/pull/990
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet merged pull request #990: HBASE-23646 Resolved
remaining Checkstyle violations in tests of hbase-rest
Posted by GitBox <gi...@apache.org>.
HorizonNet merged pull request #990: HBASE-23646 Resolved remaining Checkstyle violations in tests of hbase-rest
URL: https://github.com/apache/hbase/pull/990
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #990: HBASE-23646 Resolved
remaining Checkstyle violations in tests of hbase-rest
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #990: HBASE-23646 Resolved remaining Checkstyle violations in tests of hbase-rest
URL: https://github.com/apache/hbase/pull/990#issuecomment-570966310
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 33s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 5 new or modified test files. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 35s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 5m 12s | master passed |
| +1 :green_heart: | compile | 0m 44s | master passed |
| +1 :green_heart: | checkstyle | 2m 32s | master passed |
| +1 :green_heart: | shadedjars | 4m 45s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 43s | master passed |
| +0 :ok: | spotbugs | 0m 53s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +0 :ok: | findbugs | 0m 16s | branch/hbase-checkstyle no findbugs output file (findbugsXml.xml) |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 20s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 4m 59s | the patch passed |
| +1 :green_heart: | compile | 0m 45s | the patch passed |
| +1 :green_heart: | javac | 0m 45s | the patch passed |
| +1 :green_heart: | checkstyle | 2m 32s | root: The patch generated 0 new + 0 unchanged - 168 fixed = 0 total (was 168) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. |
| +1 :green_heart: | shadedjars | 4m 37s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 15m 50s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. |
| +1 :green_heart: | javadoc | 0m 36s | the patch passed |
| +0 :ok: | findbugs | 0m 14s | hbase-checkstyle has no data from findbugs |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 13s | hbase-checkstyle in the patch passed. |
| +1 :green_heart: | unit | 4m 18s | hbase-rest in the patch passed. |
| +1 :green_heart: | asflicense | 0m 25s | The patch does not generate ASF License warnings. |
| | | 58m 38s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-990/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/990 |
| Optional Tests | dupname asflicense checkstyle javac javadoc unit xml spotbugs findbugs shadedjars hadoopcheck hbaseanti compile |
| uname | Linux 2ea2ec8fa945 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-990/out/precommit/personality/provided.sh |
| git revision | master / ab9766599d |
| Default Java | 1.8.0_181 |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-990/1/testReport/ |
| Max. process+thread count | 1911 (vs. ulimit of 10000) |
| modules | C: hbase-checkstyle hbase-rest U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-990/1/console |
| versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #990:
HBASE-23646 Resolved remaining Checkstyle violations in tests of hbase-rest
Posted by GitBox <gi...@apache.org>.
HorizonNet commented on a change in pull request #990: HBASE-23646 Resolved remaining Checkstyle violations in tests of hbase-rest
URL: https://github.com/apache/hbase/pull/990#discussion_r364144441
##########
File path: hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/PerformanceEvaluation.java
##########
@@ -708,33 +709,26 @@ private Path writeInputFile(final Configuration c) throws IOException {
FileSystem fs = FileSystem.get(c);
fs.mkdirs(inputDir);
Path inputFile = new Path(inputDir, "input.txt");
- PrintStream out = new PrintStream(fs.create(inputFile));
// Make input random.
- Map<Integer, String> m = new TreeMap<>();
- Hash h = MurmurHash.getInstance();
- int perClientRows = (this.R / this.N);
- try {
+ try (PrintStream out = new PrintStream(fs.create(inputFile))) {
+ Map<Integer, String> m = new TreeMap<>();
+ Hash h = MurmurHash.getInstance();
+ int perClientRows = (this.R / this.N);
for (int i = 0; i < 10; i++) {
for (int j = 0; j < N; j++) {
- String s = "tableName=" + this.tableName +
- ", startRow=" + ((j * perClientRows) + (i * (perClientRows/10))) +
- ", perClientRunRows=" + (perClientRows / 10) +
- ", totalRows=" + this.R +
- ", clients=" + this.N +
- ", flushCommits=" + this.flushCommits +
- ", writeToWAL=" + this.writeToWAL +
- ", useTags=" + this.useTags +
- ", noOfTags=" + this.noOfTags;
+ String s = "tableName=" + this.tableName + ", startRow=" + ((j * perClientRows) + (i * (
+ perClientRows / 10))) + ", perClientRunRows=" + (perClientRows / 10) + ", totalRows="
+ + this.R + ", clients=" + this.N + ", flushCommits=" + this.flushCommits
+ + ", writeToWAL=" + this.writeToWAL + ", useTags=" + this.useTags + ", noOfTags="
+ + this.noOfTags;
Review comment:
Updated the patch to use `StringBuilder` instead of `String` at this one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #990: HBASE-23646 Resolved
remaining Checkstyle violations in tests of hbase-rest
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #990: HBASE-23646 Resolved remaining Checkstyle violations in tests of hbase-rest
URL: https://github.com/apache/hbase/pull/990#issuecomment-571996009
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 35s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 5 new or modified test files. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 36s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 5m 30s | master passed |
| +1 :green_heart: | compile | 0m 44s | master passed |
| +1 :green_heart: | checkstyle | 2m 40s | master passed |
| +1 :green_heart: | shadedjars | 5m 1s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 37s | master passed |
| +0 :ok: | spotbugs | 0m 55s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +0 :ok: | findbugs | 0m 16s | branch/hbase-checkstyle no findbugs output file (findbugsXml.xml) |
| -0 :warning: | patch | 1m 9s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 5m 7s | the patch passed |
| +1 :green_heart: | compile | 0m 43s | the patch passed |
| +1 :green_heart: | javac | 0m 43s | the patch passed |
| +1 :green_heart: | checkstyle | 2m 28s | root: The patch generated 0 new + 0 unchanged - 168 fixed = 0 total (was 168) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. |
| +1 :green_heart: | shadedjars | 4m 46s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 16m 38s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. |
| +1 :green_heart: | javadoc | 0m 36s | the patch passed |
| +0 :ok: | findbugs | 0m 13s | hbase-checkstyle has no data from findbugs |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 14s | hbase-checkstyle in the patch passed. |
| +1 :green_heart: | unit | 4m 57s | hbase-rest in the patch passed. |
| +1 :green_heart: | asflicense | 0m 28s | The patch does not generate ASF License warnings. |
| | | 61m 15s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-990/3/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/990 |
| Optional Tests | dupname asflicense checkstyle javac javadoc unit xml spotbugs findbugs shadedjars hadoopcheck hbaseanti compile |
| uname | Linux 587641fe9688 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-990/out/precommit/personality/provided.sh |
| git revision | master / 5a7c9443e9 |
| Default Java | 1.8.0_181 |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-990/3/testReport/ |
| Max. process+thread count | 1939 (vs. ulimit of 10000) |
| modules | C: hbase-checkstyle hbase-rest U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-990/3/console |
| versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] virajjasani commented on a change in pull request #990:
HBASE-23646 Resolved remaining Checkstyle violations in tests of hbase-rest
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #990: HBASE-23646 Resolved remaining Checkstyle violations in tests of hbase-rest
URL: https://github.com/apache/hbase/pull/990#discussion_r363201177
##########
File path: hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/PerformanceEvaluation.java
##########
@@ -708,33 +709,26 @@ private Path writeInputFile(final Configuration c) throws IOException {
FileSystem fs = FileSystem.get(c);
fs.mkdirs(inputDir);
Path inputFile = new Path(inputDir, "input.txt");
- PrintStream out = new PrintStream(fs.create(inputFile));
// Make input random.
- Map<Integer, String> m = new TreeMap<>();
- Hash h = MurmurHash.getInstance();
- int perClientRows = (this.R / this.N);
- try {
+ try (PrintStream out = new PrintStream(fs.create(inputFile))) {
+ Map<Integer, String> m = new TreeMap<>();
+ Hash h = MurmurHash.getInstance();
+ int perClientRows = (this.R / this.N);
for (int i = 0; i < 10; i++) {
for (int j = 0; j < N; j++) {
- String s = "tableName=" + this.tableName +
- ", startRow=" + ((j * perClientRows) + (i * (perClientRows/10))) +
- ", perClientRunRows=" + (perClientRows / 10) +
- ", totalRows=" + this.R +
- ", clients=" + this.N +
- ", flushCommits=" + this.flushCommits +
- ", writeToWAL=" + this.writeToWAL +
- ", useTags=" + this.useTags +
- ", noOfTags=" + this.noOfTags;
+ String s = "tableName=" + this.tableName + ", startRow=" + ((j * perClientRows) + (i * (
+ perClientRows / 10))) + ", perClientRunRows=" + (perClientRows / 10) + ", totalRows="
+ + this.R + ", clients=" + this.N + ", flushCommits=" + this.flushCommits
+ + ", writeToWAL=" + this.writeToWAL + ", useTags=" + this.useTags + ", noOfTags="
+ + this.noOfTags;
Review comment:
Good to use StringBuilder may be?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #990: HBASE-23646 Resolved
remaining Checkstyle violations in tests of hbase-rest
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #990: HBASE-23646 Resolved remaining Checkstyle violations in tests of hbase-rest
URL: https://github.com/apache/hbase/pull/990#issuecomment-571520226
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 36s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 5 new or modified test files. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 36s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 5m 42s | master passed |
| +1 :green_heart: | compile | 0m 43s | master passed |
| +1 :green_heart: | checkstyle | 2m 44s | master passed |
| +1 :green_heart: | shadedjars | 4m 52s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 38s | master passed |
| +0 :ok: | spotbugs | 0m 55s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +0 :ok: | findbugs | 0m 17s | branch/hbase-checkstyle no findbugs output file (findbugsXml.xml) |
| -0 :warning: | patch | 1m 9s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 5m 6s | the patch passed |
| +1 :green_heart: | compile | 0m 46s | the patch passed |
| +1 :green_heart: | javac | 0m 46s | the patch passed |
| +1 :green_heart: | checkstyle | 2m 47s | root: The patch generated 0 new + 0 unchanged - 168 fixed = 0 total (was 168) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. |
| +1 :green_heart: | shadedjars | 4m 45s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 15m 44s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. |
| +1 :green_heart: | javadoc | 0m 36s | the patch passed |
| +0 :ok: | findbugs | 0m 14s | hbase-checkstyle has no data from findbugs |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 14s | hbase-checkstyle in the patch passed. |
| +1 :green_heart: | unit | 4m 16s | hbase-rest in the patch passed. |
| +1 :green_heart: | asflicense | 0m 26s | The patch does not generate ASF License warnings. |
| | | 59m 46s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-990/2/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/990 |
| Optional Tests | dupname asflicense checkstyle javac javadoc unit xml spotbugs findbugs shadedjars hadoopcheck hbaseanti compile |
| uname | Linux 5f13f4516290 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-990/out/precommit/personality/provided.sh |
| git revision | master / 1eafba5603 |
| Default Java | 1.8.0_181 |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-990/2/testReport/ |
| Max. process+thread count | 1976 (vs. ulimit of 10000) |
| modules | C: hbase-checkstyle hbase-rest U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-990/2/console |
| versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services