[jira] [Comment Edited] (BIGTOP-1560) Add a test case for performing block corruption recovery

["jay vyas (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BIGTOP-1560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14238496#comment-14238496 ] 

jay vyas edited comment on BIGTOP-1560 at 12/8/14 9:53 PM:
-----------------------------------------------------------

This is an interesting test !

- move the {{This test chekcs blocks recorvery after a block...}} comment to the top of the class, and, and define the minimum criteria for running and passing the tests (block replication   must be > 1 i assume, maybe some other criteria)
- Can you *consolidate the grep* for the ip address into a separate method with a good method name - i always get firghtened when i see random regexes and it distracts from the logic . :)
- *comment* above  for loop   {{j < 3}} 
- *just an idea* if your familiar w/ vagrant, then would love to see an call to this from the gradle based {{smoke-tests}}, then you could confirm that this works on a virtual 3 node hdfs cluster from your laptop :) ... maybe at a later data i can do this.

Otherwise, LGTM and very interesting patch and ready to commit, provided you've tested this and confirmed it works perfectly ?


was (Author: jayunit100):
This is an interesting test !

- move the {{This test chekcs blocks recorvery after a block...}} comment to the top of the class, and, and define the minimum criteria for running and passing the tests (block replication   must be > 1 i assume, maybe some other criteria)
- Can you *consolidate the grep* for the ip address into a separate method with a good method name - i always get firghtened when i see random regexes and it distracts from the logic . :)
- *comment* above  for loop   {{j < 3}} 
- *just an idea* if your familiar w/ vagrant, then would love to see an call to this from {{smoke.tests}} , then you could confirm that this works on a virtual 3 node hdfs cluster from your laptop :) ... maybe at a later data i can do this.

Otherwise, LGTM and very interesting patch and ready to commit, provided you've tested this and confirmed it works perfectly ?

> Add a test case for performing block corruption recovery
> --------------------------------------------------------
>
>                 Key: BIGTOP-1560
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-1560
>             Project: Bigtop
>          Issue Type: Test
>          Components: tests
>    Affects Versions: 0.8.0
>            Reporter: Dasha Boudnik
>            Assignee: Dasha Boudnik
>             Fix For: 0.9.0
>
>         Attachments: BIGTOP-1560.patch
>
>
> Found this issue in internal testing. Roughly:
> create file in HDFS
> find block for the file
> corrupt a block
> trigger recovery by trying to read the file
> check recovery was successful



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)