You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2018/03/20 16:51:55 UTC
Review Request 66175: Added isolator checks for namespaces support.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66175/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Bugs: MESOS-6555
https://issues.apache.org/jira/browse/MESOS-6555
Repository: mesos
Description
-------
Some isolators assumed that the Linux namespaces they needed were
supported but did not explicitly check for them. Added explicit
checks for the required namespaces so that the isolators can emit
a more specifc error message.
Diffs
-----
src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp a6f05a8cf7eab2b2cc4c2142efdf3125462ec68e
src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 6ee249997fcdfa37f7d073d9c150d06908b3f921
src/slave/containerizer/mesos/isolators/filesystem/shared.cpp 118f39871fd76ca00b92e4fa80c698a2a8f02f19
src/slave/containerizer/mesos/isolators/network/cni/cni.cpp d8dc02a686603e8f5dca073084c09992270b7f42
Diff: https://reviews.apache.org/r/66175/diff/1/
Testing
-------
make check (Fedora 27)
Thanks,
James Peach
Re: Review Request 66175: Added isolator checks for namespaces
support.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66175/#review199563
-----------------------------------------------------------
PASS: Mesos patch 66175 was successfully built and tested.
Reviews applied: `['66175']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66175
- Mesos Reviewbot Windows
On March 20, 2018, 4:51 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66175/
> -----------------------------------------------------------
>
> (Updated March 20, 2018, 4:51 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-6555
> https://issues.apache.org/jira/browse/MESOS-6555
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Some isolators assumed that the Linux namespaces they needed were
> supported but did not explicitly check for them. Added explicit
> checks for the required namespaces so that the isolators can emit
> a more specifc error message.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp a6f05a8cf7eab2b2cc4c2142efdf3125462ec68e
> src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 6ee249997fcdfa37f7d073d9c150d06908b3f921
> src/slave/containerizer/mesos/isolators/filesystem/shared.cpp 118f39871fd76ca00b92e4fa80c698a2a8f02f19
> src/slave/containerizer/mesos/isolators/network/cni/cni.cpp d8dc02a686603e8f5dca073084c09992270b7f42
>
>
> Diff: https://reviews.apache.org/r/66175/diff/1/
>
>
> Testing
> -------
>
> make check (Fedora 27)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 66175: Added isolator checks for namespaces
support.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66175/#review199573
-----------------------------------------------------------
Patch looks great!
Reviews applied: [66175]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 20, 2018, 4:51 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66175/
> -----------------------------------------------------------
>
> (Updated March 20, 2018, 4:51 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-6555
> https://issues.apache.org/jira/browse/MESOS-6555
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Some isolators assumed that the Linux namespaces they needed were
> supported but did not explicitly check for them. Added explicit
> checks for the required namespaces so that the isolators can emit
> a more specifc error message.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp a6f05a8cf7eab2b2cc4c2142efdf3125462ec68e
> src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 6ee249997fcdfa37f7d073d9c150d06908b3f921
> src/slave/containerizer/mesos/isolators/filesystem/shared.cpp 118f39871fd76ca00b92e4fa80c698a2a8f02f19
> src/slave/containerizer/mesos/isolators/network/cni/cni.cpp d8dc02a686603e8f5dca073084c09992270b7f42
>
>
> Diff: https://reviews.apache.org/r/66175/diff/1/
>
>
> Testing
> -------
>
> make check (Fedora 27)
>
>
> Thanks,
>
> James Peach
>
>