[GitHub] [incubator-echarts] susiwen8 commented on a change in pull request #10448: Support label rotate to pie chart

[GitBox <gi...@apache.org>]

susiwen8 commented on a change in pull request #10448: Support label rotate to pie chart
URL: https://github.com/apache/incubator-echarts/pull/10448#discussion_r283180718
 
 

 ##########
 File path: src/chart/pie/labelLayout.js
 ##########
 @@ -222,7 +222,7 @@ export default function (seriesModel, r, viewWidth, viewHeight, sum) {
         var font = labelModel.getFont();
 
         var labelRotate = labelModel.get('rotate')
-            ? (dx < 0 ? -midAngle + Math.PI : -midAngle) : 0;
+            ? +labelModel.get('rotate') * (Math.PI / 180) : 0;
 
 Review comment:
   midAngle is added, and I will update doc

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@echarts.apache.org
For additional commands, e-mail: dev-help@echarts.apache.org