You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metamodel.apache.org by kaspersorensen <gi...@git.apache.org> on 2015/08/15 19:56:18 UTC
[GitHub] metamodel pull request: Feature/metamodel 170 drop java6 support
GitHub user kaspersorensen opened a pull request:
https://github.com/apache/metamodel/pull/39
Feature/metamodel 170 drop java6 support
My attempt at fixing METAMODEL-170: Drop Java 6 support.
Do not merge before the release process of MetaModel 4.3.6 has finished completely.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kaspersorensen/metamodel feature/METAMODEL-170-drop-java6-support
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metamodel/pull/39.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #39
----
commit 808b09bde4badecab061f1900fab6d5eb2c4d670
Author: Kasper Sørensen <i....@gmail.com>
Date: 2015-08-15T17:48:02Z
METAMODEL-170: Removed Travis Java 6 build
commit 26a64bdbba1b23d0cafa9b4712dcada92e5a804c
Author: Kasper Sørensen <i....@gmail.com>
Date: 2015-08-15T17:52:49Z
METAMODEL-170: Removed any Java 6 specifics from build files
commit 132901d06134b0e4e62e323c4def22b3b68ac2d4
Author: Kasper Sørensen <i....@gmail.com>
Date: 2015-08-15T17:54:00Z
METAMODEL-170: Removed hack to avoid invalid test under ES version 0.x
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Feature/metamodel 170 drop java6 support
Posted by kaspersorensen <gi...@git.apache.org>.
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/39#discussion_r37162796
--- Diff: pom.xml ---
@@ -168,8 +168,8 @@ under the License.
<groupId>org.apache.maven.plugins</groupId>
--- End diff --
Fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Feature/metamodel 170 drop java6 support
Posted by ardlema <gi...@git.apache.org>.
Github user ardlema commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/39#discussion_r37162829
--- Diff: pom.xml ---
@@ -168,8 +168,8 @@ under the License.
<groupId>org.apache.maven.plugins</groupId>
--- End diff --
Thank you ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Feature/metamodel 170 drop java6 support
Posted by ardlema <gi...@git.apache.org>.
Github user ardlema commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/39#discussion_r37162110
--- Diff: pom.xml ---
@@ -168,8 +168,8 @@ under the License.
<groupId>org.apache.maven.plugins</groupId>
--- End diff --
Minor nitpick: the comment should now say <!-- Ensures java 7 compatibility -->
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Feature/metamodel 170 drop java6 support
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/metamodel/pull/39
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---