You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Duo Zhang (Jira)" <ji...@apache.org> on 2022/04/05 13:57:00 UTC
[jira] [Updated] (HBASE-26922) Fix LineLength warnings as much as possible if it can not be fixed by spotless
[ https://issues.apache.org/jira/browse/HBASE-26922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Duo Zhang updated HBASE-26922:
------------------------------
Description:
One possible problem is the trailing comment, Like this
{code}
assertTrue(initialRegions
.contains(RegionReplicaUtil.getRegionInfoForReplica(mergedRegions.getFirst(), 1))); // this
// is
// the
// replica
// of
// the
// first
// region
{code}
Because of we limited line length, the format will be very strange and still has line length problem if some of the words are too long.
Let's move them from trailing to top of the statement.
was:
Like this
{code}
assertTrue(initialRegions
.contains(RegionReplicaUtil.getRegionInfoForReplica(mergedRegions.getFirst(), 1))); // this
// is
// the
// replica
// of
// the
// first
// region
{code}
Because of we limited line length, the format will be very strange and still has line length problem if some of the words are too long.
Let's move them from trailing to top of the statement.
> Fix LineLength warnings as much as possible if it can not be fixed by spotless
> ------------------------------------------------------------------------------
>
> Key: HBASE-26922
> URL: https://issues.apache.org/jira/browse/HBASE-26922
> Project: HBase
> Issue Type: Sub-task
> Reporter: Duo Zhang
> Assignee: Duo Zhang
> Priority: Major
>
> One possible problem is the trailing comment, Like this
> {code}
> assertTrue(initialRegions
> .contains(RegionReplicaUtil.getRegionInfoForReplica(mergedRegions.getFirst(), 1))); // this
> // is
> // the
> // replica
> // of
> // the
> // first
> // region
> {code}
> Because of we limited line length, the format will be very strange and still has line length problem if some of the words are too long.
> Let's move them from trailing to top of the statement.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)