You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "tustvold (via GitHub)" <gi...@apache.org> on 2023/03/01 13:48:52 UTC
[GitHub] [arrow-datafusion] tustvold opened a new pull request, #5441: Update to NullBuffer in ArrayData
tustvold opened a new pull request, #5441:
URL: https://github.com/apache/arrow-datafusion/pull/5441
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
Update to https://github.com/apache/arrow-rs/pull/3778 to scope out required changes
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] comphead commented on pull request #5441: Update to Arrow 35.0.0
Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead commented on PR #5441:
URL: https://github.com/apache/arrow-datafusion/pull/5441#issuecomment-1475455131
Regression issue here preventing tests to run
`select '2020-01-02 01:01:11.1234567890Z'::timestamp` now fails
but `select '2020-01-02 01:01:11.123456789Z'::timestamp` is ok
@alamb @tustvold
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] comphead commented on a diff in pull request #5441: Update to Arrow 35.0.0
Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead commented on code in PR #5441:
URL: https://github.com/apache/arrow-datafusion/pull/5441#discussion_r1140718977
##########
datafusion/core/tests/sql/set_variable.rs:
##########
@@ -414,7 +414,7 @@ async fn set_time_zone_bad_time_zone_format() {
.await
.unwrap();
let err = pretty_format_batches(&result).err().unwrap().to_string();
- assert_eq!(err, "Parser error: Invalid timezone \"+08:00:00\": Expected format [+-]XX:XX, [+-]XX, or [+-]XXXX");
+ assert_eq!(err, "Parser error: Invalid timezone \"+08:00:00\": only offset based timezones supported without chrono-tz feature");
Review Comment:
perhaps we can improve the error message a bit in a future :blush:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #5441: Update to Arrow 35.0.0
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #5441:
URL: https://github.com/apache/arrow-datafusion/pull/5441#discussion_r1135685360
##########
datafusion/core/tests/sql/timestamp.rs:
##########
@@ -1411,14 +1411,14 @@ async fn cast_timestamp_before_1970() -> Result<()> {
assert_batches_eq!(expected, &actual);
- let sql = "select cast('1969-01-01T00:00:00.1Z' as timestamp);";
+ let sql = "select cast('1969-01-01T00:00:00.100Z' as timestamp);";
Review Comment:
https://github.com/apache/arrow-rs/pull/3858 I think is related
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] tustvold closed pull request #5441: Update to Arrow 35.0.0
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold closed pull request #5441: Update to Arrow 35.0.0
URL: https://github.com/apache/arrow-datafusion/pull/5441
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #5441: Update to Arrow 35.0.0
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #5441:
URL: https://github.com/apache/arrow-datafusion/pull/5441#discussion_r1135698258
##########
datafusion/core/tests/sql/timestamp.rs:
##########
@@ -1411,14 +1411,14 @@ async fn cast_timestamp_before_1970() -> Result<()> {
assert_batches_eq!(expected, &actual);
- let sql = "select cast('1969-01-01T00:00:00.1Z' as timestamp);";
+ let sql = "select cast('1969-01-01T00:00:00.100Z' as timestamp);";
Review Comment:
I would tend to think this regression should block the upgrade of datafusion, but would defer to others.
maybe we can mark this PR as "ready for review" to get some other opinions 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #5441: Update to Arrow 35.0.0
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #5441:
URL: https://github.com/apache/arrow-datafusion/pull/5441#issuecomment-1478398946
> Do we have a list of regression to be fixed in arrow 36.0.0?
The ones I know of are https://github.com/apache/arrow-rs/issues/3889#issuecomment-1476044397
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] tustvold commented on a diff in pull request #5441: Update to Arrow 35.0.0
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #5441:
URL: https://github.com/apache/arrow-datafusion/pull/5441#discussion_r1135519695
##########
datafusion/core/tests/sql/timestamp.rs:
##########
@@ -1411,14 +1411,14 @@ async fn cast_timestamp_before_1970() -> Result<()> {
assert_batches_eq!(expected, &actual);
- let sql = "select cast('1969-01-01T00:00:00.1Z' as timestamp);";
+ let sql = "select cast('1969-01-01T00:00:00.100Z' as timestamp);";
Review Comment:
An error, it was a mis-reading of the RFC spec, I thought it restricted to multiples of 3 for subsecond precision, I'm working on a fix. It is somewhat amusing that chrono doesn't actually have any tests for this...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] tustvold commented on a diff in pull request #5441: Update to NullBuffer in ArrayData
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #5441:
URL: https://github.com/apache/arrow-datafusion/pull/5441#discussion_r1121792711
##########
datafusion/common/src/scalar.rs:
##########
@@ -2979,10 +2979,6 @@ mod tests {
ScalarValue::Decimal128(None, 10, 2),
ScalarValue::try_from_array(&array, 3).unwrap()
);
- assert_eq!(
Review Comment:
This test was wrong, index 4 is beyond the bounds of the array. Previously this was fine as the null buffer only enforced the length for multiples of 8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] tustvold commented on a diff in pull request #5441: Update to Arrow 35.0.0
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #5441:
URL: https://github.com/apache/arrow-datafusion/pull/5441#discussion_r1135519695
##########
datafusion/core/tests/sql/timestamp.rs:
##########
@@ -1411,14 +1411,14 @@ async fn cast_timestamp_before_1970() -> Result<()> {
assert_batches_eq!(expected, &actual);
- let sql = "select cast('1969-01-01T00:00:00.1Z' as timestamp);";
+ let sql = "select cast('1969-01-01T00:00:00.100Z' as timestamp);";
Review Comment:
An error, it was a mis-reading of the RFC spec, I thought it restricted to multiples of 3 for subsecond precision, I'm working on a fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] tustvold commented on a diff in pull request #5441: Update to NullBuffer in ArrayData
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #5441:
URL: https://github.com/apache/arrow-datafusion/pull/5441#discussion_r1121792711
##########
datafusion/common/src/scalar.rs:
##########
@@ -2979,10 +2979,6 @@ mod tests {
ScalarValue::Decimal128(None, 10, 2),
ScalarValue::try_from_array(&array, 3).unwrap()
);
- assert_eq!(
Review Comment:
This test was wrong, index 4 is beyond the bounds of the array
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #5441: Update to Arrow 35.0.0
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #5441:
URL: https://github.com/apache/arrow-datafusion/pull/5441#discussion_r1135517648
##########
datafusion/core/tests/dataframe_functions.rs:
##########
@@ -398,10 +398,10 @@ async fn test_fn_regexp_match() -> Result<()> {
"+-----------------------------------+",
"| regexpmatch(test.a,Utf8(\"[a-z]\")) |",
"+-----------------------------------+",
- "| [] |",
- "| [] |",
- "| [] |",
- "| [] |",
+ "| [a] |",
Review Comment:
🎉
##########
datafusion/core/tests/sql/timestamp.rs:
##########
@@ -1411,14 +1411,14 @@ async fn cast_timestamp_before_1970() -> Result<()> {
assert_batches_eq!(expected, &actual);
- let sql = "select cast('1969-01-01T00:00:00.1Z' as timestamp);";
+ let sql = "select cast('1969-01-01T00:00:00.100Z' as timestamp);";
Review Comment:
what happens without this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #5441: Update to Arrow 35.0.0
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #5441:
URL: https://github.com/apache/arrow-datafusion/pull/5441#issuecomment-1476046611
> Regression issue here preventing tests to run
Thanks @comphead -- I think that is https://github.com/apache/arrow-rs/issues/3859
There were a few regressions, in arrow 35.0.0 so I think we should probably skip arrow 35.0.0 and wait for arrow 36.0.0: https://github.com/apache/arrow-rs/issues/3889
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] comphead commented on a diff in pull request #5441: Update to Arrow 35.0.0
Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead commented on code in PR #5441:
URL: https://github.com/apache/arrow-datafusion/pull/5441#discussion_r1140719953
##########
datafusion/optimizer/src/simplify_expressions/simplify_exprs.rs:
##########
@@ -431,7 +431,7 @@ mod tests {
.project(proj)?
.build()?;
- let expected = "Error parsing 'I'M NOT A TIMESTAMP' as timestamp";
+ let expected = "Error parsing timestamp from 'I'M NOT A TIMESTAMP'";
Review Comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] comphead commented on pull request #5441: Update to Arrow 35.0.0
Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead commented on PR #5441:
URL: https://github.com/apache/arrow-datafusion/pull/5441#issuecomment-1477052394
> > Regression issue here preventing tests to run
>
> Thanks @comphead -- I think that is [apache/arrow-rs#3859](https://github.com/apache/arrow-rs/issues/3859)
>
> There were a few regressions, in arrow 35.0.0 so I think we should probably skip arrow 35.0.0 and wait for arrow 36.0.0: [apache/arrow-rs#3889](https://github.com/apache/arrow-rs/issues/3889)
Do we have a list of regression to be fixed in arrow 36.0.0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] tustvold commented on pull request #5441: Update to Arrow 35.0.0
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #5441:
URL: https://github.com/apache/arrow-datafusion/pull/5441#issuecomment-1479358238
Closing in favor of https://github.com/apache/arrow-datafusion/pull/5685
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #5441: Update to Arrow 35.0.0
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #5441:
URL: https://github.com/apache/arrow-datafusion/pull/5441#discussion_r1135685360
##########
datafusion/core/tests/sql/timestamp.rs:
##########
@@ -1411,14 +1411,14 @@ async fn cast_timestamp_before_1970() -> Result<()> {
assert_batches_eq!(expected, &actual);
- let sql = "select cast('1969-01-01T00:00:00.1Z' as timestamp);";
+ let sql = "select cast('1969-01-01T00:00:00.100Z' as timestamp);";
Review Comment:
Filed upstream issue: https://github.com/apache/arrow-rs/issues/3859 (I think https://github.com/apache/arrow-rs/pull/3858 fixes it)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org