You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/02/04 04:28:55 UTC
[GitHub] [skywalking] kezhenxu94 opened a new pull request #6318: Metrics combination API supports abandoning results
kezhenxu94 opened a new pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318
<!--
⚠️ Please make sure to read this template first, pull requests that don't accord with this template
maybe closed without notice.
Texts surrounded by `<` and `>` are meant to be replaced by you, e.g. <framework name>, <issue number>.
Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]`
-->
<!-- ==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👇 ====
### Fix <bug description or the bug issue number or bug issue link>
- [ ] Add a unit test to verify that the fix works.
- [ ] Explain briefly why the bug exists and how to fix it.
==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👆 ==== -->
<!-- ==== 🔌 Remove this line WHEN AND ONLY WHEN you're adding a new plugin, follow the checklist 👇 ====
### Add an agent plugin to support <framework name>
- [ ] Add a test case for the new plugin, refer to [the doc](https://github.com/apache/skywalking/blob/master/docs/en/guides/Plugin-test.md)
- [ ] Add a component id in [the component-libraries.yml](https://github.com/apache/skywalking/blob/master/oap-server/server-bootstrap/src/main/resources/component-libraries.yml)
- [ ] Add a logo in [the UI repo](https://github.com/apache/skywalking-rocketbot-ui/tree/master/src/views/components/topology/assets)
==== 🔌 Remove this line WHEN AND ONLY WHEN you're adding a new plugin, follow the checklist 👆 ==== -->
<!-- ==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👇 ====
### Improve the performance of <class or module or ...>
- [ ] Add a benchmark for the improvement, refer to [the existing ones](https://github.com/apache/skywalking/blob/master/apm-commons/apm-datacarrier/src/test/java/org/apache/skywalking/apm/commons/datacarrier/LinkedArrayBenchmark.java)
- [ ] The benchmark result.
```text
<Paste the benchmark results here>
```
- [ ] Links/URLs to the theory proof or discussion articles/blogs. <links/URLs here>
==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👆 ==== -->
<!-- ==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👇 ====
### <Feature description>
- [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
- [ ] Update the documentation to include this new feature.
- [ ] Tests(including UT, IT, E2E) are added to verify the new feature.
- [ ] If it's UI related, attach the screenshots below.
==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👆 ==== -->
- [x] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Related #6183 .
- [x] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/CHANGES.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (d1c74a1) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **increase** coverage by `8.82%`.
> The diff coverage is `43.75%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
+ Coverage 34.34% 43.17% +8.82%
- Complexity 2334 2495 +161
============================================
Files 947 795 -152
Lines 23363 19807 -3556
Branches 2249 1872 -377
============================================
+ Hits 8025 8552 +527
+ Misses 14739 10588 -4151
- Partials 599 667 +68
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=) | `2.43% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| ... and [290 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...8dbc02c](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (a42823c) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **decrease** coverage by `7.06%`.
> The diff coverage is `44.18%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
- Coverage 49.57% 42.51% -7.07%
+ Complexity 3452 3001 -451
============================================
Files 952 928 -24
Lines 23656 22900 -756
Branches 2315 2237 -78
============================================
- Hits 11728 9736 -1992
- Misses 10915 12324 +1409
+ Partials 1013 840 -173
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (ø)` | `10.00 <0.00> (ø)` | |
| ... and [222 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...78ea166](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#discussion_r570009978
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/metrics/Metrics.java
##########
@@ -56,8 +56,9 @@
* Merge the given metrics instance, these two must be the same metrics type.
*
* @param metrics to be merged
+ * @return {@code true} if the combined metrics should be continuously processed, {@code false} it should be abandoned.
Review comment:
```suggestion
* @return {@code true} if the combined metrics should be continuously processed. {@code false} means it should be abandoned, and keep the data unaltered in this case.
```
I add a little more to the comments, from my code reading, if the change has been made, the data will still flush into the database eventually.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (8dbc02c) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **increase** coverage by `14.15%`.
> The diff coverage is `45.83%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
=============================================
+ Coverage 30.94% 45.09% +14.15%
- Complexity 2137 3223 +1086
=============================================
Files 947 946 -1
Lines 23363 23460 +97
Branches 2249 2283 +34
=============================================
+ Hits 7230 10580 +3350
+ Misses 15601 11979 -3622
- Partials 532 901 +369
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (ø)` | `10.00 <0.00> (ø)` | |
| ... and [334 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...8dbc02c](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (8bc6701) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **decrease** coverage by `0.34%`.
> The diff coverage is `44.18%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
- Coverage 48.28% 47.93% -0.35%
+ Complexity 3381 3356 -25
============================================
Files 951 946 -5
Lines 23636 23436 -200
Branches 2300 2277 -23
============================================
- Hits 11412 11234 -178
+ Misses 11246 11230 -16
+ Partials 978 972 -6
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (ø)` | `10.00 <0.00> (ø)` | |
| ... and [122 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...78ea166](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (deff976) into [master](https://codecov.io/gh/apache/skywalking/commit/d12d3f201a315241bd7aeb5cc97c2d5103e67c02?el=desc) (d12d3f2) will **decrease** coverage by `26.18%`.
> The diff coverage is `20.83%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
=============================================
- Coverage 53.22% 27.03% -26.19%
+ Complexity 3845 1646 -2199
=============================================
Files 1731 777 -954
Lines 36905 19006 -17899
Branches 4076 1751 -2325
=============================================
- Hits 19642 5139 -14503
+ Misses 16288 13496 -2792
+ Partials 975 371 -604
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-7.70%)` | `4.00 <0.00> (ø)` | |
| [...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=) | `2.43% <0.00%> (-56.10%)` | `0.00 <0.00> (-5.00)` | |
| [...on/endpoint/EndpointRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL2VuZHBvaW50L0VuZHBvaW50UmVsYXRpb25TZXJ2ZXJTaWRlTWV0cmljcy5qYXZh) | `1.92% <0.00%> (-73.08%)` | `0.00 <0.00> (-7.00)` | |
| [...ance/ServiceInstanceRelationClientSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL2luc3RhbmNlL1NlcnZpY2VJbnN0YW5jZVJlbGF0aW9uQ2xpZW50U2lkZU1ldHJpY3MuamF2YQ==) | `1.69% <0.00%> (-69.50%)` | `0.00 <0.00> (-7.00)` | |
| [...ance/ServiceInstanceRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL2luc3RhbmNlL1NlcnZpY2VJbnN0YW5jZVJlbGF0aW9uU2VydmVyU2lkZU1ldHJpY3MuamF2YQ==) | `1.69% <0.00%> (-69.50%)` | `0.00 <0.00> (-7.00)` | |
| [...tion/service/ServiceRelationClientSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL3NlcnZpY2UvU2VydmljZVJlbGF0aW9uQ2xpZW50U2lkZU1ldHJpY3MuamF2YQ==) | `2.12% <0.00%> (-70.22%)` | `0.00 <0.00> (-7.00)` | |
| [...tion/service/ServiceRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL3NlcnZpY2UvU2VydmljZVJlbGF0aW9uU2VydmVyU2lkZU1ldHJpY3MuamF2YQ==) | `2.12% <0.00%> (-70.22%)` | `0.00 <0.00> (-7.00)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (-56.25%)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-12.20%)` | `0.00 <0.00> (ø)` | |
| [.../core/analysis/meter/function/avg/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0Z1bmN0aW9uLmphdmE=) | `4.10% <0.00%> (-67.52%)` | `2.00 <0.00> (-12.00)` | |
| ... and [1450 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [d12d3f2...deff976](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (33cc185) into [master](https://codecov.io/gh/apache/skywalking/commit/d12d3f201a315241bd7aeb5cc97c2d5103e67c02?el=desc) (d12d3f2) will **increase** coverage by `0.94%`.
> The diff coverage is `47.91%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
+ Coverage 53.22% 54.16% +0.94%
+ Complexity 3845 3736 -109
============================================
Files 1731 946 -785
Lines 36905 23510 -13395
Branches 4076 2299 -1777
============================================
- Hits 19642 12735 -6907
+ Misses 16288 9617 -6671
- Partials 975 1158 +183
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-7.70%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (-56.25%)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-12.20%)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (-58.14%)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (-85.72%)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (-27.28%)` | `10.00 <0.00> (ø)` | |
| ... and [1248 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...8dbc02c](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (8bc6701) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **decrease** coverage by `1.55%`.
> The diff coverage is `44.18%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
- Coverage 48.28% 46.73% -1.56%
+ Complexity 3381 3284 -97
============================================
Files 951 946 -5
Lines 23636 23436 -200
Branches 2300 2277 -23
============================================
- Hits 11412 10952 -460
- Misses 11246 11522 +276
+ Partials 978 962 -16
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (ø)` | `10.00 <0.00> (ø)` | |
| ... and [132 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...78ea166](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (d1c74a1) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **increase** coverage by `16.51%`.
> The diff coverage is `47.91%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
=============================================
+ Coverage 34.34% 50.86% +16.51%
- Complexity 2334 3548 +1214
=============================================
Files 947 946 -1
Lines 23363 23463 +100
Branches 2249 2294 +45
=============================================
+ Hits 8025 11935 +3910
+ Misses 14739 10437 -4302
- Partials 599 1091 +492
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (ø)` | `10.00 <0.00> (ø)` | |
| ... and [351 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...8dbc02c](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (d1c74a1) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **increase** coverage by `15.72%`.
> The diff coverage is `47.91%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
=============================================
+ Coverage 34.34% 50.07% +15.72%
- Complexity 2334 3491 +1157
=============================================
Files 947 946 -1
Lines 23363 23463 +100
Branches 2249 2294 +45
=============================================
+ Hits 8025 11750 +3725
+ Misses 14739 10633 -4106
- Partials 599 1080 +481
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (ø)` | `10.00 <0.00> (ø)` | |
| ... and [340 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...8dbc02c](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (8bc6701) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **increase** coverage by `2.60%`.
> The diff coverage is `44.18%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
+ Coverage 48.28% 50.88% +2.60%
- Complexity 3381 3515 +134
============================================
Files 951 946 -5
Lines 23636 23455 -181
Branches 2300 2277 -23
============================================
+ Hits 11412 11935 +523
+ Misses 11246 10488 -758
- Partials 978 1032 +54
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (ø)` | `10.00 <0.00> (ø)` | |
| ... and [114 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...78ea166](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (8bc6701) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **increase** coverage by `2.61%`.
> The diff coverage is `44.18%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
+ Coverage 48.28% 50.90% +2.61%
- Complexity 3381 3516 +135
============================================
Files 951 946 -5
Lines 23636 23455 -181
Branches 2300 2277 -23
============================================
+ Hits 11412 11939 +527
+ Misses 11246 10484 -762
- Partials 978 1032 +54
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (ø)` | `10.00 <0.00> (ø)` | |
| ... and [113 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...78ea166](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (33cc185) into [master](https://codecov.io/gh/apache/skywalking/commit/d12d3f201a315241bd7aeb5cc97c2d5103e67c02?el=desc) (d12d3f2) will **increase** coverage by `0.94%`.
> The diff coverage is `47.91%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
+ Coverage 53.22% 54.16% +0.94%
+ Complexity 3845 3733 -112
============================================
Files 1731 946 -785
Lines 36905 23501 -13404
Branches 4076 2284 -1792
============================================
- Hits 19642 12730 -6912
+ Misses 16288 9613 -6675
- Partials 975 1158 +183
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-7.70%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (-56.25%)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-12.20%)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (-58.14%)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (-85.72%)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (-27.28%)` | `10.00 <0.00> (ø)` | |
| ... and [1253 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [d12d3f2...deff976](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (d1c74a1) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **increase** coverage by `19.22%`.
> The diff coverage is `47.91%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
=============================================
+ Coverage 34.34% 53.57% +19.22%
- Complexity 2334 3678 +1344
=============================================
Files 947 946 -1
Lines 23363 23499 +136
Branches 2249 2295 +46
=============================================
+ Hits 8025 12590 +4565
+ Misses 14739 9770 -4969
- Partials 599 1139 +540
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (ø)` | `10.00 <0.00> (ø)` | |
| ... and [340 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...4704c12](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#discussion_r570033843
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/metrics/Metrics.java
##########
@@ -56,8 +56,9 @@
* Merge the given metrics instance, these two must be the same metrics type.
*
* @param metrics to be merged
+ * @return {@code true} if the combined metrics should be continuously processed, {@code false} it should be abandoned.
Review comment:
Because only limited `Event` data falls into this case, this may be not a big problem for now. Anyway, let me check and think about how to deal with this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (8bc6701) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **decrease** coverage by `0.65%`.
> The diff coverage is `44.18%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
- Coverage 48.28% 47.62% -0.66%
+ Complexity 3381 3338 -43
============================================
Files 951 946 -5
Lines 23636 23436 -200
Branches 2300 2277 -23
============================================
- Hits 11412 11161 -251
- Misses 11246 11307 +61
+ Partials 978 968 -10
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (ø)` | `10.00 <0.00> (ø)` | |
| ... and [124 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...78ea166](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (8dbc02c) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **increase** coverage by `12.99%`.
> The diff coverage is `45.83%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
=============================================
+ Coverage 30.94% 43.93% +12.99%
- Complexity 2137 3080 +943
=============================================
Files 947 929 -18
Lines 23363 22946 -417
Branches 2249 2228 -21
=============================================
+ Hits 7230 10082 +2852
+ Misses 15601 12000 -3601
- Partials 532 864 +332
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (ø)` | `10.00 <0.00> (ø)` | |
| ... and [366 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...8dbc02c](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (8bc6701) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **decrease** coverage by `7.25%`.
> The diff coverage is `41.86%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
- Coverage 48.28% 41.02% -7.26%
+ Complexity 3381 2947 -434
============================================
Files 951 946 -5
Lines 23636 23415 -221
Branches 2300 2277 -23
============================================
- Hits 11412 9606 -1806
- Misses 11246 12952 +1706
+ Partials 978 857 -121
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=) | `2.43% <0.00%> (-56.10%)` | `0.00 <0.00> (-5.00)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| ... and [187 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...4704c12](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (78ea166) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **decrease** coverage by `7.64%`.
> The diff coverage is `39.53%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
- Coverage 49.57% 41.93% -7.65%
+ Complexity 3452 2988 -464
============================================
Files 952 944 -8
Lines 23656 23205 -451
Branches 2315 2239 -76
============================================
- Hits 11728 9731 -1997
- Misses 10915 12626 +1711
+ Partials 1013 848 -165
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=) | `2.43% <0.00%> (-56.10%)` | `0.00 <0.00> (-5.00)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...r/function/avg/AvgHistogramPercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbVBlcmNlbnRpbGVGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (-62.12%)` | `0.00 <0.00> (-25.00)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| ... and [166 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...78ea166](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (78ea166) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **decrease** coverage by `12.42%`.
> The diff coverage is `39.53%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
=============================================
- Coverage 49.57% 37.15% -12.43%
+ Complexity 3452 2689 -763
=============================================
Files 952 944 -8
Lines 23656 23196 -460
Branches 2315 2239 -76
=============================================
- Hits 11728 8618 -3110
- Misses 10915 13814 +2899
+ Partials 1013 764 -249
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=) | `2.43% <0.00%> (-56.10%)` | `0.00 <0.00> (-5.00)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...r/function/avg/AvgHistogramPercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbVBlcmNlbnRpbGVGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (-62.12%)` | `0.00 <0.00> (-25.00)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| ... and [219 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...78ea166](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (a42823c) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **increase** coverage by `4.56%`.
> The diff coverage is `46.51%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
+ Coverage 49.57% 54.13% +4.56%
- Complexity 3452 3748 +296
============================================
Files 952 946 -6
Lines 23656 23527 -129
Branches 2315 2299 -16
============================================
+ Hits 11728 12737 +1009
+ Misses 10915 9685 -1230
- Partials 1013 1105 +92
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (ø)` | `10.00 <0.00> (ø)` | |
| ... and [135 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...78ea166](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (d1c74a1) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **increase** coverage by `12.89%`.
> The diff coverage is `47.91%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
=============================================
+ Coverage 34.34% 47.24% +12.89%
- Complexity 2334 2712 +378
=============================================
Files 947 795 -152
Lines 23363 19846 -3517
Branches 2249 1888 -361
=============================================
+ Hits 8025 9376 +1351
+ Misses 14739 9702 -5037
- Partials 599 768 +169
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (ø)` | `10.00 <0.00> (ø)` | |
| ... and [334 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...8dbc02c](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#discussion_r570011844
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/metrics/Metrics.java
##########
@@ -56,8 +56,9 @@
* Merge the given metrics instance, these two must be the same metrics type.
*
* @param metrics to be merged
+ * @return {@code true} if the combined metrics should be continuously processed, {@code false} it should be abandoned.
Review comment:
Also, I feel the data in the cache has refreshed repeatedly into database even without change, could you recheck about this too? If so, we need to fix that in another PR, which should be able to reduce the database load.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (33cc185) into [master](https://codecov.io/gh/apache/skywalking/commit/d12d3f201a315241bd7aeb5cc97c2d5103e67c02?el=desc) (d12d3f2) will **decrease** coverage by `1.05%`.
> The diff coverage is `47.91%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
- Coverage 53.22% 52.16% -1.06%
+ Complexity 3845 3630 -215
============================================
Files 1731 946 -785
Lines 36905 23482 -13423
Branches 4076 2284 -1792
============================================
- Hits 19642 12249 -7393
+ Misses 16288 10113 -6175
- Partials 975 1120 +145
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-7.70%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (-56.25%)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-12.20%)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (-58.14%)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (-85.72%)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (-27.28%)` | `10.00 <0.00> (ø)` | |
| ... and [1262 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [d12d3f2...deff976](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (8bc6701) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **increase** coverage by `0.38%`.
> The diff coverage is `44.18%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
+ Coverage 48.28% 48.66% +0.38%
- Complexity 3381 3405 +24
============================================
Files 951 946 -5
Lines 23636 23436 -200
Branches 2300 2277 -23
============================================
- Hits 11412 11405 -7
+ Misses 11246 11047 -199
- Partials 978 984 +6
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (ø)` | `10.00 <0.00> (ø)` | |
| ... and [132 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...78ea166](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (33cc185) into [master](https://codecov.io/gh/apache/skywalking/commit/d12d3f201a315241bd7aeb5cc97c2d5103e67c02?el=desc) (d12d3f2) will **decrease** coverage by `6.53%`.
> The diff coverage is `45.83%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
- Coverage 53.22% 46.68% -6.54%
+ Complexity 3845 3284 -561
============================================
Files 1731 946 -785
Lines 36905 23436 -13469
Branches 4076 2278 -1798
============================================
- Hits 19642 10941 -8701
+ Misses 16288 11530 -4758
+ Partials 975 965 -10
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-7.70%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (-56.25%)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-12.20%)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (-58.14%)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (-85.72%)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (-27.28%)` | `10.00 <0.00> (ø)` | |
| ... and [1298 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [d12d3f2...deff976](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (deff976) into [master](https://codecov.io/gh/apache/skywalking/commit/d12d3f201a315241bd7aeb5cc97c2d5103e67c02?el=desc) (d12d3f2) will **decrease** coverage by `3.51%`.
> The diff coverage is `45.83%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
- Coverage 53.22% 49.70% -3.52%
+ Complexity 3845 3488 -357
============================================
Files 1731 946 -785
Lines 36905 23497 -13408
Branches 4076 2281 -1795
============================================
- Hits 19642 11679 -7963
+ Misses 16288 10796 -5492
- Partials 975 1022 +47
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-7.70%)` | `4.00 <0.00> (ø)` | |
| [...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=) | `2.43% <0.00%> (-56.10%)` | `0.00 <0.00> (-5.00)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (-56.25%)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-12.20%)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (-58.14%)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (-85.72%)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00 <0.00> (ø)` | |
| ... and [1280 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [d12d3f2...deff976](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (8bc6701) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **increase** coverage by `2.71%`.
> The diff coverage is `44.18%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
+ Coverage 48.28% 50.99% +2.71%
- Complexity 3381 3526 +145
============================================
Files 951 946 -5
Lines 23636 23455 -181
Branches 2300 2277 -23
============================================
+ Hits 11412 11961 +549
+ Misses 11246 10465 -781
- Partials 978 1029 +51
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (ø)` | `10.00 <0.00> (ø)` | |
| ... and [118 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...78ea166](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#discussion_r570025946
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/metrics/Metrics.java
##########
@@ -56,8 +56,9 @@
* Merge the given metrics instance, these two must be the same metrics type.
*
* @param metrics to be merged
+ * @return {@code true} if the combined metrics should be continuously processed, {@code false} it should be abandoned.
Review comment:
> Also, I feel the data in the cache has refreshed repeatedly into database even without change, could you recheck about this too? If so, we need to fix that in another PR, which should be able to reduce the database load.
@kezhenxu94 ⬆️ What do you think about this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (a42823c) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **decrease** coverage by `13.23%`.
> The diff coverage is `41.86%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
=============================================
- Coverage 49.57% 36.34% -13.24%
+ Complexity 3452 2108 -1344
=============================================
Files 952 778 -174
Lines 23656 19287 -4369
Branches 2315 1828 -487
=============================================
- Hits 11728 7009 -4719
- Misses 10915 11733 +818
+ Partials 1013 545 -468
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=) | `2.43% <0.00%> (-56.10%)` | `0.00 <0.00> (-5.00)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| ... and [351 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...78ea166](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (8bc6701) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **decrease** coverage by `7.25%`.
> The diff coverage is `41.86%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
- Coverage 48.28% 41.02% -7.26%
+ Complexity 3381 2947 -434
============================================
Files 951 946 -5
Lines 23636 23415 -221
Branches 2300 2277 -23
============================================
- Hits 11412 9606 -1806
- Misses 11246 12952 +1706
+ Partials 978 857 -121
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=) | `2.43% <0.00%> (-56.10%)` | `0.00 <0.00> (-5.00)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| ... and [187 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...78ea166](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (8dbc02c) into [master](https://codecov.io/gh/apache/skywalking/commit/d12d3f201a315241bd7aeb5cc97c2d5103e67c02?el=desc) (d12d3f2) will **decrease** coverage by `16.91%`.
> The diff coverage is `43.75%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
=============================================
- Coverage 53.22% 36.30% -16.92%
+ Complexity 3845 2120 -1725
=============================================
Files 1731 778 -953
Lines 36905 19285 -17620
Branches 4076 1818 -2258
=============================================
- Hits 19642 7002 -12640
+ Misses 16288 11748 -4540
+ Partials 975 535 -440
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-7.70%)` | `4.00 <0.00> (ø)` | |
| [...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=) | `2.43% <0.00%> (-56.10%)` | `0.00 <0.00> (-5.00)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (-56.25%)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-12.20%)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (-58.14%)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (-85.72%)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00 <0.00> (ø)` | |
| ... and [1402 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...8dbc02c](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (d1c74a1) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **increase** coverage by `18.50%`.
> The diff coverage is `47.91%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
=============================================
+ Coverage 34.34% 52.85% +18.50%
- Complexity 2334 3650 +1316
=============================================
Files 947 946 -1
Lines 23363 23482 +119
Branches 2249 2294 +45
=============================================
+ Hits 8025 12412 +4387
+ Misses 14739 9941 -4798
- Partials 599 1129 +530
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (ø)` | `10.00 <0.00> (ø)` | |
| ... and [334 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...8dbc02c](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#discussion_r570042410
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/metrics/Metrics.java
##########
@@ -56,8 +56,9 @@
* Merge the given metrics instance, these two must be the same metrics type.
*
* @param metrics to be merged
+ * @return {@code true} if the combined metrics should be continuously processed, {@code false} it should be abandoned.
Review comment:
> I don't mean the change you made, I mean for all metrics, if the metrics exist in the cache, even no update, they are keeping being updated periodly.
OK I mistakenly thought you only referred to the "abandoned" metrics, it makes sense to me now, I'll check
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (deff976) into [master](https://codecov.io/gh/apache/skywalking/commit/d12d3f201a315241bd7aeb5cc97c2d5103e67c02?el=desc) (d12d3f2) will **decrease** coverage by `11.45%`.
> The diff coverage is `37.50%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
=============================================
- Coverage 53.22% 41.77% -11.46%
+ Complexity 3845 3085 -760
=============================================
Files 1731 945 -786
Lines 36905 23392 -13513
Branches 4076 2274 -1802
=============================================
- Hits 19642 9771 -9871
+ Misses 16288 12742 -3546
+ Partials 975 879 -96
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-7.70%)` | `4.00 <0.00> (ø)` | |
| [...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=) | `2.43% <0.00%> (-56.10%)` | `0.00 <0.00> (-5.00)` | |
| [...on/endpoint/EndpointRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL2VuZHBvaW50L0VuZHBvaW50UmVsYXRpb25TZXJ2ZXJTaWRlTWV0cmljcy5qYXZh) | `1.92% <0.00%> (-73.08%)` | `0.00 <0.00> (-7.00)` | |
| [...ance/ServiceInstanceRelationClientSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL2luc3RhbmNlL1NlcnZpY2VJbnN0YW5jZVJlbGF0aW9uQ2xpZW50U2lkZU1ldHJpY3MuamF2YQ==) | `1.69% <0.00%> (-69.50%)` | `0.00 <0.00> (-7.00)` | |
| [...tion/service/ServiceRelationClientSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL3NlcnZpY2UvU2VydmljZVJlbGF0aW9uQ2xpZW50U2lkZU1ldHJpY3MuamF2YQ==) | `2.12% <0.00%> (-70.22%)` | `0.00 <0.00> (-7.00)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (-56.25%)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-12.20%)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (-58.14%)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-50.00%)` | `0.00 <0.00> (ø)` | |
| ... and [1325 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [d12d3f2...deff976](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (8dbc02c) into [master](https://codecov.io/gh/apache/skywalking/commit/d12d3f201a315241bd7aeb5cc97c2d5103e67c02?el=desc) (d12d3f2) will **decrease** coverage by `14.57%`.
> The diff coverage is `45.83%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
=============================================
- Coverage 53.22% 38.65% -14.58%
+ Complexity 3845 2236 -1609
=============================================
Files 1731 778 -953
Lines 36905 19319 -17586
Branches 4076 1821 -2255
=============================================
- Hits 19642 7467 -12175
+ Misses 16288 11285 -5003
+ Partials 975 567 -408
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-7.70%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (-56.25%)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-12.20%)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (-58.14%)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (-85.72%)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (-27.28%)` | `10.00 <0.00> (ø)` | |
| ... and [1386 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...8dbc02c](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (33cc185) into [master](https://codecov.io/gh/apache/skywalking/commit/d12d3f201a315241bd7aeb5cc97c2d5103e67c02?el=desc) (d12d3f2) will **decrease** coverage by `4.93%`.
> The diff coverage is `45.83%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
- Coverage 53.22% 48.29% -4.94%
+ Complexity 3845 3386 -459
============================================
Files 1731 946 -785
Lines 36905 23464 -13441
Branches 4076 2283 -1793
============================================
- Hits 19642 11331 -8311
+ Misses 16288 11154 -5134
- Partials 975 979 +4
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-7.70%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (-56.25%)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-12.20%)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (-58.14%)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (-85.72%)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (-27.28%)` | `10.00 <0.00> (ø)` | |
| ... and [1291 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [d12d3f2...deff976](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (8dbc02c) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **increase** coverage by `12.26%`.
> The diff coverage is `45.83%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
=============================================
+ Coverage 34.34% 46.61% +12.26%
- Complexity 2334 3335 +1001
=============================================
Files 947 946 -1
Lines 23363 23460 +97
Branches 2249 2283 +34
=============================================
+ Hits 8025 10935 +2910
+ Misses 14739 11589 -3150
- Partials 599 936 +337
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (ø)` | `10.00 <0.00> (ø)` | |
| ... and [338 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...8dbc02c](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (a42823c) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **increase** coverage by `6.64%`.
> The diff coverage is `46.51%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
+ Coverage 49.57% 56.22% +6.64%
- Complexity 3452 3833 +381
============================================
Files 952 946 -6
Lines 23656 23537 -119
Branches 2315 2300 -15
============================================
+ Hits 11728 13233 +1505
+ Misses 10915 9168 -1747
- Partials 1013 1136 +123
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (ø)` | `10.00 <0.00> (ø)` | |
| ... and [153 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...78ea166](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (a42823c) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **increase** coverage by `2.11%`.
> The diff coverage is `44.18%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
+ Coverage 49.57% 51.69% +2.11%
- Complexity 3452 3588 +136
============================================
Files 952 946 -6
Lines 23656 23509 -147
Branches 2315 2298 -17
============================================
+ Hits 11728 12152 +424
+ Misses 10915 10341 -574
- Partials 1013 1016 +3
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (ø)` | `10.00 <0.00> (ø)` | |
| ... and [99 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...78ea166](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 merged pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (d1c74a1) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **increase** coverage by `18.50%`.
> The diff coverage is `47.91%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
=============================================
+ Coverage 34.34% 52.85% +18.50%
- Complexity 2334 3650 +1316
=============================================
Files 947 946 -1
Lines 23363 23482 +119
Branches 2249 2294 +45
=============================================
+ Hits 8025 12412 +4387
+ Misses 14739 9941 -4798
- Partials 599 1129 +530
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (ø)` | `10.00 <0.00> (ø)` | |
| ... and [334 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...4704c12](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (33cc185) into [master](https://codecov.io/gh/apache/skywalking/commit/d12d3f201a315241bd7aeb5cc97c2d5103e67c02?el=desc) (d12d3f2) will **increase** coverage by `0.94%`.
> The diff coverage is `47.91%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
+ Coverage 53.22% 54.16% +0.94%
+ Complexity 3845 3736 -109
============================================
Files 1731 946 -785
Lines 36905 23510 -13395
Branches 4076 2299 -1777
============================================
- Hits 19642 12735 -6907
+ Misses 16288 9617 -6671
- Partials 975 1158 +183
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-7.70%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (-56.25%)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-12.20%)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (-58.14%)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (-85.72%)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (-27.28%)` | `10.00 <0.00> (ø)` | |
| ... and [1248 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [d12d3f2...deff976](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (a42823c) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **decrease** coverage by `2.64%`.
> The diff coverage is `44.18%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
- Coverage 49.57% 46.93% -2.65%
+ Complexity 3452 3310 -142
============================================
Files 952 945 -7
Lines 23656 23464 -192
Branches 2315 2294 -21
============================================
- Hits 11728 11013 -715
- Misses 10915 11513 +598
+ Partials 1013 938 -75
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (ø)` | `10.00 <0.00> (ø)` | |
| ... and [142 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...78ea166](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (d1c74a1) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **increase** coverage by `3.34%`.
> The diff coverage is `54.16%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
+ Coverage 48.28% 51.62% +3.34%
- Complexity 3381 3678 +297
============================================
Files 951 1731 +780
Lines 23636 36908 +13272
Branches 2300 4081 +1781
============================================
+ Hits 11412 19053 +7641
- Misses 11246 16875 +5629
- Partials 978 980 +2
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `66.66% <0.00%> (-33.34%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `56.25% <0.00%> (+56.25%)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `12.19% <0.00%> (+12.19%)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `62.79% <0.00%> (+62.79%)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `58.13% <0.00%> (+58.13%)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `50.00% <0.00%> (+50.00%)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `90.90% <ø> (+27.27%)` | `10.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MinDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Eb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/analysis/metrics/PxxMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9QeHhNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| ... and [1278 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...78ea166](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (8dbc02c) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **increase** coverage by `5.81%`.
> The diff coverage is `45.83%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
+ Coverage 36.76% 42.58% +5.81%
- Complexity 2137 3009 +872
============================================
Files 794 929 +135
Lines 19664 22936 +3272
Branches 1834 2227 +393
============================================
+ Hits 7230 9767 +2537
- Misses 11902 12314 +412
- Partials 532 855 +323
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (ø)` | `10.00 <0.00> (ø)` | |
| ... and [357 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...8dbc02c](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (deff976) into [master](https://codecov.io/gh/apache/skywalking/commit/d12d3f201a315241bd7aeb5cc97c2d5103e67c02?el=desc) (d12d3f2) will **decrease** coverage by `3.87%`.
> The diff coverage is `52.08%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
- Coverage 53.22% 49.34% -3.88%
+ Complexity 3845 3488 -357
============================================
Files 1731 1731
Lines 36905 36903 -2
Branches 4076 4077 +1
============================================
- Hits 19642 18210 -1432
- Misses 16288 17716 +1428
- Partials 975 977 +2
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `66.66% <0.00%> (-17.95%)` | `4.00 <0.00> (ø)` | |
| [...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=) | `2.43% <0.00%> (-56.10%)` | `0.00 <0.00> (-5.00)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `56.25% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `12.19% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `62.79% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `58.13% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `50.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `90.90% <ø> (ø)` | `10.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MinDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Eb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| ... and [139 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [d12d3f2...deff976](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (d1c74a1) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **increase** coverage by `15.78%`.
> The diff coverage is `47.91%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
=============================================
+ Coverage 34.34% 50.13% +15.78%
- Complexity 2334 3499 +1165
=============================================
Files 947 946 -1
Lines 23363 23463 +100
Branches 2249 2294 +45
=============================================
+ Hits 8025 11764 +3739
+ Misses 14739 10620 -4119
- Partials 599 1079 +480
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (ø)` | `10.00 <0.00> (ø)` | |
| ... and [341 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...8dbc02c](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (d1c74a1) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **increase** coverage by `11.04%`.
> The diff coverage is `45.83%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
=============================================
+ Coverage 34.34% 45.39% +11.04%
- Complexity 2334 2587 +253
=============================================
Files 947 795 -152
Lines 23363 19819 -3544
Branches 2249 1872 -377
=============================================
+ Hits 8025 8996 +971
+ Misses 14739 10113 -4626
- Partials 599 710 +111
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (ø)` | `10.00 <0.00> (ø)` | |
| ... and [301 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...8dbc02c](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (33cc185) into [master](https://codecov.io/gh/apache/skywalking/commit/d12d3f201a315241bd7aeb5cc97c2d5103e67c02?el=desc) (d12d3f2) will **increase** coverage by `0.92%`.
> The diff coverage is `47.91%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
+ Coverage 53.22% 54.15% +0.92%
+ Complexity 3845 3732 -113
============================================
Files 1731 946 -785
Lines 36905 23501 -13404
Branches 4076 2284 -1792
============================================
- Hits 19642 12726 -6916
+ Misses 16288 9617 -6671
- Partials 975 1158 +183
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-7.70%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (-56.25%)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-12.20%)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (-58.14%)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (-85.72%)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (-27.28%)` | `10.00 <0.00> (ø)` | |
| ... and [1253 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [d12d3f2...deff976](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (8dbc02c) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **increase** coverage by `12.87%`.
> The diff coverage is `45.83%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
=============================================
+ Coverage 34.34% 47.22% +12.87%
- Complexity 2334 3364 +1030
=============================================
Files 947 946 -1
Lines 23363 23460 +97
Branches 2249 2283 +34
=============================================
+ Hits 8025 11078 +3053
+ Misses 14739 11438 -3301
- Partials 599 944 +345
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (ø)` | `10.00 <0.00> (ø)` | |
| ... and [343 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...8dbc02c](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 merged pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (deff976) into [master](https://codecov.io/gh/apache/skywalking/commit/d12d3f201a315241bd7aeb5cc97c2d5103e67c02?el=desc) (d12d3f2) will **decrease** coverage by `3.02%`.
> The diff coverage is `52.08%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
- Coverage 53.22% 50.20% -3.03%
+ Complexity 3845 3542 -303
============================================
Files 1731 1731
Lines 36905 36903 -2
Branches 4076 4077 +1
============================================
- Hits 19642 18526 -1116
- Misses 16288 17400 +1112
- Partials 975 977 +2
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `66.66% <0.00%> (-17.95%)` | `4.00 <0.00> (ø)` | |
| [...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=) | `2.43% <0.00%> (-56.10%)` | `0.00 <0.00> (-5.00)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `56.25% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `12.19% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `62.79% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `58.13% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `50.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `90.90% <ø> (ø)` | `10.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MinDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Eb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| ... and [127 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [d12d3f2...deff976](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (33cc185) into [master](https://codecov.io/gh/apache/skywalking/commit/d12d3f201a315241bd7aeb5cc97c2d5103e67c02?el=desc) (d12d3f2) will **decrease** coverage by `4.22%`.
> The diff coverage is `45.83%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
- Coverage 53.22% 49.00% -4.23%
+ Complexity 3845 3429 -416
============================================
Files 1731 946 -785
Lines 36905 23464 -13441
Branches 4076 2283 -1793
============================================
- Hits 19642 11498 -8144
+ Misses 16288 10973 -5315
- Partials 975 993 +18
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-7.70%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (-56.25%)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-12.20%)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (-58.14%)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (-85.72%)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (-27.28%)` | `10.00 <0.00> (ø)` | |
| ... and [1288 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [d12d3f2...deff976](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (33cc185) into [master](https://codecov.io/gh/apache/skywalking/commit/d12d3f201a315241bd7aeb5cc97c2d5103e67c02?el=desc) (d12d3f2) will **decrease** coverage by `3.52%`.
> The diff coverage is `45.83%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
- Coverage 53.22% 49.69% -3.53%
+ Complexity 3845 3453 -392
============================================
Files 1731 946 -785
Lines 36905 23464 -13441
Branches 4076 2283 -1793
============================================
- Hits 19642 11660 -7982
+ Misses 16288 10765 -5523
- Partials 975 1039 +64
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-7.70%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (-56.25%)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-12.20%)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (-58.14%)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (-85.72%)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (-27.28%)` | `10.00 <0.00> (ø)` | |
| ... and [1285 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [d12d3f2...deff976](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (a42823c) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **decrease** coverage by `12.95%`.
> The diff coverage is `41.86%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
=============================================
- Coverage 49.57% 36.62% -12.96%
+ Complexity 3452 2126 -1326
=============================================
Files 952 778 -174
Lines 23656 19288 -4368
Branches 2315 1830 -485
=============================================
- Hits 11728 7064 -4664
- Misses 10915 11682 +767
+ Partials 1013 542 -471
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=) | `2.43% <0.00%> (-56.10%)` | `0.00 <0.00> (-5.00)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| ... and [353 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...78ea166](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (a42823c) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **increase** coverage by `2.47%`.
> The diff coverage is `44.18%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
+ Coverage 49.57% 52.04% +2.47%
- Complexity 3452 3603 +151
============================================
Files 952 946 -6
Lines 23656 23509 -147
Branches 2315 2298 -17
============================================
+ Hits 11728 12236 +508
+ Misses 10915 10245 -670
- Partials 1013 1028 +15
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (ø)` | `10.00 <0.00> (ø)` | |
| ... and [99 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...78ea166](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (33cc185) into [master](https://codecov.io/gh/apache/skywalking/commit/d12d3f201a315241bd7aeb5cc97c2d5103e67c02?el=desc) (d12d3f2) will **decrease** coverage by `4.05%`.
> The diff coverage is `45.83%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
- Coverage 53.22% 49.16% -4.06%
+ Complexity 3845 3436 -409
============================================
Files 1731 946 -785
Lines 36905 23464 -13441
Branches 4076 2283 -1793
============================================
- Hits 19642 11537 -8105
+ Misses 16288 10922 -5366
- Partials 975 1005 +30
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-7.70%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (-56.25%)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-12.20%)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (-58.14%)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (-85.72%)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (-27.28%)` | `10.00 <0.00> (ø)` | |
| ... and [1287 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [d12d3f2...deff976](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (d1c74a1) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **increase** coverage by `11.26%`.
> The diff coverage is `45.83%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
=============================================
+ Coverage 34.34% 45.61% +11.26%
- Complexity 2334 2597 +263
=============================================
Files 947 795 -152
Lines 23363 19828 -3535
Branches 2249 1887 -362
=============================================
+ Hits 8025 9045 +1020
+ Misses 14739 10061 -4678
- Partials 599 722 +123
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (ø)` | `10.00 <0.00> (ø)` | |
| ... and [306 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...8dbc02c](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (33cc185) into [master](https://codecov.io/gh/apache/skywalking/commit/d12d3f201a315241bd7aeb5cc97c2d5103e67c02?el=desc) (d12d3f2) will **decrease** coverage by `5.48%`.
> The diff coverage is `45.83%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
- Coverage 53.22% 47.73% -5.49%
+ Complexity 3845 3350 -495
============================================
Files 1731 946 -785
Lines 36905 23436 -13469
Branches 4076 2278 -1798
============================================
- Hits 19642 11188 -8454
+ Misses 16288 11276 -5012
+ Partials 975 972 -3
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-7.70%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (-56.25%)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-12.20%)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (-58.14%)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (-85.72%)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (-27.28%)` | `10.00 <0.00> (ø)` | |
| ... and [1293 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [d12d3f2...deff976](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (a42823c) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **decrease** coverage by `11.35%`.
> The diff coverage is `41.86%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
=============================================
- Coverage 49.57% 38.21% -11.36%
+ Complexity 3452 2226 -1226
=============================================
Files 952 778 -174
Lines 23656 19325 -4331
Branches 2315 1835 -480
=============================================
- Hits 11728 7386 -4342
- Misses 10915 11378 +463
+ Partials 1013 561 -452
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=) | `2.43% <0.00%> (-56.10%)` | `0.00 <0.00> (-5.00)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| ... and [361 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...78ea166](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#discussion_r570001405
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/worker/MetricsPersistentWorker.java
##########
@@ -174,21 +175,25 @@ private void flushDataToStorage(List<Metrics> metricsList,
/*
* Merge metrics into cachedMetrics, change only happens inside cachedMetrics.
*/
- cachedMetrics.combine(metrics);
- cachedMetrics.calculate();
- prepareRequests.add(metricsDAO.prepareBatchUpdate(model, cachedMetrics));
- nextWorker(cachedMetrics);
+ isAbandoned = !cachedMetrics.combine(metrics);
+ if (isAbandoned) {
Review comment:
> Or should we see `if isBandoned; continue`?
🤦🏻♂️ my stupid mistake, fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (a42823c) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **decrease** coverage by `6.88%`.
> The diff coverage is `44.18%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
- Coverage 49.57% 42.69% -6.89%
+ Complexity 3452 3018 -434
============================================
Files 952 928 -24
Lines 23656 22900 -756
Branches 2315 2237 -78
============================================
- Hits 11728 9777 -1951
- Misses 10915 12280 +1365
+ Partials 1013 843 -170
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (ø)` | `10.00 <0.00> (ø)` | |
| ... and [209 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...78ea166](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (d1c74a1) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **increase** coverage by `11.05%`.
> The diff coverage is `45.83%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
=============================================
+ Coverage 34.34% 45.40% +11.05%
- Complexity 2334 2589 +255
=============================================
Files 947 795 -152
Lines 23363 19819 -3544
Branches 2249 1872 -377
=============================================
+ Hits 8025 8999 +974
+ Misses 14739 10110 -4629
- Partials 599 710 +111
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (ø)` | `10.00 <0.00> (ø)` | |
| ... and [300 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...8dbc02c](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (78ea166) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **decrease** coverage by `8.28%`.
> The diff coverage is `39.53%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
- Coverage 49.57% 41.29% -8.29%
+ Complexity 3452 2945 -507
============================================
Files 952 944 -8
Lines 23656 23205 -451
Branches 2315 2239 -76
============================================
- Hits 11728 9582 -2146
- Misses 10915 12776 +1861
+ Partials 1013 847 -166
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=) | `2.43% <0.00%> (-56.10%)` | `0.00 <0.00> (-5.00)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...r/function/avg/AvgHistogramPercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbVBlcmNlbnRpbGVGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (-62.12%)` | `0.00 <0.00> (-25.00)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| ... and [179 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...78ea166](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (33cc185) into [master](https://codecov.io/gh/apache/skywalking/commit/d12d3f201a315241bd7aeb5cc97c2d5103e67c02?el=desc) (d12d3f2) will **decrease** coverage by `5.30%`.
> The diff coverage is `45.83%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
- Coverage 53.22% 47.91% -5.31%
+ Complexity 3845 3356 -489
============================================
Files 1731 946 -785
Lines 36905 23436 -13469
Branches 4076 2278 -1798
============================================
- Hits 19642 11230 -8412
+ Misses 16288 11232 -5056
+ Partials 975 974 -1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-7.70%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (-56.25%)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-12.20%)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (-58.14%)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (-85.72%)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (-27.28%)` | `10.00 <0.00> (ø)` | |
| ... and [1293 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [d12d3f2...deff976](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (a42823c) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **increase** coverage by `3.44%`.
> The diff coverage is `53.48%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
+ Coverage 49.57% 53.02% +3.44%
- Complexity 3452 3842 +390
============================================
Files 952 1731 +779
Lines 23656 36910 +13254
Branches 2315 4080 +1765
============================================
+ Hits 11728 19572 +7844
- Misses 10915 16361 +5446
+ Partials 1013 977 -36
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `66.66% <0.00%> (-33.34%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `56.25% <0.00%> (+56.25%)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `12.19% <0.00%> (+12.19%)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `62.79% <0.00%> (+62.79%)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `58.13% <0.00%> (+58.13%)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `50.00% <0.00%> (+50.00%)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `90.90% <ø> (+27.27%)` | `10.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MinDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Eb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/analysis/metrics/PxxMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9QeHhNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| ... and [1280 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...78ea166](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (a42823c) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **decrease** coverage by `6.86%`.
> The diff coverage is `44.18%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
- Coverage 49.57% 42.71% -6.87%
+ Complexity 3452 3018 -434
============================================
Files 952 928 -24
Lines 23656 22900 -756
Branches 2315 2237 -78
============================================
- Hits 11728 9782 -1946
- Misses 10915 12275 +1360
+ Partials 1013 843 -170
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (ø)` | `10.00 <0.00> (ø)` | |
| ... and [208 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...78ea166](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (a42823c) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **increase** coverage by `5.66%`.
> The diff coverage is `46.51%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
+ Coverage 49.57% 55.23% +5.66%
- Complexity 3452 3795 +343
============================================
Files 952 946 -6
Lines 23656 23527 -129
Branches 2315 2299 -16
============================================
+ Hits 11728 12996 +1268
+ Misses 10915 9416 -1499
- Partials 1013 1115 +102
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (ø)` | `10.00 <0.00> (ø)` | |
| ... and [144 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...78ea166](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (a42823c) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **decrease** coverage by `13.36%`.
> The diff coverage is `41.86%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
=============================================
- Coverage 49.57% 36.21% -13.37%
+ Complexity 3452 2100 -1352
=============================================
Files 952 778 -174
Lines 23656 19281 -4375
Branches 2315 1815 -500
=============================================
- Hits 11728 6982 -4746
- Misses 10915 11757 +842
+ Partials 1013 542 -471
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=) | `2.43% <0.00%> (-56.10%)` | `0.00 <0.00> (-5.00)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| ... and [357 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...78ea166](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#discussion_r569991840
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/worker/MetricsPersistentWorker.java
##########
@@ -174,21 +175,25 @@ private void flushDataToStorage(List<Metrics> metricsList,
/*
* Merge metrics into cachedMetrics, change only happens inside cachedMetrics.
*/
- cachedMetrics.combine(metrics);
- cachedMetrics.calculate();
- prepareRequests.add(metricsDAO.prepareBatchUpdate(model, cachedMetrics));
- nextWorker(cachedMetrics);
+ isAbandoned = !cachedMetrics.combine(metrics);
+ if (isAbandoned) {
Review comment:
Or should we see `if isBandoned; continue`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (a42823c) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **increase** coverage by `4.25%`.
> The diff coverage is `46.51%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
+ Coverage 49.57% 53.83% +4.25%
- Complexity 3452 3738 +286
============================================
Files 952 946 -6
Lines 23656 23527 -129
Branches 2315 2299 -16
============================================
+ Hits 11728 12666 +938
+ Misses 10915 9774 -1141
- Partials 1013 1087 +74
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (ø)` | `10.00 <0.00> (ø)` | |
| ... and [132 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...78ea166](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#discussion_r569991293
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/worker/MetricsPersistentWorker.java
##########
@@ -174,21 +175,25 @@ private void flushDataToStorage(List<Metrics> metricsList,
/*
* Merge metrics into cachedMetrics, change only happens inside cachedMetrics.
*/
- cachedMetrics.combine(metrics);
- cachedMetrics.calculate();
- prepareRequests.add(metricsDAO.prepareBatchUpdate(model, cachedMetrics));
- nextWorker(cachedMetrics);
+ isAbandoned = !cachedMetrics.combine(metrics);
+ if (isAbandoned) {
Review comment:
```suggestion
if (!isAbandoned) {
```
Is this reverse?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (33cc185) into [master](https://codecov.io/gh/apache/skywalking/commit/d12d3f201a315241bd7aeb5cc97c2d5103e67c02?el=desc) (d12d3f2) will **increase** coverage by `0.94%`.
> The diff coverage is `47.91%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
+ Coverage 53.22% 54.16% +0.94%
+ Complexity 3845 3736 -109
============================================
Files 1731 946 -785
Lines 36905 23510 -13395
Branches 4076 2299 -1777
============================================
- Hits 19642 12735 -6907
+ Misses 16288 9617 -6671
- Partials 975 1158 +183
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-7.70%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (-56.25%)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-12.20%)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (-58.14%)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (-85.72%)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (-27.28%)` | `10.00 <0.00> (ø)` | |
| ... and [1248 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [d12d3f2...deff976](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (a42823c) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **decrease** coverage by `2.01%`.
> The diff coverage is `44.18%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
- Coverage 49.57% 47.56% -2.02%
+ Complexity 3452 3331 -121
============================================
Files 952 945 -7
Lines 23656 23464 -192
Branches 2315 2294 -21
============================================
- Hits 11728 11161 -567
- Misses 10915 11362 +447
+ Partials 1013 941 -72
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (ø)` | `10.00 <0.00> (ø)` | |
| ... and [138 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...78ea166](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (4704c12) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **decrease** coverage by `16.53%`.
> The diff coverage is `16.27%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
=============================================
- Coverage 43.67% 27.13% -16.54%
+ Complexity 3085 1650 -1435
=============================================
Files 950 777 -173
Lines 23450 19006 -4444
Branches 2266 1750 -516
=============================================
- Hits 10242 5158 -5084
- Misses 12332 13477 +1145
+ Partials 876 371 -505
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=) | `2.43% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...on/endpoint/EndpointRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL2VuZHBvaW50L0VuZHBvaW50UmVsYXRpb25TZXJ2ZXJTaWRlTWV0cmljcy5qYXZh) | `1.92% <0.00%> (-73.08%)` | `0.00 <0.00> (-7.00)` | |
| [...ance/ServiceInstanceRelationClientSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL2luc3RhbmNlL1NlcnZpY2VJbnN0YW5jZVJlbGF0aW9uQ2xpZW50U2lkZU1ldHJpY3MuamF2YQ==) | `1.69% <0.00%> (-69.50%)` | `0.00 <0.00> (-7.00)` | |
| [...ance/ServiceInstanceRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL2luc3RhbmNlL1NlcnZpY2VJbnN0YW5jZVJlbGF0aW9uU2VydmVyU2lkZU1ldHJpY3MuamF2YQ==) | `1.69% <0.00%> (-69.50%)` | `0.00 <0.00> (-7.00)` | |
| [...tion/service/ServiceRelationClientSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL3NlcnZpY2UvU2VydmljZVJlbGF0aW9uQ2xpZW50U2lkZU1ldHJpY3MuamF2YQ==) | `2.12% <0.00%> (-70.22%)` | `0.00 <0.00> (-7.00)` | |
| [...tion/service/ServiceRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL3NlcnZpY2UvU2VydmljZVJlbGF0aW9uU2VydmVyU2lkZU1ldHJpY3MuamF2YQ==) | `2.12% <0.00%> (-70.22%)` | `0.00 <0.00> (-7.00)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [.../core/analysis/meter/function/avg/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0Z1bmN0aW9uLmphdmE=) | `4.10% <0.00%> (-68.50%)` | `2.00 <0.00> (-12.00)` | |
| ... and [444 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...4704c12](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (a42823c) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **increase** coverage by `4.00%`.
> The diff coverage is `46.51%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
+ Coverage 49.57% 53.58% +4.00%
- Complexity 3452 3727 +275
============================================
Files 952 946 -6
Lines 23656 23527 -129
Branches 2315 2299 -16
============================================
+ Hits 11728 12607 +879
+ Misses 10915 9846 -1069
- Partials 1013 1074 +61
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (ø)` | `10.00 <0.00> (ø)` | |
| ... and [130 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...78ea166](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (a42823c) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **increase** coverage by `6.77%`.
> The diff coverage is `46.51%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
+ Coverage 49.57% 56.35% +6.77%
- Complexity 3452 3842 +390
============================================
Files 952 946 -6
Lines 23656 23537 -119
Branches 2315 2300 -15
============================================
+ Hits 11728 13264 +1536
+ Misses 10915 9136 -1779
- Partials 1013 1137 +124
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (ø)` | `10.00 <0.00> (ø)` | |
| ... and [155 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...78ea166](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (78ea166) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **increase** coverage by `7.42%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
+ Coverage 49.57% 57.00% +7.42%
+ Complexity 3452 793 -2659
============================================
Files 952 170 -782
Lines 23656 4133 -19523
Branches 2315 477 -1838
============================================
- Hits 11728 2356 -9372
+ Misses 10915 1475 -9440
+ Partials 1013 302 -711
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/ContextCarrier.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0Q2Fycmllci5qYXZh) | `46.29% <0.00%> (-29.63%)` | `8.00% <0.00%> (-2.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `38.46% <0.00%> (-25.65%)` | `6.00% <0.00%> (-4.00%)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `75.00% <0.00%> (-25.00%)` | `2.00% <0.00%> (-1.00%)` | |
| [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `69.56% <0.00%> (-17.40%)` | `7.00% <0.00%> (-1.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `67.60% <0.00%> (-12.68%)` | `11.00% <0.00%> (-4.00%)` | |
| [...ing/apm/agent/core/context/trace/TraceSegment.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9UcmFjZVNlZ21lbnQuamF2YQ==) | `65.00% <0.00%> (-12.50%)` | `8.00% <0.00%> (-2.00%)` | |
| [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `80.00% <0.00%> (-11.43%)` | `8.00% <0.00%> (-1.00%)` | |
| [...pm/agent/core/context/ids/DistributedTraceIds.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvRGlzdHJpYnV0ZWRUcmFjZUlkcy5qYXZh) | `66.66% <0.00%> (-11.12%)` | `3.00% <0.00%> (-1.00%)` | |
| [.../agent/core/context/status/StatusCheckService.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvU3RhdHVzQ2hlY2tTZXJ2aWNlLmphdmE=) | `70.00% <0.00%> (-10.00%)` | `5.00% <0.00%> (-1.00%)` | |
| ... and [765 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...78ea166](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (a42823c) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **increase** coverage by `4.56%`.
> The diff coverage is `46.51%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
+ Coverage 49.57% 54.13% +4.56%
- Complexity 3452 3748 +296
============================================
Files 952 946 -6
Lines 23656 23527 -129
Branches 2315 2299 -16
============================================
+ Hits 11728 12737 +1009
+ Misses 10915 9685 -1230
- Partials 1013 1105 +92
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (ø)` | `10.00 <0.00> (ø)` | |
| ... and [135 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...78ea166](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (d1c74a1) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **increase** coverage by `9.92%`.
> The diff coverage is `45.83%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
+ Coverage 34.34% 44.27% +9.92%
- Complexity 2334 2547 +213
============================================
Files 947 795 -152
Lines 23363 19819 -3544
Branches 2249 1872 -377
============================================
+ Hits 8025 8775 +750
+ Misses 14739 10363 -4376
- Partials 599 681 +82
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (ø)` | `10.00 <0.00> (ø)` | |
| ... and [297 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...8dbc02c](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (a42823c) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **increase** coverage by `6.61%`.
> The diff coverage is `46.51%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
+ Coverage 49.57% 56.19% +6.61%
- Complexity 3452 3832 +380
============================================
Files 952 946 -6
Lines 23656 23537 -119
Branches 2315 2300 -15
============================================
+ Hits 11728 13227 +1499
+ Misses 10915 9174 -1741
- Partials 1013 1136 +123
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (ø)` | `10.00 <0.00> (ø)` | |
| ... and [153 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...78ea166](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (a42823c) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **increase** coverage by `2.05%`.
> The diff coverage is `44.18%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
+ Coverage 49.57% 51.63% +2.05%
- Complexity 3452 3582 +130
============================================
Files 952 946 -6
Lines 23656 23509 -147
Branches 2315 2298 -17
============================================
+ Hits 11728 12138 +410
+ Misses 10915 10355 -560
- Partials 1013 1016 +3
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (ø)` | `10.00 <0.00> (ø)` | |
| ... and [98 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...78ea166](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (a42823c) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **increase** coverage by `1.15%`.
> The diff coverage is `44.18%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
+ Coverage 49.57% 50.72% +1.15%
- Complexity 3452 3521 +69
============================================
Files 952 945 -7
Lines 23656 23464 -192
Branches 2315 2294 -21
============================================
+ Hits 11728 11903 +175
+ Misses 10915 10566 -349
+ Partials 1013 995 -18
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (ø)` | `10.00 <0.00> (ø)` | |
| ... and [101 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...78ea166](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (a42823c) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **decrease** coverage by `10.50%`.
> The diff coverage is `44.18%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
=============================================
- Coverage 49.57% 39.06% -10.51%
+ Complexity 3452 2263 -1189
=============================================
Files 952 778 -174
Lines 23656 19328 -4328
Branches 2315 1835 -480
=============================================
- Hits 11728 7551 -4177
- Misses 10915 11215 +300
+ Partials 1013 562 -451
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (ø)` | `10.00 <0.00> (ø)` | |
| ... and [358 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...78ea166](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (8dbc02c) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **increase** coverage by `14.33%`.
> The diff coverage is `45.83%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
=============================================
+ Coverage 34.34% 48.68% +14.33%
- Complexity 2334 3423 +1089
=============================================
Files 947 946 -1
Lines 23363 23474 +111
Branches 2249 2284 +35
=============================================
+ Hits 8025 11428 +3403
+ Misses 14739 11073 -3666
- Partials 599 973 +374
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (ø)` | `10.00 <0.00> (ø)` | |
| ... and [345 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...8dbc02c](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (a42823c) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **increase** coverage by `5.77%`.
> The diff coverage is `46.51%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
+ Coverage 49.57% 55.35% +5.77%
- Complexity 3452 3802 +350
============================================
Files 952 946 -6
Lines 23656 23527 -129
Branches 2315 2299 -16
============================================
+ Hits 11728 13023 +1295
+ Misses 10915 9387 -1528
- Partials 1013 1117 +104
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (ø)` | `10.00 <0.00> (ø)` | |
| ... and [145 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...78ea166](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (deff976) into [master](https://codecov.io/gh/apache/skywalking/commit/d12d3f201a315241bd7aeb5cc97c2d5103e67c02?el=desc) (d12d3f2) will **decrease** coverage by `17.78%`.
> The diff coverage is `25.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
=============================================
- Coverage 53.22% 35.43% -17.79%
+ Complexity 3845 2177 -1668
=============================================
Files 1731 794 -937
Lines 36905 19775 -17130
Branches 4076 1868 -2208
=============================================
- Hits 19642 7007 -12635
+ Misses 16288 12208 -4080
+ Partials 975 560 -415
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-7.70%)` | `4.00 <0.00> (ø)` | |
| [...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=) | `2.43% <0.00%> (-56.10%)` | `0.00 <0.00> (-5.00)` | |
| [...on/endpoint/EndpointRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL2VuZHBvaW50L0VuZHBvaW50UmVsYXRpb25TZXJ2ZXJTaWRlTWV0cmljcy5qYXZh) | `1.92% <0.00%> (-73.08%)` | `0.00 <0.00> (-7.00)` | |
| [...ance/ServiceInstanceRelationClientSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL2luc3RhbmNlL1NlcnZpY2VJbnN0YW5jZVJlbGF0aW9uQ2xpZW50U2lkZU1ldHJpY3MuamF2YQ==) | `1.69% <0.00%> (-69.50%)` | `0.00 <0.00> (-7.00)` | |
| [...ance/ServiceInstanceRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL2luc3RhbmNlL1NlcnZpY2VJbnN0YW5jZVJlbGF0aW9uU2VydmVyU2lkZU1ldHJpY3MuamF2YQ==) | `54.23% <0.00%> (-16.95%)` | `6.00 <0.00> (-1.00)` | |
| [...tion/service/ServiceRelationClientSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL3NlcnZpY2UvU2VydmljZVJlbGF0aW9uQ2xpZW50U2lkZU1ldHJpY3MuamF2YQ==) | `2.12% <0.00%> (-70.22%)` | `0.00 <0.00> (-7.00)` | |
| [...tion/service/ServiceRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL3NlcnZpY2UvU2VydmljZVJlbGF0aW9uU2VydmVyU2lkZU1ldHJpY3MuamF2YQ==) | `55.31% <0.00%> (-17.03%)` | `6.00 <0.00> (-1.00)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (-56.25%)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-12.20%)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
| ... and [1400 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [d12d3f2...deff976](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (deff976) into [master](https://codecov.io/gh/apache/skywalking/commit/d12d3f201a315241bd7aeb5cc97c2d5103e67c02?el=desc) (d12d3f2) will **decrease** coverage by `3.02%`.
> The diff coverage is `52.08%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
- Coverage 53.22% 50.19% -3.03%
+ Complexity 3845 3540 -305
============================================
Files 1731 1731
Lines 36905 36903 -2
Branches 4076 4077 +1
============================================
- Hits 19642 18523 -1119
- Misses 16288 17403 +1115
- Partials 975 977 +2
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `66.66% <0.00%> (-17.95%)` | `4.00 <0.00> (ø)` | |
| [...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=) | `2.43% <0.00%> (-56.10%)` | `0.00 <0.00> (-5.00)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `56.25% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `12.19% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `62.79% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `58.13% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `50.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `90.90% <ø> (ø)` | `10.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MinDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Eb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| ... and [128 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [d12d3f2...deff976](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (8bc6701) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **decrease** coverage by `4.69%`.
> The diff coverage is `41.86%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
- Coverage 48.28% 43.58% -4.70%
+ Complexity 3381 3100 -281
============================================
Files 951 946 -5
Lines 23636 23415 -221
Branches 2300 2277 -23
============================================
- Hits 11412 10206 -1206
- Misses 11246 12288 +1042
+ Partials 978 921 -57
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=) | `2.43% <0.00%> (-56.10%)` | `0.00 <0.00> (-5.00)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| ... and [171 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...78ea166](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (a42823c) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **increase** coverage by `6.42%`.
> The diff coverage is `46.51%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
+ Coverage 49.57% 56.00% +6.42%
- Complexity 3452 3825 +373
============================================
Files 952 946 -6
Lines 23656 23537 -119
Branches 2315 2300 -15
============================================
+ Hits 11728 13181 +1453
+ Misses 10915 9222 -1693
- Partials 1013 1134 +121
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (ø)` | `10.00 <0.00> (ø)` | |
| ... and [151 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...78ea166](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (33cc185) into [master](https://codecov.io/gh/apache/skywalking/commit/d12d3f201a315241bd7aeb5cc97c2d5103e67c02?el=desc) (d12d3f2) will **decrease** coverage by `1.92%`.
> The diff coverage is `47.91%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
- Coverage 53.22% 51.30% -1.93%
+ Complexity 3845 3577 -268
============================================
Files 1731 946 -785
Lines 36905 23482 -13423
Branches 4076 2284 -1792
============================================
- Hits 19642 12047 -7595
+ Misses 16288 10337 -5951
- Partials 975 1098 +123
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-7.70%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (-56.25%)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-12.20%)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (-58.14%)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (-85.72%)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (-27.28%)` | `10.00 <0.00> (ø)` | |
| ... and [1266 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [d12d3f2...deff976](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (33cc185) into [master](https://codecov.io/gh/apache/skywalking/commit/d12d3f201a315241bd7aeb5cc97c2d5103e67c02?el=desc) (d12d3f2) will **decrease** coverage by `4.07%`.
> The diff coverage is `45.83%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
- Coverage 53.22% 49.15% -4.08%
+ Complexity 3845 3435 -410
============================================
Files 1731 946 -785
Lines 36905 23464 -13441
Branches 4076 2283 -1793
============================================
- Hits 19642 11533 -8109
+ Misses 16288 10927 -5361
- Partials 975 1004 +29
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-7.70%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (-56.25%)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-12.20%)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (-58.14%)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (-85.72%)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (-27.28%)` | `10.00 <0.00> (ø)` | |
| ... and [1288 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [d12d3f2...deff976](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (4704c12) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **decrease** coverage by `1.34%`.
> The diff coverage is `44.18%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
- Coverage 44.66% 43.31% -1.35%
+ Complexity 3131 2575 -556
============================================
Files 951 795 -156
Lines 23495 19821 -3674
Branches 2270 1884 -386
============================================
- Hits 10493 8585 -1908
+ Misses 12121 10558 -1563
+ Partials 881 678 -203
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=) | `2.43% <0.00%> (-56.10%)` | `0.00 <0.00> (-5.00)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| ... and [350 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...4704c12](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (a42823c) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **decrease** coverage by `12.42%`.
> The diff coverage is `41.86%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
=============================================
- Coverage 49.57% 37.15% -12.43%
+ Complexity 3452 2163 -1289
=============================================
Files 952 778 -174
Lines 23656 19316 -4340
Branches 2315 1835 -480
=============================================
- Hits 11728 7176 -4552
- Misses 10915 11593 +678
+ Partials 1013 547 -466
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=) | `2.43% <0.00%> (-56.10%)` | `0.00 <0.00> (-5.00)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| ... and [353 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...78ea166](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#discussion_r570000506
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/worker/MetricsPersistentWorker.java
##########
@@ -174,21 +175,25 @@ private void flushDataToStorage(List<Metrics> metricsList,
/*
* Merge metrics into cachedMetrics, change only happens inside cachedMetrics.
*/
- cachedMetrics.combine(metrics);
- cachedMetrics.calculate();
- prepareRequests.add(metricsDAO.prepareBatchUpdate(model, cachedMetrics));
- nextWorker(cachedMetrics);
+ isAbandoned = !cachedMetrics.combine(metrics);
+ if (isAbandoned) {
Review comment:
This should make the metrics never updated again, from my reading.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#discussion_r570035737
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/metrics/Metrics.java
##########
@@ -56,8 +56,9 @@
* Merge the given metrics instance, these two must be the same metrics type.
*
* @param metrics to be merged
+ * @return {@code true} if the combined metrics should be continuously processed, {@code false} it should be abandoned.
Review comment:
I don't mean the change you made, I mean for all metrics, if the metrics exist in the cache, even no update, they are keeping being updated periodly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (8bc6701) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **decrease** coverage by `7.31%`.
> The diff coverage is `41.86%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
- Coverage 48.28% 40.96% -7.32%
+ Complexity 3381 2942 -439
============================================
Files 951 946 -5
Lines 23636 23415 -221
Branches 2300 2277 -23
============================================
- Hits 11412 9593 -1819
- Misses 11246 12966 +1720
+ Partials 978 856 -122
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=) | `2.43% <0.00%> (-56.10%)` | `0.00 <0.00> (-5.00)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| ... and [191 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...4704c12](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (33cc185) into [master](https://codecov.io/gh/apache/skywalking/commit/d12d3f201a315241bd7aeb5cc97c2d5103e67c02?el=desc) (d12d3f2) will **increase** coverage by `0.94%`.
> The diff coverage is `47.91%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
+ Coverage 53.22% 54.16% +0.94%
+ Complexity 3845 3733 -112
============================================
Files 1731 946 -785
Lines 36905 23501 -13404
Branches 4076 2284 -1792
============================================
- Hits 19642 12730 -6912
+ Misses 16288 9613 -6675
- Partials 975 1158 +183
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-7.70%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (-56.25%)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-12.20%)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (-58.14%)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (-85.72%)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (-27.28%)` | `10.00 <0.00> (ø)` | |
| ... and [1253 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [d12d3f2...deff976](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (4704c12) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **decrease** coverage by `4.96%`.
> The diff coverage is `44.18%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
- Coverage 48.28% 43.31% -4.97%
+ Complexity 3381 2575 -806
============================================
Files 951 795 -156
Lines 23636 19821 -3815
Branches 2300 1884 -416
============================================
- Hits 11412 8585 -2827
+ Misses 11246 10558 -688
+ Partials 978 678 -300
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=) | `2.43% <0.00%> (-56.10%)` | `0.00 <0.00> (-5.00)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| ... and [325 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...78ea166](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (a42823c) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **increase** coverage by `4.57%`.
> The diff coverage is `46.51%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
+ Coverage 49.57% 54.15% +4.57%
- Complexity 3452 3750 +298
============================================
Files 952 946 -6
Lines 23656 23527 -129
Branches 2315 2299 -16
============================================
+ Hits 11728 12740 +1012
+ Misses 10915 9685 -1230
- Partials 1013 1102 +89
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (ø)` | `10.00 <0.00> (ø)` | |
| ... and [134 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...78ea166](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (d1c74a1) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **increase** coverage by `13.24%`.
> The diff coverage is `47.91%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
=============================================
+ Coverage 34.34% 47.59% +13.24%
- Complexity 2334 2722 +388
=============================================
Files 947 795 -152
Lines 23363 19846 -3517
Branches 2249 1888 -361
=============================================
+ Hits 8025 9446 +1421
+ Misses 14739 9615 -5124
- Partials 599 785 +186
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (ø)` | `10.00 <0.00> (ø)` | |
| ... and [336 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...8dbc02c](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (78ea166) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **increase** coverage by `7.98%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
+ Coverage 49.57% 57.56% +7.98%
+ Complexity 3452 803 -2649
============================================
Files 952 170 -782
Lines 23656 4133 -19523
Branches 2315 477 -1838
============================================
- Hits 11728 2379 -9349
+ Misses 10915 1450 -9465
+ Partials 1013 304 -709
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/ContextCarrier.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0Q2Fycmllci5qYXZh) | `46.29% <0.00%> (-29.63%)` | `8.00% <0.00%> (-2.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `38.46% <0.00%> (-25.65%)` | `6.00% <0.00%> (-4.00%)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `75.00% <0.00%> (-25.00%)` | `2.00% <0.00%> (-1.00%)` | |
| [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `69.56% <0.00%> (-17.40%)` | `7.00% <0.00%> (-1.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `67.60% <0.00%> (-12.68%)` | `11.00% <0.00%> (-4.00%)` | |
| [...ing/apm/agent/core/context/trace/TraceSegment.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9UcmFjZVNlZ21lbnQuamF2YQ==) | `65.00% <0.00%> (-12.50%)` | `8.00% <0.00%> (-2.00%)` | |
| [...pm/agent/core/context/ids/DistributedTraceIds.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvRGlzdHJpYnV0ZWRUcmFjZUlkcy5qYXZh) | `66.66% <0.00%> (-11.12%)` | `3.00% <0.00%> (-1.00%)` | |
| [...m/network/trace/component/command/BaseCommand.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0Jhc2VDb21tYW5kLmphdmE=) | `92.30% <0.00%> (-7.70%)` | `3.00% <0.00%> (-1.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `53.57% <0.00%> (-7.15%)` | `5.00% <0.00%> (-1.00%)` | |
| ... and [758 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...78ea166](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (d1c74a1) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **increase** coverage by `10.80%`.
> The diff coverage is `45.83%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
=============================================
+ Coverage 34.34% 45.15% +10.80%
- Complexity 2334 2581 +247
=============================================
Files 947 795 -152
Lines 23363 19819 -3544
Branches 2249 1872 -377
=============================================
+ Hits 8025 8949 +924
+ Misses 14739 10171 -4568
- Partials 599 699 +100
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (ø)` | `10.00 <0.00> (ø)` | |
| ... and [302 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...8dbc02c](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (d1c74a1) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **increase** coverage by `8.59%`.
> The diff coverage is `43.75%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
+ Coverage 34.34% 42.94% +8.59%
- Complexity 2334 2488 +154
============================================
Files 947 795 -152
Lines 23363 19807 -3556
Branches 2249 1872 -377
============================================
+ Hits 8025 8506 +481
+ Misses 14739 10636 -4103
- Partials 599 665 +66
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=) | `2.43% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| ... and [288 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...8dbc02c](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#discussion_r570009978
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/metrics/Metrics.java
##########
@@ -56,8 +56,9 @@
* Merge the given metrics instance, these two must be the same metrics type.
*
* @param metrics to be merged
+ * @return {@code true} if the combined metrics should be continuously processed, {@code false} it should be abandoned.
Review comment:
```suggestion
* @return {@code true} if the combined metrics should be continuously processed. {@code false} means it should be abandoned, and the implementation needs to keep the data unaltered in this case.
```
I add a little more to the comments, from my code reading, if the change has been made, the data will still flush into the database eventually.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (d1c74a1) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **increase** coverage by `19.21%`.
> The diff coverage is `47.91%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
=============================================
+ Coverage 34.34% 53.56% +19.21%
- Complexity 2334 3676 +1342
=============================================
Files 947 946 -1
Lines 23363 23499 +136
Branches 2249 2295 +46
=============================================
+ Hits 8025 12588 +4563
+ Misses 14739 9772 -4967
- Partials 599 1139 +540
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (ø)` | `10.00 <0.00> (ø)` | |
| ... and [339 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...4704c12](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (8bc6701) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **increase** coverage by `9.71%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
+ Coverage 48.28% 57.99% +9.71%
+ Complexity 3381 809 -2572
============================================
Files 951 171 -780
Lines 23636 4178 -19458
Branches 2300 481 -1819
============================================
- Hits 11412 2423 -8989
+ Misses 11246 1445 -9801
+ Partials 978 310 -668
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `38.46% <0.00%> (-25.65%)` | `6.00% <0.00%> (-4.00%)` | |
| [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `69.56% <0.00%> (-17.40%)` | `7.00% <0.00%> (-1.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `67.60% <0.00%> (-12.68%)` | `11.00% <0.00%> (-4.00%)` | |
| [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `80.00% <0.00%> (-11.43%)` | `8.00% <0.00%> (-1.00%)` | |
| [.../skywalking/apm/agent/core/meter/MeterService.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJTZXJ2aWNlLmphdmE=) | `39.28% <0.00%> (-10.72%)` | `6.00% <0.00%> (-1.00%)` | |
| [.../apm/agent/core/remote/LogReportServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0xvZ1JlcG9ydFNlcnZpY2VDbGllbnQuamF2YQ==) | `40.00% <0.00%> (-10.00%)` | `4.00% <0.00%> (-1.00%)` | |
| [.../agent/core/context/status/StatusCheckService.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvU3RhdHVzQ2hlY2tTZXJ2aWNlLmphdmE=) | `70.00% <0.00%> (-10.00%)` | `5.00% <0.00%> (-1.00%)` | |
| [...m/network/trace/component/command/BaseCommand.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0Jhc2VDb21tYW5kLmphdmE=) | `92.30% <0.00%> (-7.70%)` | `3.00% <0.00%> (-1.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `53.57% <0.00%> (-7.15%)` | `5.00% <0.00%> (-1.00%)` | |
| [...pm/agent/core/commands/CommandExecutorService.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29tbWFuZHMvQ29tbWFuZEV4ZWN1dG9yU2VydmljZS5qYXZh) | `78.57% <0.00%> (-7.15%)` | `6.00% <0.00%> (-1.00%)` | |
| ... and [767 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...4704c12](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (8bc6701) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **decrease** coverage by `7.31%`.
> The diff coverage is `41.86%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
- Coverage 48.28% 40.97% -7.32%
+ Complexity 3381 2890 -491
============================================
Files 951 929 -22
Lines 23636 22921 -715
Branches 2300 2225 -75
============================================
- Hits 11412 9391 -2021
- Misses 11246 12688 +1442
+ Partials 978 842 -136
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=) | `2.43% <0.00%> (-56.10%)` | `0.00 <0.00> (-5.00)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| ... and [207 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...4704c12](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (4704c12) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **decrease** coverage by `0.37%`.
> The diff coverage is `44.18%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
- Coverage 43.67% 43.29% -0.38%
+ Complexity 3085 2572 -513
============================================
Files 950 795 -155
Lines 23450 19821 -3629
Branches 2266 1884 -382
============================================
- Hits 10242 8582 -1660
+ Misses 12332 10558 -1774
+ Partials 876 681 -195
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=) | `2.43% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| ... and [342 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...4704c12](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (a42823c) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **decrease** coverage by `13.24%`.
> The diff coverage is `41.86%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
=============================================
- Coverage 49.57% 36.33% -13.25%
+ Complexity 3452 2107 -1345
=============================================
Files 952 778 -174
Lines 23656 19287 -4369
Branches 2315 1828 -487
=============================================
- Hits 11728 7007 -4721
- Misses 10915 11733 +818
+ Partials 1013 547 -466
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=) | `2.43% <0.00%> (-56.10%)` | `0.00 <0.00> (-5.00)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| ... and [351 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...78ea166](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (a42823c) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **increase** coverage by `2.42%`.
> The diff coverage is `44.18%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
+ Coverage 49.57% 52.00% +2.42%
- Complexity 3452 3602 +150
============================================
Files 952 946 -6
Lines 23656 23509 -147
Branches 2315 2298 -17
============================================
+ Hits 11728 12225 +497
+ Misses 10915 10257 -658
- Partials 1013 1027 +14
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (ø)` | `10.00 <0.00> (ø)` | |
| ... and [99 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...78ea166](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (a42823c) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **decrease** coverage by `6.90%`.
> The diff coverage is `44.18%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
- Coverage 49.57% 42.67% -6.91%
+ Complexity 3452 3017 -435
============================================
Files 952 928 -24
Lines 23656 22900 -756
Branches 2315 2237 -78
============================================
- Hits 11728 9773 -1955
- Misses 10915 12284 +1369
+ Partials 1013 843 -170
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (ø)` | `10.00 <0.00> (ø)` | |
| ... and [210 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...78ea166](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (a42823c) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **increase** coverage by `6.67%`.
> The diff coverage is `46.51%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
+ Coverage 49.57% 56.25% +6.67%
- Complexity 3452 3836 +384
============================================
Files 952 946 -6
Lines 23656 23537 -119
Branches 2315 2300 -15
============================================
+ Hits 11728 13240 +1512
+ Misses 10915 9161 -1754
- Partials 1013 1136 +123
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (ø)` | `10.00 <0.00> (ø)` | |
| ... and [154 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...78ea166](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (78ea166) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **decrease** coverage by `12.53%`.
> The diff coverage is `39.53%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
=============================================
- Coverage 49.57% 37.04% -12.54%
+ Complexity 3452 2637 -815
=============================================
Files 952 927 -25
Lines 23656 22702 -954
Branches 2315 2187 -128
=============================================
- Hits 11728 8409 -3319
- Misses 10915 13545 +2630
+ Partials 1013 748 -265
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=) | `2.43% <0.00%> (-56.10%)` | `0.00 <0.00> (-5.00)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...r/function/avg/AvgHistogramPercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbVBlcmNlbnRpbGVGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (-62.12%)` | `0.00 <0.00> (-25.00)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| ... and [235 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...78ea166](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (deff976) into [master](https://codecov.io/gh/apache/skywalking/commit/d12d3f201a315241bd7aeb5cc97c2d5103e67c02?el=desc) (d12d3f2) will **decrease** coverage by `17.23%`.
> The diff coverage is `37.50%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
=============================================
- Coverage 53.22% 35.98% -17.24%
+ Complexity 3845 2201 -1644
=============================================
Files 1731 794 -937
Lines 36905 19775 -17130
Branches 4076 1868 -2208
=============================================
- Hits 19642 7117 -12525
+ Misses 16288 12101 -4187
+ Partials 975 557 -418
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-7.70%)` | `4.00 <0.00> (ø)` | |
| [...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=) | `2.43% <0.00%> (-56.10%)` | `0.00 <0.00> (-5.00)` | |
| [...on/endpoint/EndpointRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL2VuZHBvaW50L0VuZHBvaW50UmVsYXRpb25TZXJ2ZXJTaWRlTWV0cmljcy5qYXZh) | `1.92% <0.00%> (-73.08%)` | `0.00 <0.00> (-7.00)` | |
| [...ance/ServiceInstanceRelationClientSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL2luc3RhbmNlL1NlcnZpY2VJbnN0YW5jZVJlbGF0aW9uQ2xpZW50U2lkZU1ldHJpY3MuamF2YQ==) | `1.69% <0.00%> (-69.50%)` | `0.00 <0.00> (-7.00)` | |
| [...tion/service/ServiceRelationClientSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL3NlcnZpY2UvU2VydmljZVJlbGF0aW9uQ2xpZW50U2lkZU1ldHJpY3MuamF2YQ==) | `2.12% <0.00%> (-70.22%)` | `0.00 <0.00> (-7.00)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (-56.25%)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-12.20%)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (-58.14%)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-50.00%)` | `0.00 <0.00> (ø)` | |
| ... and [1397 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [d12d3f2...deff976](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (33cc185) into [master](https://codecov.io/gh/apache/skywalking/commit/d12d3f201a315241bd7aeb5cc97c2d5103e67c02?el=desc) (d12d3f2) will **decrease** coverage by `17.27%`.
> The diff coverage is `37.50%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
=============================================
- Coverage 53.22% 35.94% -17.28%
+ Complexity 3845 2551 -1294
=============================================
Files 1731 929 -802
Lines 36905 22735 -14170
Branches 4076 2189 -1887
=============================================
- Hits 19642 8172 -11470
+ Misses 16288 13852 -2436
+ Partials 975 711 -264
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-7.70%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (-56.25%)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-12.20%)` | `0.00 <0.00> (ø)` | |
| [.../core/analysis/meter/function/avg/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0Z1bmN0aW9uLmphdmE=) | `4.10% <0.00%> (-67.52%)` | `2.00 <0.00> (-12.00)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
| [...r/function/avg/AvgHistogramPercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbVBlcmNlbnRpbGVGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (-62.12%)` | `0.00 <0.00> (-25.00)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (-58.14%)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (-85.72%)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/DoubleAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Eb3VibGVBdmdNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00 <0.00> (-4.00)` | |
| ... and [1366 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [d12d3f2...deff976](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (deff976) into [master](https://codecov.io/gh/apache/skywalking/commit/d12d3f201a315241bd7aeb5cc97c2d5103e67c02?el=desc) (d12d3f2) will **decrease** coverage by `4.73%`.
> The diff coverage is `45.83%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
- Coverage 53.22% 48.48% -4.74%
+ Complexity 3845 3442 -403
============================================
Files 1731 946 -785
Lines 36905 23483 -13422
Branches 4076 2280 -1796
============================================
- Hits 19642 11386 -8256
+ Misses 16288 11091 -5197
- Partials 975 1006 +31
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-7.70%)` | `4.00 <0.00> (ø)` | |
| [...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=) | `2.43% <0.00%> (-56.10%)` | `0.00 <0.00> (-5.00)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (-56.25%)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-12.20%)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (-58.14%)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (-85.72%)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00 <0.00> (ø)` | |
| ... and [1285 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [d12d3f2...deff976](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (78ea166) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **decrease** coverage by `10.12%`.
> The diff coverage is `39.53%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
=============================================
- Coverage 49.57% 39.44% -10.13%
+ Complexity 3452 2823 -629
=============================================
Files 952 944 -8
Lines 23656 23205 -451
Branches 2315 2239 -76
=============================================
- Hits 11728 9154 -2574
- Misses 10915 13245 +2330
+ Partials 1013 806 -207
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=) | `2.43% <0.00%> (-56.10%)` | `0.00 <0.00> (-5.00)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...r/function/avg/AvgHistogramPercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbVBlcmNlbnRpbGVGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (-62.12%)` | `0.00 <0.00> (-25.00)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| ... and [197 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...78ea166](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (a42823c) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **decrease** coverage by `12.48%`.
> The diff coverage is `41.86%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
=============================================
- Coverage 49.57% 37.08% -12.49%
+ Complexity 3452 2156 -1296
=============================================
Files 952 778 -174
Lines 23656 19316 -4340
Branches 2315 1835 -480
=============================================
- Hits 11728 7164 -4564
- Misses 10915 11604 +689
+ Partials 1013 548 -465
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=) | `2.43% <0.00%> (-56.10%)` | `0.00 <0.00> (-5.00)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| ... and [359 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...78ea166](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (8dbc02c) into [master](https://codecov.io/gh/apache/skywalking/commit/d12d3f201a315241bd7aeb5cc97c2d5103e67c02?el=desc) (d12d3f2) will **decrease** coverage by `15.40%`.
> The diff coverage is `43.75%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
=============================================
- Coverage 53.22% 37.81% -15.41%
+ Complexity 3845 2198 -1647
=============================================
Files 1731 778 -953
Lines 36905 19316 -17589
Branches 4076 1821 -2255
=============================================
- Hits 19642 7304 -12338
+ Misses 16288 11447 -4841
+ Partials 975 565 -410
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-7.70%)` | `4.00 <0.00> (ø)` | |
| [...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=) | `2.43% <0.00%> (-56.10%)` | `0.00 <0.00> (-5.00)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (-56.25%)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-12.20%)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (-58.14%)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (-85.72%)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00 <0.00> (ø)` | |
| ... and [1393 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...8dbc02c](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (33cc185) into [master](https://codecov.io/gh/apache/skywalking/commit/d12d3f201a315241bd7aeb5cc97c2d5103e67c02?el=desc) (d12d3f2) will **decrease** coverage by `2.08%`.
> The diff coverage is `47.91%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
- Coverage 53.22% 51.13% -2.09%
+ Complexity 3845 3571 -274
============================================
Files 1731 946 -785
Lines 36905 23482 -13423
Branches 4076 2284 -1792
============================================
- Hits 19642 12008 -7634
+ Misses 16288 10389 -5899
- Partials 975 1085 +110
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-7.70%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (-56.25%)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-12.20%)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (-58.14%)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (-85.72%)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (-27.28%)` | `10.00 <0.00> (ø)` | |
| ... and [1267 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [d12d3f2...deff976](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (a42823c) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **increase** coverage by `1.82%`.
> The diff coverage is `44.18%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
+ Coverage 49.57% 51.40% +1.82%
- Complexity 3452 3565 +113
============================================
Files 952 945 -7
Lines 23656 23464 -192
Branches 2315 2294 -21
============================================
+ Hits 11728 12062 +334
+ Misses 10915 10396 -519
+ Partials 1013 1006 -7
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (ø)` | `10.00 <0.00> (ø)` | |
| ... and [110 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...78ea166](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (8bc6701) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **decrease** coverage by `0.47%`.
> The diff coverage is `44.18%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
- Coverage 48.28% 47.80% -0.48%
+ Complexity 3381 3344 -37
============================================
Files 951 946 -5
Lines 23636 23436 -200
Branches 2300 2277 -23
============================================
- Hits 11412 11203 -209
- Misses 11246 11263 +17
+ Partials 978 970 -8
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (ø)` | `10.00 <0.00> (ø)` | |
| ... and [123 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...78ea166](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (8dbc02c) into [master](https://codecov.io/gh/apache/skywalking/commit/d12d3f201a315241bd7aeb5cc97c2d5103e67c02?el=desc) (d12d3f2) will **decrease** coverage by `17.42%`.
> The diff coverage is `43.75%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
=============================================
- Coverage 53.22% 35.79% -17.43%
+ Complexity 3845 2088 -1757
=============================================
Files 1731 778 -953
Lines 36905 19257 -17648
Branches 4076 1813 -2263
=============================================
- Hits 19642 6893 -12749
+ Misses 16288 11832 -4456
+ Partials 975 532 -443
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-7.70%)` | `4.00 <0.00> (ø)` | |
| [...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=) | `2.43% <0.00%> (-56.10%)` | `0.00 <0.00> (-5.00)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (-56.25%)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-12.20%)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (-58.14%)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (-85.72%)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00 <0.00> (ø)` | |
| ... and [1406 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...8dbc02c](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (deff976) into [master](https://codecov.io/gh/apache/skywalking/commit/d12d3f201a315241bd7aeb5cc97c2d5103e67c02?el=desc) (d12d3f2) will **decrease** coverage by `3.78%`.
> The diff coverage is `52.08%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
- Coverage 53.22% 49.44% -3.79%
+ Complexity 3845 3494 -351
============================================
Files 1731 1731
Lines 36905 36903 -2
Branches 4076 4077 +1
============================================
- Hits 19642 18246 -1396
- Misses 16288 17680 +1392
- Partials 975 977 +2
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `66.66% <0.00%> (-17.95%)` | `4.00 <0.00> (ø)` | |
| [...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=) | `2.43% <0.00%> (-56.10%)` | `0.00 <0.00> (-5.00)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `56.25% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `12.19% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `62.79% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `58.13% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `50.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `90.90% <ø> (ø)` | `10.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MinDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Eb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| ... and [136 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [d12d3f2...deff976](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (a42823c) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **decrease** coverage by `13.20%`.
> The diff coverage is `41.86%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
=============================================
- Coverage 49.57% 36.37% -13.21%
+ Complexity 3452 2111 -1341
=============================================
Files 952 778 -174
Lines 23656 19288 -4368
Branches 2315 1830 -485
=============================================
- Hits 11728 7016 -4712
- Misses 10915 11729 +814
+ Partials 1013 543 -470
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=) | `2.43% <0.00%> (-56.10%)` | `0.00 <0.00> (-5.00)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| ... and [346 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...78ea166](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#discussion_r569986384
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/worker/MetricsPersistentWorker.java
##########
@@ -174,21 +175,25 @@ private void flushDataToStorage(List<Metrics> metricsList,
/*
* Merge metrics into cachedMetrics, change only happens inside cachedMetrics.
*/
- cachedMetrics.combine(metrics);
- cachedMetrics.calculate();
- prepareRequests.add(metricsDAO.prepareBatchUpdate(model, cachedMetrics));
- nextWorker(cachedMetrics);
+ isAbandoned = !cachedMetrics.combine(metrics);
+ if (isAbandoned) {
+ cachedMetrics.calculate();
+ prepareRequests.add(metricsDAO.prepareBatchUpdate(model, cachedMetrics));
+ nextWorker(cachedMetrics);
Review comment:
Should be add `else continue` here, rather than adding `if (!isAbandoned) ` at L190?
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/worker/MetricsPersistentWorker.java
##########
@@ -174,21 +175,25 @@ private void flushDataToStorage(List<Metrics> metricsList,
/*
* Merge metrics into cachedMetrics, change only happens inside cachedMetrics.
*/
- cachedMetrics.combine(metrics);
- cachedMetrics.calculate();
- prepareRequests.add(metricsDAO.prepareBatchUpdate(model, cachedMetrics));
- nextWorker(cachedMetrics);
+ isAbandoned = !cachedMetrics.combine(metrics);
+ if (isAbandoned) {
Review comment:
```suggestion
if (!isAbandoned) {
```
Is this reverse?
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/worker/MetricsPersistentWorker.java
##########
@@ -174,21 +175,25 @@ private void flushDataToStorage(List<Metrics> metricsList,
/*
* Merge metrics into cachedMetrics, change only happens inside cachedMetrics.
*/
- cachedMetrics.combine(metrics);
- cachedMetrics.calculate();
- prepareRequests.add(metricsDAO.prepareBatchUpdate(model, cachedMetrics));
- nextWorker(cachedMetrics);
+ isAbandoned = !cachedMetrics.combine(metrics);
+ if (isAbandoned) {
Review comment:
Or should we see `if isBandoned; continue`?
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/worker/MetricsPersistentWorker.java
##########
@@ -174,21 +175,25 @@ private void flushDataToStorage(List<Metrics> metricsList,
/*
* Merge metrics into cachedMetrics, change only happens inside cachedMetrics.
*/
- cachedMetrics.combine(metrics);
- cachedMetrics.calculate();
- prepareRequests.add(metricsDAO.prepareBatchUpdate(model, cachedMetrics));
- nextWorker(cachedMetrics);
+ isAbandoned = !cachedMetrics.combine(metrics);
+ if (isAbandoned) {
Review comment:
This should make the metrics never updated again, from my reading.
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/metrics/Metrics.java
##########
@@ -56,8 +56,9 @@
* Merge the given metrics instance, these two must be the same metrics type.
*
* @param metrics to be merged
+ * @return {@code true} if the combined metrics should be continuously processed, {@code false} it should be abandoned.
Review comment:
```suggestion
* @return {@code true} if the combined metrics should be continuously processed. {@code false} means it should be abandoned, and keep the data unaltered in this case.
```
I add a little more to the comments, from my code reading, if the change has been made, the data will still flush into the database eventually.
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/metrics/Metrics.java
##########
@@ -56,8 +56,9 @@
* Merge the given metrics instance, these two must be the same metrics type.
*
* @param metrics to be merged
+ * @return {@code true} if the combined metrics should be continuously processed, {@code false} it should be abandoned.
Review comment:
```suggestion
* @return {@code true} if the combined metrics should be continuously processed. {@code false} means it should be abandoned, and the implementation needs to keep the data unaltered in this case.
```
I add a little more to the comments, from my code reading, if the change has been made, the data will still flush into the database eventually.
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/metrics/Metrics.java
##########
@@ -56,8 +56,9 @@
* Merge the given metrics instance, these two must be the same metrics type.
*
* @param metrics to be merged
+ * @return {@code true} if the combined metrics should be continuously processed, {@code false} it should be abandoned.
Review comment:
Also, I feel the data in the cache has refreshed repeatedly into database even without change, could you recheck about this too? If so, we need to fix that in another PR, which should be able to reduce the database load.
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/metrics/Metrics.java
##########
@@ -56,8 +56,9 @@
* Merge the given metrics instance, these two must be the same metrics type.
*
* @param metrics to be merged
+ * @return {@code true} if the combined metrics should be continuously processed, {@code false} it should be abandoned.
Review comment:
> Also, I feel the data in the cache has refreshed repeatedly into database even without change, could you recheck about this too? If so, we need to fix that in another PR, which should be able to reduce the database load.
@kezhenxu94 ⬆️ What do you think about this?
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/metrics/Metrics.java
##########
@@ -56,8 +56,9 @@
* Merge the given metrics instance, these two must be the same metrics type.
*
* @param metrics to be merged
+ * @return {@code true} if the combined metrics should be continuously processed, {@code false} it should be abandoned.
Review comment:
I don't mean the change you made, I mean for all metrics, if the metrics exist in the cache, even no update, they are keeping being updated periodly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (a42823c) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **decrease** coverage by `13.21%`.
> The diff coverage is `41.86%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
=============================================
- Coverage 49.57% 36.36% -13.22%
+ Complexity 3452 2110 -1342
=============================================
Files 952 778 -174
Lines 23656 19287 -4369
Branches 2315 1828 -487
=============================================
- Hits 11728 7014 -4714
- Misses 10915 11730 +815
+ Partials 1013 543 -470
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=) | `2.43% <0.00%> (-56.10%)` | `0.00 <0.00> (-5.00)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| ... and [349 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...78ea166](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (deff976) into [master](https://codecov.io/gh/apache/skywalking/commit/d12d3f201a315241bd7aeb5cc97c2d5103e67c02?el=desc) (d12d3f2) will **decrease** coverage by `21.58%`.
> The diff coverage is `25.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
=============================================
- Coverage 53.22% 31.63% -21.59%
+ Complexity 3845 1926 -1919
=============================================
Files 1731 777 -954
Lines 36905 19251 -17654
Branches 4076 1812 -2264
=============================================
- Hits 19642 6090 -13552
+ Misses 16288 12689 -3599
+ Partials 975 472 -503
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-7.70%)` | `4.00 <0.00> (ø)` | |
| [...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=) | `2.43% <0.00%> (-56.10%)` | `0.00 <0.00> (-5.00)` | |
| [...on/endpoint/EndpointRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL2VuZHBvaW50L0VuZHBvaW50UmVsYXRpb25TZXJ2ZXJTaWRlTWV0cmljcy5qYXZh) | `1.92% <0.00%> (-73.08%)` | `0.00 <0.00> (-7.00)` | |
| [...ance/ServiceInstanceRelationClientSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL2luc3RhbmNlL1NlcnZpY2VJbnN0YW5jZVJlbGF0aW9uQ2xpZW50U2lkZU1ldHJpY3MuamF2YQ==) | `1.69% <0.00%> (-69.50%)` | `0.00 <0.00> (-7.00)` | |
| [...ance/ServiceInstanceRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL2luc3RhbmNlL1NlcnZpY2VJbnN0YW5jZVJlbGF0aW9uU2VydmVyU2lkZU1ldHJpY3MuamF2YQ==) | `1.69% <0.00%> (-69.50%)` | `0.00 <0.00> (-7.00)` | |
| [...tion/service/ServiceRelationClientSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL3NlcnZpY2UvU2VydmljZVJlbGF0aW9uQ2xpZW50U2lkZU1ldHJpY3MuamF2YQ==) | `2.12% <0.00%> (-70.22%)` | `0.00 <0.00> (-7.00)` | |
| [...tion/service/ServiceRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL3NlcnZpY2UvU2VydmljZVJlbGF0aW9uU2VydmVyU2lkZU1ldHJpY3MuamF2YQ==) | `2.12% <0.00%> (-70.22%)` | `0.00 <0.00> (-7.00)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (-56.25%)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-12.20%)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
| ... and [1428 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [d12d3f2...deff976](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (a42823c) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **increase** coverage by `0.51%`.
> The diff coverage is `44.18%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
+ Coverage 49.57% 50.09% +0.51%
- Complexity 3452 3479 +27
============================================
Files 952 945 -7
Lines 23656 23464 -192
Branches 2315 2294 -21
============================================
+ Hits 11728 11754 +26
+ Misses 10915 10715 -200
+ Partials 1013 995 -18
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (ø)` | `10.00 <0.00> (ø)` | |
| ... and [112 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...78ea166](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (a42823c) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **decrease** coverage by `2.48%`.
> The diff coverage is `44.18%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
- Coverage 49.57% 47.08% -2.49%
+ Complexity 3452 3258 -194
============================================
Files 952 928 -24
Lines 23656 22970 -686
Branches 2315 2242 -73
============================================
- Hits 11728 10816 -912
- Misses 10915 11230 +315
+ Partials 1013 924 -89
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (ø)` | `10.00 <0.00> (ø)` | |
| ... and [159 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...78ea166](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#discussion_r570001405
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/worker/MetricsPersistentWorker.java
##########
@@ -174,21 +175,25 @@ private void flushDataToStorage(List<Metrics> metricsList,
/*
* Merge metrics into cachedMetrics, change only happens inside cachedMetrics.
*/
- cachedMetrics.combine(metrics);
- cachedMetrics.calculate();
- prepareRequests.add(metricsDAO.prepareBatchUpdate(model, cachedMetrics));
- nextWorker(cachedMetrics);
+ isAbandoned = !cachedMetrics.combine(metrics);
+ if (isAbandoned) {
Review comment:
> Or should we see `if isBandoned; continue`?
🤦🏻♂️ my stupid mistake, fixed
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/metrics/Metrics.java
##########
@@ -56,8 +56,9 @@
* Merge the given metrics instance, these two must be the same metrics type.
*
* @param metrics to be merged
+ * @return {@code true} if the combined metrics should be continuously processed, {@code false} it should be abandoned.
Review comment:
Because only limited `Event` data falls into this case, this may be not a big problem for now. Anyway, let me check and think about how to deal with this
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/metrics/Metrics.java
##########
@@ -56,8 +56,9 @@
* Merge the given metrics instance, these two must be the same metrics type.
*
* @param metrics to be merged
+ * @return {@code true} if the combined metrics should be continuously processed, {@code false} it should be abandoned.
Review comment:
> I don't mean the change you made, I mean for all metrics, if the metrics exist in the cache, even no update, they are keeping being updated periodly.
OK I mistakenly thought you only referred to the "abandoned" metrics, it makes sense to me now, I'll check
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (8bc6701) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **increase** coverage by `0.32%`.
> The diff coverage is `44.18%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
+ Coverage 48.28% 48.60% +0.32%
- Complexity 3381 3399 +18
============================================
Files 951 946 -5
Lines 23636 23436 -200
Branches 2300 2277 -23
============================================
- Hits 11412 11391 -21
+ Misses 11246 11061 -185
- Partials 978 984 +6
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (ø)` | `10.00 <0.00> (ø)` | |
| ... and [131 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...78ea166](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (a42823c) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **increase** coverage by `5.14%`.
> The diff coverage is `46.51%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
+ Coverage 49.57% 54.72% +5.14%
- Complexity 3452 3772 +320
============================================
Files 952 946 -6
Lines 23656 23527 -129
Branches 2315 2299 -16
============================================
+ Hits 11728 12874 +1146
+ Misses 10915 9548 -1367
- Partials 1013 1105 +92
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (ø)` | `10.00 <0.00> (ø)` | |
| ... and [139 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...78ea166](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (8dbc02c) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **increase** coverage by `12.24%`.
> The diff coverage is `45.83%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
=============================================
+ Coverage 34.34% 46.59% +12.24%
- Complexity 2334 3334 +1000
=============================================
Files 947 946 -1
Lines 23363 23460 +97
Branches 2249 2283 +34
=============================================
+ Hits 8025 10931 +2906
+ Misses 14739 11594 -3145
- Partials 599 935 +336
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (ø)` | `10.00 <0.00> (ø)` | |
| ... and [338 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...8dbc02c](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (33cc185) into [master](https://codecov.io/gh/apache/skywalking/commit/d12d3f201a315241bd7aeb5cc97c2d5103e67c02?el=desc) (d12d3f2) will **decrease** coverage by `3.54%`.
> The diff coverage is `45.83%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
- Coverage 53.22% 49.68% -3.55%
+ Complexity 3845 3451 -394
============================================
Files 1731 946 -785
Lines 36905 23464 -13441
Branches 4076 2283 -1793
============================================
- Hits 19642 11657 -7985
+ Misses 16288 10768 -5520
- Partials 975 1039 +64
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-7.70%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (-56.25%)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-12.20%)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (-58.14%)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (-85.72%)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (-27.28%)` | `10.00 <0.00> (ø)` | |
| ... and [1286 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [d12d3f2...deff976](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (a42823c) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **decrease** coverage by `12.30%`.
> The diff coverage is `41.86%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
=============================================
- Coverage 49.57% 37.27% -12.31%
+ Complexity 3452 2172 -1280
=============================================
Files 952 778 -174
Lines 23656 19316 -4340
Branches 2315 1835 -480
=============================================
- Hits 11728 7200 -4528
- Misses 10915 11569 +654
+ Partials 1013 547 -466
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=) | `2.43% <0.00%> (-56.10%)` | `0.00 <0.00> (-5.00)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| ... and [349 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...78ea166](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (d1c74a1) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **increase** coverage by `11.26%`.
> The diff coverage is `45.83%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
=============================================
+ Coverage 34.34% 45.61% +11.26%
- Complexity 2334 2594 +260
=============================================
Files 947 795 -152
Lines 23363 19819 -3544
Branches 2249 1872 -377
=============================================
+ Hits 8025 9040 +1015
+ Misses 14739 10057 -4682
- Partials 599 722 +123
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (ø)` | `10.00 <0.00> (ø)` | |
| ... and [301 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...8dbc02c](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (8dbc02c) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **increase** coverage by `14.13%`.
> The diff coverage is `45.83%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
=============================================
+ Coverage 34.34% 48.48% +14.13%
- Complexity 2334 3415 +1081
=============================================
Files 947 946 -1
Lines 23363 23474 +111
Branches 2249 2284 +35
=============================================
+ Hits 8025 11382 +3357
+ Misses 14739 11128 -3611
- Partials 599 964 +365
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (ø)` | `10.00 <0.00> (ø)` | |
| ... and [346 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...8dbc02c](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (8bc6701) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **increase** coverage by `0.70%`.
> The diff coverage is `44.18%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
+ Coverage 48.28% 48.98% +0.70%
- Complexity 3381 3419 +38
============================================
Files 951 946 -5
Lines 23636 23436 -200
Branches 2300 2277 -23
============================================
+ Hits 11412 11480 +68
+ Misses 11246 10962 -284
- Partials 978 994 +16
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (ø)` | `10.00 <0.00> (ø)` | |
| ... and [133 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...78ea166](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (d1c74a1) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **increase** coverage by `18.41%`.
> The diff coverage is `47.91%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
=============================================
+ Coverage 34.34% 52.76% +18.41%
- Complexity 2334 3644 +1310
=============================================
Files 947 946 -1
Lines 23363 23482 +119
Branches 2249 2294 +45
=============================================
+ Hits 8025 12390 +4365
+ Misses 14739 9963 -4776
- Partials 599 1129 +530
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (ø)` | `10.00 <0.00> (ø)` | |
| ... and [332 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...8dbc02c](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#discussion_r569986384
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/worker/MetricsPersistentWorker.java
##########
@@ -174,21 +175,25 @@ private void flushDataToStorage(List<Metrics> metricsList,
/*
* Merge metrics into cachedMetrics, change only happens inside cachedMetrics.
*/
- cachedMetrics.combine(metrics);
- cachedMetrics.calculate();
- prepareRequests.add(metricsDAO.prepareBatchUpdate(model, cachedMetrics));
- nextWorker(cachedMetrics);
+ isAbandoned = !cachedMetrics.combine(metrics);
+ if (isAbandoned) {
+ cachedMetrics.calculate();
+ prepareRequests.add(metricsDAO.prepareBatchUpdate(model, cachedMetrics));
+ nextWorker(cachedMetrics);
Review comment:
Should be add `else continue` here, rather than adding `if (!isAbandoned) ` at L190?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (d1c74a1) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **increase** coverage by `16.45%`.
> The diff coverage is `47.91%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
=============================================
+ Coverage 34.34% 50.80% +16.45%
- Complexity 2334 3542 +1208
=============================================
Files 947 946 -1
Lines 23363 23463 +100
Branches 2249 2294 +45
=============================================
+ Hits 8025 11921 +3896
+ Misses 14739 10451 -4288
- Partials 599 1091 +492
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (ø)` | `10.00 <0.00> (ø)` | |
| ... and [350 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...8dbc02c](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (deff976) into [master](https://codecov.io/gh/apache/skywalking/commit/d12d3f201a315241bd7aeb5cc97c2d5103e67c02?el=desc) (d12d3f2) will **decrease** coverage by `10.82%`.
> The diff coverage is `37.50%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
=============================================
- Coverage 53.22% 42.39% -10.83%
+ Complexity 3845 3114 -731
=============================================
Files 1731 945 -786
Lines 36905 23392 -13513
Branches 4076 2274 -1802
=============================================
- Hits 19642 9917 -9725
+ Misses 16288 12588 -3700
+ Partials 975 887 -88
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-7.70%)` | `4.00 <0.00> (ø)` | |
| [...lysis/manual/networkalias/NetworkAddressAlias.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzLmphdmE=) | `2.43% <0.00%> (-56.10%)` | `0.00 <0.00> (-5.00)` | |
| [...on/endpoint/EndpointRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL2VuZHBvaW50L0VuZHBvaW50UmVsYXRpb25TZXJ2ZXJTaWRlTWV0cmljcy5qYXZh) | `1.92% <0.00%> (-73.08%)` | `0.00 <0.00> (-7.00)` | |
| [...ance/ServiceInstanceRelationClientSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL2luc3RhbmNlL1NlcnZpY2VJbnN0YW5jZVJlbGF0aW9uQ2xpZW50U2lkZU1ldHJpY3MuamF2YQ==) | `1.69% <0.00%> (-69.50%)` | `0.00 <0.00> (-7.00)` | |
| [...tion/service/ServiceRelationClientSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL3NlcnZpY2UvU2VydmljZVJlbGF0aW9uQ2xpZW50U2lkZU1ldHJpY3MuamF2YQ==) | `2.12% <0.00%> (-70.22%)` | `0.00 <0.00> (-7.00)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (-56.25%)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-12.20%)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (-58.14%)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-50.00%)` | `0.00 <0.00> (ø)` | |
| ... and [1323 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [d12d3f2...deff976](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (33cc185) into [master](https://codecov.io/gh/apache/skywalking/commit/d12d3f201a315241bd7aeb5cc97c2d5103e67c02?el=desc) (d12d3f2) will **decrease** coverage by `1.98%`.
> The diff coverage is `47.91%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
- Coverage 53.22% 51.23% -1.99%
+ Complexity 3845 3575 -270
============================================
Files 1731 946 -785
Lines 36905 23482 -13423
Branches 4076 2284 -1792
============================================
- Hits 19642 12032 -7610
+ Misses 16288 10359 -5929
- Partials 975 1091 +116
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-7.70%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (-56.25%)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-12.20%)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (-58.14%)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (-85.72%)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (-27.28%)` | `10.00 <0.00> (ø)` | |
| ... and [1266 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [d12d3f2...deff976](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (33cc185) into [master](https://codecov.io/gh/apache/skywalking/commit/d12d3f201a315241bd7aeb5cc97c2d5103e67c02?el=desc) (d12d3f2) will **decrease** coverage by `0.96%`.
> The diff coverage is `47.91%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
- Coverage 53.22% 52.25% -0.97%
+ Complexity 3845 3636 -209
============================================
Files 1731 946 -785
Lines 36905 23482 -13423
Branches 4076 2284 -1792
============================================
- Hits 19642 12271 -7371
+ Misses 16288 10091 -6197
- Partials 975 1120 +145
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-7.70%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (-56.25%)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-12.20%)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (-58.14%)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (-85.72%)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (-27.28%)` | `10.00 <0.00> (ø)` | |
| ... and [1261 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [d12d3f2...deff976](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] commented on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (33cc185) into [master](https://codecov.io/gh/apache/skywalking/commit/d12d3f201a315241bd7aeb5cc97c2d5103e67c02?el=desc) (d12d3f2) will **decrease** coverage by `22.58%`.
> The diff coverage is `37.50%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
=============================================
- Coverage 53.22% 30.63% -22.59%
+ Complexity 3845 1775 -2070
=============================================
Files 1731 778 -953
Lines 36905 19118 -17787
Branches 4076 1783 -2293
=============================================
- Hits 19642 5857 -13785
+ Misses 16288 12838 -3450
+ Partials 975 423 -552
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-7.70%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (-56.25%)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-12.20%)` | `0.00 <0.00> (ø)` | |
| [.../core/analysis/meter/function/avg/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0Z1bmN0aW9uLmphdmE=) | `4.10% <0.00%> (-67.52%)` | `2.00 <0.00> (-12.00)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
| [...r/function/avg/AvgHistogramPercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbVBlcmNlbnRpbGVGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (-62.12%)` | `0.00 <0.00> (-25.00)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (-58.14%)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (-85.72%)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/DoubleAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Eb3VibGVBdmdNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00 <0.00> (-4.00)` | |
| ... and [1432 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [d12d3f2...deff976](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (a42823c) into [master](https://codecov.io/gh/apache/skywalking/commit/f44ed756df07b45ddc34201d5e569a4b8864772d?el=desc) (f44ed75) will **increase** coverage by `5.16%`.
> The diff coverage is `46.51%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
+ Coverage 49.57% 54.74% +5.16%
- Complexity 3452 3773 +321
============================================
Files 952 946 -6
Lines 23656 23527 -129
Branches 2315 2299 -16
============================================
+ Hits 11728 12880 +1152
+ Misses 10915 9542 -1373
- Partials 1013 1105 +92
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-23.08%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (ø)` | `10.00 <0.00> (ø)` | |
| ... and [140 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [f44ed75...78ea166](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6318: Metrics combination API supports abandoning results
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6318:
URL: https://github.com/apache/skywalking/pull/6318#issuecomment-773033914
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=h1) Report
> Merging [#6318](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=desc) (33cc185) into [master](https://codecov.io/gh/apache/skywalking/commit/d12d3f201a315241bd7aeb5cc97c2d5103e67c02?el=desc) (d12d3f2) will **decrease** coverage by `1.78%`.
> The diff coverage is `47.91%`.
[](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6318 +/- ##
============================================
- Coverage 53.22% 51.43% -1.79%
+ Complexity 3845 3581 -264
============================================
Files 1731 946 -785
Lines 36905 23482 -13423
Branches 4076 2284 -1792
============================================
- Hits 19642 12078 -7564
+ Misses 16288 10296 -5992
- Partials 975 1108 +133
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...erver/core/analysis/data/MergableBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9NZXJnYWJsZUJ1ZmZlcmVkRGF0YS5qYXZh) | `76.92% <0.00%> (-7.70%)` | `4.00 <0.00> (ø)` | |
| [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (-56.25%)` | `0.00 <0.00> (ø)` | |
| [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-12.20%)` | `0.00 <0.00> (ø)` | |
| [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-62.80%)` | `0.00 <0.00> (ø)` | |
| [...nalysis/meter/function/avg/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0xhYmVsZWRGdW5jdGlvbi5qYXZh) | `0.00% <0.00%> (-58.14%)` | `0.00 <0.00> (ø)` | |
| [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...oap/server/core/analysis/metrics/CountMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Db3VudE1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (-85.72%)` | `0.00 <0.00> (ø)` | |
| [...server/core/analysis/metrics/MaxDoubleMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhEb3VibGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...p/server/core/analysis/metrics/MaxLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NYXhMb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00 <0.00> (ø)` | |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `63.63% <ø> (-27.28%)` | `10.00 <0.00> (ø)` | |
| ... and [1266 more](https://codecov.io/gh/apache/skywalking/pull/6318/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=footer). Last update [d12d3f2...deff976](https://codecov.io/gh/apache/skywalking/pull/6318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org