You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by danny0405 <gi...@git.apache.org> on 2018/04/20 13:48:59 UTC
[GitHub] storm pull request #2640: [STORM-3036] Add isRemoteBlobExists RPC interface ...
GitHub user danny0405 opened a pull request:
https://github.com/apache/storm/pull/2640
[STORM-3036] Add isRemoteBlobExists RPC interface for deciding if rem…
As https://github.com/apache/storm/pull/2618 has described, now we try catch a KeyNotFoundException to decide remote blob does not exist.
It is confusing because user had removed it/them on their own initiative but we still got a KeyNotFoundException at both server and client point.
So i add a new api for this case.
This is the JIRA: [STORM-3036](https://issues.apache.org/jira/browse/STORM-3036)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/danny0405/storm add-blob-api
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2640.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2640
----
commit 74c026b557c83aad93bb9d93316833147979af30
Author: chenyuzhao <ch...@...>
Date: 2018-04-20T13:46:39Z
[STORM-3036] Add isRemoteBlobExists RPC interface for deciding if remote blob exists
----
---
[GitHub] storm issue #2640: [STORM-3036] Add isRemoteBlobExists RPC interface for dec...
Posted by danny0405 <gi...@git.apache.org>.
Github user danny0405 commented on the issue:
https://github.com/apache/storm/pull/2640
@revans2
I have fixed the conflicts and rebase, thx for your review work.
---
[GitHub] storm issue #2640: [STORM-3036] Add isRemoteBlobExists RPC interface for dec...
Posted by danny0405 <gi...@git.apache.org>.
Github user danny0405 commented on the issue:
https://github.com/apache/storm/pull/2640
@revans2
Can you help me to reivew this patch?
---
[GitHub] storm issue #2640: [STORM-3036] Add isRemoteBlobExists RPC interface for dec...
Posted by danny0405 <gi...@git.apache.org>.
Github user danny0405 commented on the issue:
https://github.com/apache/storm/pull/2640
@revans2
Hi, Bobby, kindly reminder.
---
[GitHub] storm pull request #2640: [STORM-3036] Add isRemoteBlobExists RPC interface ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2640
---