You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/09/02 20:48:12 UTC

[GitHub] [netbeans] mbien opened a new pull request, #4580: revert rushed unbalanced-hint fix (#4421).

mbien opened a new pull request, #4580:
URL: https://github.com/apache/netbeans/pull/4580

    - fix for #4402 caused #4545
    - partial revert of #4421, tests are commented out, update to READ_METHODS Set is kept
   
   @neilcsmith-net would you prefer the full PR reverted or just the actual "fix" and leave the rest as in this draft here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] neilcsmith-net commented on pull request #4580: revert rushed unbalanced-hint fix (#4421).

Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on PR #4580:
URL: https://github.com/apache/netbeans/pull/4580#issuecomment-1274505470

   Your call, but probably keep the other aspects.  Slightly hard to see what's kept - with a more complex PR could have two commits - full revert than partial re-apply to make it more obvious - but probably not worth the effort here.
   
   Sorry for delayed follow up - I think my current memory capacity is barely 2 days!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] neilcsmith-net commented on pull request #4580: revert rushed unbalanced-hint fix (#4421).

Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on PR #4580:
URL: https://github.com/apache/netbeans/pull/4580#issuecomment-1274464000

   @mbien I've forgotten where we're at with this one?  I just noticed the incorrect hint again in NB15 while working on update check.  Still need fixing for NB16?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] neilcsmith-net merged pull request #4580: revert rushed unbalanced-hint fix (#4421).

Posted by GitBox <gi...@apache.org>.
neilcsmith-net merged PR #4580:
URL: https://github.com/apache/netbeans/pull/4580


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] mbien commented on pull request #4580: revert rushed unbalanced-hint fix (#4421).

Posted by GitBox <gi...@apache.org>.
mbien commented on PR #4580:
URL: https://github.com/apache/netbeans/pull/4580#issuecomment-1274471660

   > @mbien I've forgotten where we're at with this one? I just noticed the incorrect hint again in NB15 while working on update check. Still need fixing for NB16?
   
   @neilcsmith-net yes this should be reverted since my "[hotfix](https://github.com/apache/netbeans/pull/4421/files)" made the situation worse unfortunately. Since the patch also added tests and a little bit of an update to the ARRAY_WRITE, READ_METHODS and WRITE_METHODS, I was wondering if we can do a partial revert like proposed here.
   
   Completely ok with a full revert too of course - I was only asking for feedback.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists