You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "yiguolei (via GitHub)" <gi...@apache.org> on 2024/01/08 11:29:56 UTC
[PR] [refactor](tabletwriter) make tablet writer's rpc callback safe, could exit any time [doris]
yiguolei opened a new pull request, #29684:
URL: https://github.com/apache/doris/pull/29684
## Proposed changes
Issue Number: close #xxx
<!--Describe your changes.-->
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](tabletwriter) make tablet writer's rpc callback safe, could exit any time [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #29684:
URL: https://github.com/apache/doris/pull/29684
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](tabletwriter) make tablet writer's rpc callback safe, could exit any time [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29684:
URL: https://github.com/apache/doris/pull/29684#issuecomment-1882674715
<details>
<summary>ClickBench: <b>Total hot run time: 31.87 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 86b862f7388b48d811b4898e9f7798fa1789583d, data reload: false
query1 0.07 0.11 0.07
query2 0.07 0.03 0.03
query3 0.33 0.23 0.23
query4 1.74 0.19 0.19
query5 0.52 0.51 0.53
query6 1.56 0.69 0.68
query7 0.03 0.01 0.01
query8 0.04 0.03 0.03
query9 0.61 0.57 0.57
query10 0.60 0.61 0.61
query11 0.17 0.13 0.12
query12 0.14 0.12 0.11
query13 0.60 0.60 0.59
query14 0.77 0.76 0.80
query15 0.81 0.79 0.78
query16 0.33 0.35 0.34
query17 0.98 0.96 0.95
query18 0.26 0.24 0.25
query19 1.87 1.77 1.73
query20 0.02 0.01 0.01
query21 15.40 0.54 0.54
query22 2.63 3.70 1.34
query23 17.63 0.92 0.99
query24 10.22 1.16 0.83
query25 2.45 0.17 0.17
query26 0.16 0.16 0.18
query27 0.17 0.18 0.17
query28 4.96 0.96 0.89
query29 12.96 3.63 3.40
query30 0.53 0.54 0.52
query31 2.92 0.37 0.37
query32 3.27 0.50 0.48
query33 3.21 3.21 3.18
query34 17.08 4.56 4.52
query35 4.56 4.54 4.49
query36 1.15 1.08 1.08
query37 0.07 0.04 0.05
query38 0.04 0.02 0.02
query39 0.02 0.02 0.02
query40 0.15 0.14 0.13
query41 0.07 0.01 0.02
query42 0.02 0.02 0.01
query43 0.02 0.02 0.02
Total cold run time: 111.21 s
Total hot run time: 31.87 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](tabletwriter) make tablet writer's rpc callback safe, could exit any time [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29684:
URL: https://github.com/apache/doris/pull/29684#issuecomment-1882583709
<details>
<summary>TPC-H: <b>Total hot run time: 38672 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a272b4be7e9754cbd8a0ebaf06b71e52a4eff644, data reload: false
------ Round 1 ----------------------------------
q1 17655 4931 4935 4931
q2 2027 157 144 144
q3 10680 1212 1120 1120
q4 10555 732 739 732
q5 7776 3037 2921 2921
q6 210 122 123 122
q7 938 526 489 489
q8 9326 2042 2018 2018
q9 6565 6493 6422 6422
q10 8265 3028 3010 3010
q11 440 216 208 208
q12 387 226 234 226
q13 18030 3436 3380 3380
q14 238 210 207 207
q15 546 513 500 500
q16 445 390 387 387
q17 972 731 597 597
q18 7424 6783 6710 6710
q19 1583 1531 1545 1531
q20 726 320 296 296
q21 2771 2435 2411 2411
q22 368 310 324 310
Total cold run time: 107927 ms
Total hot run time: 38672 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4908 4918 4922 4918
q2 340 231 234 231
q3 3296 3344 3247 3247
q4 2109 2044 2024 2024
q5 5869 5815 5809 5809
q6 209 115 114 114
q7 2341 1957 1949 1949
q8 3421 3463 3477 3463
q9 8884 8766 8753 8753
q10 3819 3883 3839 3839
q11 556 447 443 443
q12 803 657 658 657
q13 3911 3172 3204 3172
q14 297 265 256 256
q15 548 507 497 497
q16 544 466 503 466
q17 1860 1861 1856 1856
q18 8633 8328 8265 8265
q19 1596 1837 1633 1633
q20 2207 1988 1961 1961
q21 5644 5301 5343 5301
q22 508 448 440 440
Total cold run time: 62303 ms
Total hot run time: 59294 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](tabletwriter) make tablet writer's rpc callback safe, could exit any time [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29684:
URL: https://github.com/apache/doris/pull/29684#issuecomment-1882666831
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.21 seconds
stream load tsv: 564 seconds loaded 74807831229 Bytes, about 126 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 27.5 seconds inserted 10000000 Rows, about 363K ops/s
storage size: 17183678816 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](tabletwriter) make tablet writer's rpc callback safe, could exit any time [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29684:
URL: https://github.com/apache/doris/pull/29684#issuecomment-1882831923
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](tabletwriter) make tablet writer's rpc callback safe, could exit any time [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on PR #29684:
URL: https://github.com/apache/doris/pull/29684#issuecomment-1882598334
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](tabletwriter) make tablet writer's rpc callback safe, could exit any time [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29684:
URL: https://github.com/apache/doris/pull/29684#issuecomment-1882646428
<details>
<summary>TPC-H: <b>Total hot run time: 39178 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 86b862f7388b48d811b4898e9f7798fa1789583d, data reload: false
------ Round 1 ----------------------------------
q1 18344 5538 5518 5518
q2 2020 156 144 144
q3 10699 1087 1153 1087
q4 10362 797 851 797
q5 7830 2967 2877 2877
q6 205 127 135 127
q7 899 510 502 502
q8 9297 1979 1997 1979
q9 6532 6415 6390 6390
q10 8252 3018 2953 2953
q11 443 222 211 211
q12 386 235 241 235
q13 18263 3478 3416 3416
q14 247 215 208 208
q15 548 516 510 510
q16 484 427 393 393
q17 934 740 684 684
q18 7234 6683 6628 6628
q19 1563 1508 1526 1508
q20 751 333 314 314
q21 2757 2414 2377 2377
q22 375 320 346 320
Total cold run time: 108425 ms
Total hot run time: 39178 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5727 5540 5504 5504
q2 356 259 243 243
q3 3353 3259 3300 3259
q4 2120 2034 2061 2034
q5 5854 5800 5810 5800
q6 205 123 126 123
q7 2303 1905 1872 1872
q8 3375 3509 3539 3509
q9 8887 8790 8875 8790
q10 3804 3837 3865 3837
q11 595 483 496 483
q12 811 664 650 650
q13 5803 3257 3229 3229
q14 306 271 271 271
q15 547 517 500 500
q16 528 487 496 487
q17 2393 2360 2354 2354
q18 8621 8515 8468 8468
q19 1574 1610 1608 1608
q20 2210 1965 1950 1950
q21 5603 5398 5394 5394
q22 588 523 504 504
Total cold run time: 65563 ms
Total hot run time: 60869 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](tabletwriter) make tablet writer's rpc callback safe, could exit any time [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29684:
URL: https://github.com/apache/doris/pull/29684#issuecomment-1882680058
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit 86b862f7388b48d811b4898e9f7798fa1789583d with default session variables
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 58 seconds loaded 1101869774 Bytes, about 18 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 17.9 seconds inserted 10000000 Rows, about 558K ops/s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](tabletwriter) make tablet writer's rpc callback safe, could exit any time [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29684:
URL: https://github.com/apache/doris/pull/29684#issuecomment-1880836755
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](tabletwriter) make tablet writer's rpc callback safe, could exit any time [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29684:
URL: https://github.com/apache/doris/pull/29684#issuecomment-1882377419
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.4 seconds
stream load tsv: 580 seconds loaded 74807831229 Bytes, about 123 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.0 seconds inserted 10000000 Rows, about 357K ops/s
storage size: 17183973953 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](tabletwriter) make tablet writer's rpc callback safe, could exit any time [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29684:
URL: https://github.com/apache/doris/pull/29684#issuecomment-1882598054
<details>
<summary>TPC-DS: <b>Total hot run time: 184394 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit a272b4be7e9754cbd8a0ebaf06b71e52a4eff644, data reload: false
run tpcds-sf100 query with default conf and session variables
query1 950 344 343 343
query2 6519 2020 2015 2015
query3 6723 232 220 220
query4 25877 22564 22500 22500
query5 5557 642 596 596
query6 327 209 213 209
query7 4645 316 292 292
query8 255 230 229 229
query9 8791 2936 2887 2887
query10 587 331 319 319
query11 16216 15544 15734 15544
query12 182 101 102 101
query13 1688 335 348 335
query14 12206 7646 7573 7573
query15 253 229 228 228
query16 6268 353 341 341
query17 1610 526 510 510
query18 1920 312 310 310
query19 237 165 165 165
query20 109 104 105 104
query21 192 96 99 96
query22 4890 4614 4602 4602
query23 32046 31794 31592 31592
query24 12466 3026 2957 2957
query25 506 360 376 360
query26 1253 172 175 172
query27 3067 312 312 312
query28 6928 2162 2129 2129
query29 1097 402 415 402
query30 291 147 150 147
query31 1030 835 816 816
query32 120 76 74 74
query33 779 352 327 327
query34 852 484 467 467
query35 1002 896 912 896
query36 1352 1192 1212 1192
query37 210 90 83 83
query38 3485 3369 3357 3357
query39 1373 1320 1305 1305
query40 300 93 91 91
query41 39 37 40 37
query42 110 113 107 107
query43 543 546 515 515
query44 1208 803 818 803
query45 216 199 204 199
query46 1058 702 726 702
query47 1776 1646 1665 1646
query48 401 312 274 274
query49 1057 320 315 315
query50 790 327 364 327
query51 5432 5337 5287 5287
query52 135 94 97 94
query53 241 168 167 167
query54 1362 667 669 667
query55 115 96 99 96
query56 260 250 241 241
query57 1065 1040 984 984
query58 316 290 281 281
query59 3179 2857 2937 2857
query60 319 297 291 291
query61 156 132 152 132
query62 593 491 497 491
query63 192 186 173 173
query64 4857 1760 1702 1702
query65 3457 3362 3347 3347
query66 1144 416 398 398
query67 15636 15290 15266 15266
query68 12560 558 536 536
query69 611 326 310 310
query70 1725 1521 1529 1521
query71 653 297 297 297
query72 5811 3497 3484 3484
query73 2620 349 336 336
query74 7011 6491 6519 6491
query75 5870 2340 2331 2331
query76 6662 1084 1161 1084
query77 768 331 365 331
query78 9081 8691 8546 8546
query79 1078 527 531 527
query80 533 355 348 348
query81 463 212 211 211
query82 231 118 108 108
query83 195 140 139 139
query84 254 58 57 57
query85 949 279 273 273
query86 419 391 437 391
query87 3682 3510 3405 3405
query88 3120 2523 2532 2523
query89 362 293 286 286
query90 1823 265 258 258
query91 122 95 95 95
query92 100 83 77 77
query93 1024 435 481 435
query94 883 256 234 234
query95 587 522 500 500
query96 647 350 335 335
query97 4345 4310 4233 4233
query98 253 224 230 224
query99 1146 871 914 871
Total cold run time: 295404 ms
Total hot run time: 184394 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](tabletwriter) make tablet writer's rpc callback safe, could exit any time [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29684:
URL: https://github.com/apache/doris/pull/29684#issuecomment-1882821194
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](tabletwriter) make tablet writer's rpc callback safe, could exit any time [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on PR #29684:
URL: https://github.com/apache/doris/pull/29684#issuecomment-1882313309
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](tabletwriter) make tablet writer's rpc callback safe, could exit any time [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29684:
URL: https://github.com/apache/doris/pull/29684#issuecomment-1882377228
<details>
<summary>TPC-DS: <b>Total hot run time: 184235 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 5715c11d469aee56053e2d93dbb81ba75bb9e54a, data reload: false
run tpcds-sf100 query with default conf and session variables
query1 948 345 329 329
query2 6562 2034 1985 1985
query3 6737 233 226 226
query4 28047 22498 22514 22498
query5 5993 633 588 588
query6 335 196 204 196
query7 4622 312 289 289
query8 258 225 226 225
query9 8680 2914 2949 2914
query10 542 346 335 335
query11 16407 15613 15744 15613
query12 181 95 93 93
query13 1675 347 331 331
query14 12995 7546 7601 7546
query15 289 233 209 209
query16 6329 344 332 332
query17 1711 513 525 513
query18 1972 317 300 300
query19 232 159 168 159
query20 107 108 106 106
query21 187 95 95 95
query22 5022 4765 4895 4765
query23 32429 30940 31450 30940
query24 11997 3006 2905 2905
query25 611 360 358 358
query26 1802 175 175 175
query27 2807 305 314 305
query28 7274 2117 2107 2107
query29 2062 423 411 411
query30 294 143 147 143
query31 1009 836 814 814
query32 140 91 86 86
query33 857 339 345 339
query34 835 476 461 461
query35 993 886 905 886
query36 1379 1241 1265 1241
query37 211 82 83 82
query38 3459 3299 3348 3299
query39 1351 1291 1292 1291
query40 307 92 88 88
query41 41 36 36 36
query42 114 107 124 107
query43 550 489 533 489
query44 1169 799 819 799
query45 213 200 207 200
query46 1084 694 691 691
query47 1750 1694 1661 1661
query48 363 279 287 279
query49 1209 315 321 315
query50 800 326 369 326
query51 5397 5307 5336 5307
query52 120 94 99 94
query53 233 163 164 163
query54 1496 677 709 677
query55 108 104 109 104
query56 260 262 263 262
query57 1061 1027 1049 1027
query58 301 294 289 289
query59 3080 2773 2776 2773
query60 357 294 321 294
query61 155 146 148 146
query62 557 516 488 488
query63 192 196 180 180
query64 5904 1722 1723 1722
query65 3436 3361 3324 3324
query66 1340 373 374 373
query67 15516 15602 15765 15602
query68 12654 569 549 549
query69 574 334 320 320
query70 1735 1572 1599 1572
query71 580 308 297 297
query72 5273 3417 3454 3417
query73 2497 349 335 335
query74 7028 6548 6482 6482
query75 4926 2317 2271 2271
query76 6277 1216 1208 1208
query77 769 315 311 311
query78 9100 8734 8627 8627
query79 1034 535 546 535
query80 536 342 351 342
query81 465 214 219 214
query82 233 113 109 109
query83 167 148 140 140
query84 246 58 58 58
query85 917 294 268 268
query86 443 431 433 431
query87 3566 3520 3447 3447
query88 3052 2504 2494 2494
query89 356 285 290 285
query90 1880 260 257 257
query91 120 92 97 92
query92 78 86 72 72
query93 1147 473 481 473
query94 851 244 253 244
query95 600 519 504 504
query96 640 349 344 344
query97 4351 4217 4182 4182
query98 243 220 227 220
query99 1155 829 841 829
Total cold run time: 299947 ms
Total hot run time: 184235 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](tabletwriter) make tablet writer's rpc callback safe, could exit any time [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29684:
URL: https://github.com/apache/doris/pull/29684#issuecomment-1882608095
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](tabletwriter) make tablet writer's rpc callback safe, could exit any time [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29684:
URL: https://github.com/apache/doris/pull/29684#issuecomment-1882665199
<details>
<summary>TPC-DS: <b>Total hot run time: 185543 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 86b862f7388b48d811b4898e9f7798fa1789583d, data reload: false
run tpcds-sf100 query with default conf and session variables
query1 935 341 332 332
query2 6840 2002 1909 1909
query3 6723 239 223 223
query4 26198 22524 22473 22473
query5 4608 623 602 602
query6 325 205 218 205
query7 4660 314 313 313
query8 249 225 232 225
query9 9680 3228 3255 3228
query10 508 317 329 317
query11 16096 15684 15625 15625
query12 183 120 117 117
query13 1672 336 331 331
query14 13359 7474 7606 7474
query15 290 256 235 235
query16 6580 354 352 352
query17 1693 528 530 528
query18 2007 326 302 302
query19 271 176 171 171
query20 125 114 117 114
query21 191 102 100 100
query22 4969 4652 4707 4652
query23 32416 31349 31381 31349
query24 11238 2970 3006 2970
query25 615 376 375 375
query26 1547 178 177 177
query27 2801 311 314 311
query28 7042 2124 2119 2119
query29 1355 418 407 407
query30 287 149 149 149
query31 1056 851 855 851
query32 140 102 94 94
query33 814 359 340 340
query34 934 481 477 477
query35 971 893 884 884
query36 1462 1368 1232 1232
query37 136 114 118 114
query38 3518 3365 3421 3365
query39 1361 1311 1331 1311
query40 192 95 90 90
query41 40 36 36 36
query42 123 109 117 109
query43 603 573 563 563
query44 1247 831 811 811
query45 228 203 206 203
query46 1051 732 685 685
query47 1753 1747 1736 1736
query48 398 274 288 274
query49 1108 334 320 320
query50 726 313 322 313
query51 5492 5309 5300 5300
query52 128 111 115 111
query53 244 172 177 172
query54 1539 721 696 696
query55 117 109 101 101
query56 308 298 281 281
query57 1076 1008 1053 1008
query58 344 320 340 320
query59 3312 3087 3091 3087
query60 374 325 297 297
query61 133 156 158 156
query62 583 499 504 499
query63 209 203 207 203
query64 5108 1720 1735 1720
query65 3461 3374 3361 3361
query66 1275 463 451 451
query67 15979 15082 15585 15082
query68 13048 545 538 538
query69 617 372 328 328
query70 1909 1781 1749 1749
query71 636 271 302 271
query72 5416 3484 3451 3451
query73 3208 341 334 334
query74 7104 6553 6576 6553
query75 5475 2277 2306 2277
query76 6410 1088 1162 1088
query77 756 341 367 341
query78 9097 8666 8649 8649
query79 3461 524 542 524
query80 704 348 362 348
query81 489 221 220 220
query82 237 123 119 119
query83 198 147 145 145
query84 259 60 58 58
query85 969 273 274 273
query86 441 463 467 463
query87 3703 3457 3456 3456
query88 3330 2509 2520 2509
query89 389 327 290 290
query90 2125 267 264 264
query91 117 94 96 94
query92 103 99 92 92
query93 1952 428 415 415
query94 998 260 255 255
query95 574 523 509 509
query96 631 340 348 340
query97 4485 4215 4197 4197
query98 248 227 227 227
query99 1162 883 828 828
Total cold run time: 303257 ms
Total hot run time: 185543 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](tabletwriter) make tablet writer's rpc callback safe, could exit any time [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29684:
URL: https://github.com/apache/doris/pull/29684#issuecomment-1882532237
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](tabletwriter) make tablet writer's rpc callback safe, could exit any time [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on PR #29684:
URL: https://github.com/apache/doris/pull/29684#issuecomment-1882537174
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](tabletwriter) make tablet writer's rpc callback safe, could exit any time [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29684:
URL: https://github.com/apache/doris/pull/29684#issuecomment-1882370101
<details>
<summary>TPC-H: <b>Total hot run time: 38351 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 5715c11d469aee56053e2d93dbb81ba75bb9e54a, data reload: false
------ Round 1 ----------------------------------
q1 17685 4917 4954 4917
q2 2027 152 146 146
q3 10611 1172 1122 1122
q4 10443 789 810 789
q5 7783 2914 2843 2843
q6 222 123 122 122
q7 920 518 500 500
q8 9250 1981 1956 1956
q9 6443 6363 6353 6353
q10 8236 3070 3039 3039
q11 425 231 213 213
q12 386 231 234 231
q13 18008 3414 3358 3358
q14 236 209 201 201
q15 552 509 497 497
q16 444 432 392 392
q17 948 718 597 597
q18 7288 6632 6656 6632
q19 1550 1506 1499 1499
q20 709 319 303 303
q21 2769 2440 2338 2338
q22 355 303 318 303
Total cold run time: 107290 ms
Total hot run time: 38351 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4886 4888 4863 4863
q2 335 232 246 232
q3 3255 3279 3236 3236
q4 2133 2017 2022 2017
q5 5795 5753 5758 5753
q6 205 115 118 115
q7 2331 1892 1904 1892
q8 3344 3435 3441 3435
q9 8757 8754 8764 8754
q10 3795 3846 3820 3820
q11 558 441 449 441
q12 790 628 623 623
q13 6024 3157 3172 3157
q14 293 262 241 241
q15 549 495 498 495
q16 526 513 498 498
q17 1864 1844 1842 1842
q18 8611 8314 8198 8198
q19 1576 1618 1628 1618
q20 2173 1971 1946 1946
q21 5505 5320 5213 5213
q22 513 459 465 459
Total cold run time: 63818 ms
Total hot run time: 58848 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](tabletwriter) make tablet writer's rpc callback safe, could exit any time [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29684:
URL: https://github.com/apache/doris/pull/29684#issuecomment-1882493693
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](tabletwriter) make tablet writer's rpc callback safe, could exit any time [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29684:
URL: https://github.com/apache/doris/pull/29684#issuecomment-1882628403
TeamCity be ut coverage result:
Function Coverage: 36.65% (8642/23580)
Line Coverage: 28.65% (70223/245075)
Region Coverage: 27.59% (36307/131577)
Branch Coverage: 24.28% (18553/76400)
Coverage Report: http://coverage.selectdb-in.cc/coverage/86b862f7388b48d811b4898e9f7798fa1789583d_86b862f7388b48d811b4898e9f7798fa1789583d/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org