[GitHub] [skywalking] dylanforest commented on a diff in pull request #11336: Release alarm window when alarm metrics is expired in case OOM

["dylanforest (via GitHub)" <gi...@apache.org>]

dylanforest commented on code in PR #11336:
URL: https://github.com/apache/skywalking/pull/11336#discussion_r1327428493


##########
oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/RunningRule.java:
##########
@@ -198,8 +198,14 @@ public void moveTo(LocalDateTime targetTime) {
      */
     public List<AlarmMessage> check() {
         List<AlarmMessage> alarmMessageList = new ArrayList<>(30);
+        List<AlarmEntity> alarmEntityList = new ArrayList<>();

Review Comment:
   Details..



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org