You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@avro.apache.org by GitBox <gi...@apache.org> on 2020/09/29 21:26:20 UTC
[GitHub] [avro] krishnan1985 commented on a change in pull request #954: AVRO-2891: Expose last sync offset written on DataFileWriter
krishnan1985 commented on a change in pull request #954:
URL: https://github.com/apache/avro/pull/954#discussion_r497069416
##########
File path: lang/c++/api/DataFile.hh
##########
@@ -102,6 +103,11 @@ public:
*/
void syncIfNeeded();
+ /**
+ * Returns offset to the last sync marker written.
+ */
+ uint64_t getLastSync();
Review comment:
I like your suggestion. I will make the change.
However, I chose this name since it matched with the terminology used in DataFileReader. DataFileReader already exposes the following: pastSync(), previousSync(), etc. which denote the same. Should we rationalize these APIs as well in a future change?
##########
File path: lang/c++/api/DataFile.hh
##########
@@ -102,6 +103,11 @@ public:
*/
void syncIfNeeded();
+ /**
+ * Returns offset to the last sync marker written.
+ */
+ uint64_t getLastSync();
Review comment:
Thanks, Thiru! I like your suggestion. I will make the change.
However, I chose this name since it matched with the terminology used in DataFileReader. DataFileReader already exposes the following: pastSync(), previousSync(), etc. which denote the same. Should we rationalize these APIs as well in a future change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org