You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2022/09/26 03:00:05 UTC

[GitHub] [commons-geometry] darkma773r commented on pull request #199: Remove unnecessary validations. It's not null when it reaches it.

darkma773r commented on PR #199:
URL: https://github.com/apache/commons-geometry/pull/199#issuecomment-1257409768

   Yes, these changes look good. However, I'm confused since, unless I'm missing something, master already has these changes:
   - https://github.com/apache/commons-geometry/blob/master/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/oned/RegionBSPTree1D.java#L204
   - https://github.com/apache/commons-geometry/blob/master/commons-geometry-spherical/src/main/java/org/apache/commons/geometry/spherical/oned/RegionBSPTree1S.java#L247


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org