You are viewing a plain text version of this content. The canonical link for it is here.
Posted to ddlutils-dev@db.apache.org by "Konstantinos Stathatos (JIRA)" <ji...@apache.org> on 2005/12/17 02:58:35 UTC
[jira] Created: (DDLUTILS-54) Column comparison does not check on native types
Column comparison does not check on native types
------------------------------------------------
Key: DDLUTILS-54
URL: http://issues.apache.org/jira/browse/DDLUTILS-54
Project: DdlUtils
Type: Bug
Reporter: Konstantinos Stathatos
Assigned to: Thomas Dudziak
Priority: Minor
Attachments: zementis_tests.ant
The attached Ant script creates a table (in Derby) and then tries to alter it, using the same database description. I would expect the DdlUtils would not try to modify anything as the database has not changed.
However, the database defines a BOOLEAN column and a FLOAT column which in a Derby are mapped to a SMALLINT column and a DOUBLE column. With such a mapping, next time the columns are compared DdlUtils finds them different since the type codes are different. As a result, it tries to modify the columns even though the modification is not necessary.
Generally, such modification is really harmless. However, under my particular use case, occasionally a DBA would have to get involved and manually update the database if modifications are needed (i.e. if a non-empty alter sql is generated). This means that taking the extra step to check based on the native types if the modifications are material or not would be important.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (DDLUTILS-54) Column comparison does not check on native types
Posted by "Konstantinos Stathatos (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/DDLUTILS-54?page=all ]
Konstantinos Stathatos updated DDLUTILS-54:
-------------------------------------------
Attachment: derby_test.xml
> Column comparison does not check on native types
> ------------------------------------------------
>
> Key: DDLUTILS-54
> URL: http://issues.apache.org/jira/browse/DDLUTILS-54
> Project: DdlUtils
> Type: Bug
> Reporter: Konstantinos Stathatos
> Assignee: Thomas Dudziak
> Priority: Minor
> Attachments: derby_test.xml, zementis_tests.ant
>
> The attached Ant script creates a table (in Derby) and then tries to alter it, using the same database description. I would expect the DdlUtils would not try to modify anything as the database has not changed.
> However, the database defines a BOOLEAN column and a FLOAT column which in a Derby are mapped to a SMALLINT column and a DOUBLE column. With such a mapping, next time the columns are compared DdlUtils finds them different since the type codes are different. As a result, it tries to modify the columns even though the modification is not necessary.
> Generally, such modification is really harmless. However, under my particular use case, occasionally a DBA would have to get involved and manually update the database if modifications are needed (i.e. if a non-empty alter sql is generated). This means that taking the extra step to check based on the native types if the modifications are material or not would be important.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (DDLUTILS-54) Column comparison does not check on native types
Posted by "Konstantinos Stathatos (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/DDLUTILS-54?page=all ]
Konstantinos Stathatos updated DDLUTILS-54:
-------------------------------------------
Attachment: zementis_tests.ant
> Column comparison does not check on native types
> ------------------------------------------------
>
> Key: DDLUTILS-54
> URL: http://issues.apache.org/jira/browse/DDLUTILS-54
> Project: DdlUtils
> Type: Bug
> Reporter: Konstantinos Stathatos
> Assignee: Thomas Dudziak
> Priority: Minor
> Attachments: zementis_tests.ant
>
> The attached Ant script creates a table (in Derby) and then tries to alter it, using the same database description. I would expect the DdlUtils would not try to modify anything as the database has not changed.
> However, the database defines a BOOLEAN column and a FLOAT column which in a Derby are mapped to a SMALLINT column and a DOUBLE column. With such a mapping, next time the columns are compared DdlUtils finds them different since the type codes are different. As a result, it tries to modify the columns even though the modification is not necessary.
> Generally, such modification is really harmless. However, under my particular use case, occasionally a DBA would have to get involved and manually update the database if modifications are needed (i.e. if a non-empty alter sql is generated). This means that taking the extra step to check based on the native types if the modifications are material or not would be important.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Resolved: (DDLUTILS-54) Column comparison does not check on
native types
Posted by "Thomas Dudziak (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/DDLUTILS-54?page=all ]
Thomas Dudziak resolved DDLUTILS-54.
------------------------------------
Resolution: Fixed
I've added a unit test for this (testIssue54 in org.apache.ddlutils.io.TestAlteration) and apparently this is already fixed.
> Column comparison does not check on native types
> ------------------------------------------------
>
> Key: DDLUTILS-54
> URL: http://issues.apache.org/jira/browse/DDLUTILS-54
> Project: DdlUtils
> Issue Type: Bug
> Components: Core (No specific database)
> Reporter: Konstantinos Stathatos
> Assigned To: Thomas Dudziak
> Priority: Minor
> Fix For: 1.0
>
> Attachments: derby_test.xml, svndiff, zementis_tests.ant
>
>
> The attached Ant script creates a table (in Derby) and then tries to alter it, using the same database description. I would expect the DdlUtils would not try to modify anything as the database has not changed.
> However, the database defines a BOOLEAN column and a FLOAT column which in a Derby are mapped to a SMALLINT column and a DOUBLE column. With such a mapping, next time the columns are compared DdlUtils finds them different since the type codes are different. As a result, it tries to modify the columns even though the modification is not necessary.
> Generally, such modification is really harmless. However, under my particular use case, occasionally a DBA would have to get involved and manually update the database if modifications are needed (i.e. if a non-empty alter sql is generated). This means that taking the extra step to check based on the native types if the modifications are material or not would be important.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (DDLUTILS-54) Column comparison does not check on
native types
Posted by "Thomas Dudziak (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/DDLUTILS-54?page=all ]
Thomas Dudziak updated DDLUTILS-54:
-----------------------------------
Fix Version: 1.0
> Column comparison does not check on native types
> ------------------------------------------------
>
> Key: DDLUTILS-54
> URL: http://issues.apache.org/jira/browse/DDLUTILS-54
> Project: DdlUtils
> Type: Bug
> Reporter: Konstantinos Stathatos
> Assignee: Thomas Dudziak
> Priority: Minor
> Fix For: 1.0
> Attachments: derby_test.xml, svndiff, zementis_tests.ant
>
> The attached Ant script creates a table (in Derby) and then tries to alter it, using the same database description. I would expect the DdlUtils would not try to modify anything as the database has not changed.
> However, the database defines a BOOLEAN column and a FLOAT column which in a Derby are mapped to a SMALLINT column and a DOUBLE column. With such a mapping, next time the columns are compared DdlUtils finds them different since the type codes are different. As a result, it tries to modify the columns even though the modification is not necessary.
> Generally, such modification is really harmless. However, under my particular use case, occasionally a DBA would have to get involved and manually update the database if modifications are needed (i.e. if a non-empty alter sql is generated). This means that taking the extra step to check based on the native types if the modifications are material or not would be important.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (DDLUTILS-54) Column comparison does not check on
native types
Posted by "Thomas Dudziak (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/DDLUTILS-54?page=all ]
Thomas Dudziak updated DDLUTILS-54:
-----------------------------------
Component: Core (No specific database)
> Column comparison does not check on native types
> ------------------------------------------------
>
> Key: DDLUTILS-54
> URL: http://issues.apache.org/jira/browse/DDLUTILS-54
> Project: DdlUtils
> Type: Bug
> Components: Core (No specific database)
> Reporter: Konstantinos Stathatos
> Assignee: Thomas Dudziak
> Priority: Minor
> Fix For: 1.0
> Attachments: derby_test.xml, svndiff, zementis_tests.ant
>
> The attached Ant script creates a table (in Derby) and then tries to alter it, using the same database description. I would expect the DdlUtils would not try to modify anything as the database has not changed.
> However, the database defines a BOOLEAN column and a FLOAT column which in a Derby are mapped to a SMALLINT column and a DOUBLE column. With such a mapping, next time the columns are compared DdlUtils finds them different since the type codes are different. As a result, it tries to modify the columns even though the modification is not necessary.
> Generally, such modification is really harmless. However, under my particular use case, occasionally a DBA would have to get involved and manually update the database if modifications are needed (i.e. if a non-empty alter sql is generated). This means that taking the extra step to check based on the native types if the modifications are material or not would be important.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (DDLUTILS-54) Column comparison does not check on native types
Posted by "Konstantinos Stathatos (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/DDLUTILS-54?page=all ]
Konstantinos Stathatos updated DDLUTILS-54:
-------------------------------------------
Attachment: svndiff
The svndiff file contains the code changes in SQLBuilder that I think address the issue. It also includes a small change in CloudscapePlatform.java that adds what it seems to be a missing type mapping.
> Column comparison does not check on native types
> ------------------------------------------------
>
> Key: DDLUTILS-54
> URL: http://issues.apache.org/jira/browse/DDLUTILS-54
> Project: DdlUtils
> Type: Bug
> Reporter: Konstantinos Stathatos
> Assignee: Thomas Dudziak
> Priority: Minor
> Attachments: derby_test.xml, svndiff, zementis_tests.ant
>
> The attached Ant script creates a table (in Derby) and then tries to alter it, using the same database description. I would expect the DdlUtils would not try to modify anything as the database has not changed.
> However, the database defines a BOOLEAN column and a FLOAT column which in a Derby are mapped to a SMALLINT column and a DOUBLE column. With such a mapping, next time the columns are compared DdlUtils finds them different since the type codes are different. As a result, it tries to modify the columns even though the modification is not necessary.
> Generally, such modification is really harmless. However, under my particular use case, occasionally a DBA would have to get involved and manually update the database if modifications are needed (i.e. if a non-empty alter sql is generated). This means that taking the extra step to check based on the native types if the modifications are material or not would be important.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira