You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/04/20 08:35:25 UTC

[GitHub] [pulsar] BewareMyPower opened a new issue, #15232: [C++] Use CMake 3.13 to build C++ client in CI

BewareMyPower opened a new issue, #15232:
URL: https://github.com/apache/pulsar/issues/15232

   **Is your enhancement request related to a problem? Please describe.**
   Currently the `cmake_minimum_required` version is 3.4, which is wrong because some features from higher version CMake are used, like [target_link_options](https://cmake.org/cmake/help/git-stage/command/target_link_options.html).
   
   https://github.com/apache/pulsar/blob/caf7648653c140c9f922e86425585ab7b5ed3ed6/pulsar-client-cpp/CMakeLists.txt#L20
   
   **Describe the solution you'd like**
   Fix the wrong `cmake_minimum_required` declaration, and use the minimum required version of CMake (it should be 3.13) to build C++ client in CI.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] tisonkun closed issue #15232: [C++] Use CMake 3.13 to build C++ client in CI

Posted by GitBox <gi...@apache.org>.
tisonkun closed issue #15232: [C++] Use CMake 3.13 to build C++ client in CI
URL: https://github.com/apache/pulsar/issues/15232


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] BewareMyPower commented on issue #15232: [C++] Use CMake 3.13 to build C++ client in CI

Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on issue #15232:
URL: https://github.com/apache/pulsar/issues/15232#issuecomment-1106278429

   The document [here](https://github.com/apache/pulsar/tree/master/pulsar-client-cpp#requirements) is also wrong.
   
   <img width="584" alt="image" src="https://user-images.githubusercontent.com/18204803/164681938-c05de623-cd2b-4a8d-b970-0b1542daddab.png">
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] github-actions[bot] commented on issue #15232: [C++] Use CMake 3.13 to build C++ client in CI

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #15232:
URL: https://github.com/apache/pulsar/issues/15232#issuecomment-1134091588

   The issue had no activity for 30 days, mark with Stale label.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] tisonkun commented on issue #15232: [C++] Use CMake 3.13 to build C++ client in CI

Posted by GitBox <gi...@apache.org>.
tisonkun commented on issue #15232:
URL: https://github.com/apache/pulsar/issues/15232#issuecomment-1338985235

   Closed. The development of the C++ client has been moved out.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] github-actions[bot] commented on issue #15232: [C++] Use CMake 3.13 to build C++ client in CI

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #15232:
URL: https://github.com/apache/pulsar/issues/15232#issuecomment-1162547377

   The issue had no activity for 30 days, mark with Stale label.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org