You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Houx Zhang (JIRA)" <ji...@apache.org> on 2011/06/16 16:07:47 UTC
[jira] [Created] (DERBY-5282) Convert store/RowLockBasic.sql to
junit
Convert store/RowLockBasic.sql to junit
---------------------------------------
Key: DERBY-5282
URL: https://issues.apache.org/jira/browse/DERBY-5282
Project: Derby
Issue Type: Sub-task
Components: Test
Reporter: Houx Zhang
Assignee: Houx Zhang
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DERBY-5282) Convert store/RowLockBasic.sql to
junit
Posted by "Houx Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Houx Zhang updated DERBY-5282:
------------------------------
Attachment: (was: derby-5147-1.patch)
> Convert store/RowLockBasic.sql to junit
> ---------------------------------------
>
> Key: DERBY-5282
> URL: https://issues.apache.org/jira/browse/DERBY-5282
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Reporter: Houx Zhang
> Assignee: Houx Zhang
> Labels: gsoc2011
> Attachments: derby-5282-1.patch, derby-5282-1.state
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DERBY-5282) Convert store/RowLockBasic.sql to
junit
Posted by "Bryan Pendleton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13057233#comment-13057233 ]
Bryan Pendleton commented on DERBY-5282:
----------------------------------------
Excellent! And interesting to learn about the differing names for the isolation levels. I knew that once, long ago... :)
I'm intending to commit this patch.
> Convert store/RowLockBasic.sql to junit
> ---------------------------------------
>
> Key: DERBY-5282
> URL: https://issues.apache.org/jira/browse/DERBY-5282
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Reporter: Houx Zhang
> Assignee: Houx Zhang
> Labels: gsoc2011
> Attachments: derby-5282-1.patch, derby-5282-1.state, derby-5282-2.patch, derby-5282-2.state
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (DERBY-5282) Convert store/RowLockBasic.sql to
junit
Posted by "Bryan Pendleton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Pendleton resolved DERBY-5282.
------------------------------------
Resolution: Fixed
Fix Version/s: 10.9.0.0
Issue & fix info: (was: [Patch Available])
Committed the new test to the trunk as revision 1141368.
Thank you for your contribution to Derby!
> Convert store/RowLockBasic.sql to junit
> ---------------------------------------
>
> Key: DERBY-5282
> URL: https://issues.apache.org/jira/browse/DERBY-5282
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Reporter: Houx Zhang
> Assignee: Houx Zhang
> Labels: gsoc2011
> Fix For: 10.9.0.0
>
> Attachments: derby-5282-1.patch, derby-5282-1.state, derby-5282-2.patch, derby-5282-2.state
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DERBY-5282) Convert store/RowLockBasic.sql to
junit
Posted by "Myrna van Lunteren (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13058173#comment-13058173 ]
Myrna van Lunteren commented on DERBY-5282:
-------------------------------------------
Dag commented (6/30/2011) on the commit of revision 1141368 - apparently replies on the commit messages don't make it back into JIRA, so just for the record, here is that comment:
"I didn't follow this one, but I notice setUp and teardown do not call
super.setUp, super.tearDown respectively as per the idiom. Is there a
reason for this here? Notably BaseJDBCTestCase#tearDown does some
cleaning up. It may not be required here, but it's generally good to
stick to the idiom."
Houx Zhang replied: "Yes, Dag. I agree with you, and will adopt it."
Looks like Bryan already added super.teardown with revision 1141769.
> Convert store/RowLockBasic.sql to junit
> ---------------------------------------
>
> Key: DERBY-5282
> URL: https://issues.apache.org/jira/browse/DERBY-5282
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Reporter: Houx Zhang
> Assignee: Houx Zhang
> Labels: gsoc2011
> Fix For: 10.9.0.0
>
> Attachments: derby-5282-1.patch, derby-5282-1.state, derby-5282-2.patch, derby-5282-2.state, derby-5282-3.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DERBY-5282) Convert store/RowLockBasic.sql to
junit
Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13057890#comment-13057890 ]
Knut Anders Hatlen commented on DERBY-5282:
-------------------------------------------
Thanks for making the changes, Houx. Just two small nits: The class name in the license header is incorrect, and the patch adds some trailing blanks after the dropTable() call in setUp(). Otherwise, the patch looks good to me.
> Convert store/RowLockBasic.sql to junit
> ---------------------------------------
>
> Key: DERBY-5282
> URL: https://issues.apache.org/jira/browse/DERBY-5282
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Reporter: Houx Zhang
> Assignee: Houx Zhang
> Labels: gsoc2011
> Fix For: 10.9.0.0
>
> Attachments: derby-5282-1.patch, derby-5282-1.state, derby-5282-2.patch, derby-5282-2.state, derby-5282-3.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DERBY-5282) Convert store/RowLockBasic.sql to
junit
Posted by "Houx Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Houx Zhang updated DERBY-5282:
------------------------------
Attachment: derby-5147-1.state
derby-5147-1.patch
Ask for help. There is one test can not pass. It's testFullCoveredIndexScan().
It says:
junit.framework.AssertionFailedError: Unexpected row count: expected:<1> but was:<5>
But when I changed the data from 1 to 5, It syas:
junit.framework.AssertionFailedError: Unexpected row count: expected:<5> but was:<1>
Thanks.
> Convert store/RowLockBasic.sql to junit
> ---------------------------------------
>
> Key: DERBY-5282
> URL: https://issues.apache.org/jira/browse/DERBY-5282
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Reporter: Houx Zhang
> Assignee: Houx Zhang
> Labels: gsoc2011
> Attachments: derby-5147-1.patch, derby-5147-1.state
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DERBY-5282) Convert store/RowLockBasic.sql to
junit
Posted by "Houx Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Houx Zhang updated DERBY-5282:
------------------------------
Attachment: (was: derby-5147-1.state)
> Convert store/RowLockBasic.sql to junit
> ---------------------------------------
>
> Key: DERBY-5282
> URL: https://issues.apache.org/jira/browse/DERBY-5282
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Reporter: Houx Zhang
> Assignee: Houx Zhang
> Labels: gsoc2011
> Attachments: derby-5147-1.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DERBY-5282) Convert store/RowLockBasic.sql to
junit
Posted by "Houx Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Houx Zhang updated DERBY-5282:
------------------------------
Attachment: derby-5282-3.patch
Thanks for your advice, Knut. I have adopted them in the new patch and added a class comment. Please check it, thanks.
> Convert store/RowLockBasic.sql to junit
> ---------------------------------------
>
> Key: DERBY-5282
> URL: https://issues.apache.org/jira/browse/DERBY-5282
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Reporter: Houx Zhang
> Assignee: Houx Zhang
> Labels: gsoc2011
> Fix For: 10.9.0.0
>
> Attachments: derby-5282-1.patch, derby-5282-1.state, derby-5282-2.patch, derby-5282-2.state, derby-5282-3.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DERBY-5282) Convert store/RowLockBasic.sql to
junit
Posted by "Bryan Pendleton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13056950#comment-13056950 ]
Bryan Pendleton commented on DERBY-5282:
----------------------------------------
The reason you are seeing 5 rows instead of the expected 1 row is because that particular
test is deciding to do row-level locking instead of table-level locking, and the select from lock_table
is returning 1 Table-level IS lock and 4 Row-level S locks.
I ran the test with -Dderby.language.logQueryPlan=true and the choice of row-level locking
is also confirmed by the trace output:
Tue Jun 28 18:25:12 PDT 2011 Thread[main,5,main] (XID = 242), (SESSIONID = 3), select a from a ******* Index Scan ResultSet for A using index A_IDX at repeatable read isolation level using share row locking chosen by the optimizer
Number of opens = 1
Rows seen = 4
Rows filtered = 0
scan information:
Bit set of columns fetched={0}
Number of columns fetched=1
Number of deleted rows visited=0
Number of pages visited=1
Number of rows qualified=4
Number of rows visited=4
I extracted the relevant bit of SQL into a small separate file and ran it
under IJ, and sure enough when I do that Derby chooses table-level locking.
Tue Jun 28 18:45:21 PDT 2011 Thread[main,5,main] (XID = 245), (SESSIONID = 1), --------------------------------------------------------------------------------
-- Do full covered index scan.
--------------------------------------------------------------------------------
select a from a ******* Index Scan ResultSet for A using index A_IDX at serializable isolation level using share table locking chosen by the optimizer
Number of opens = 1
Rows seen = 4
Then I noticed that in the row-level locking result, Derby is using "repeatable
read" isolation, while in the table-level locking result, Derby is using "serializable"
isolation.
So I tried changing your test code so that instead of setting the isolation
level to TRANSACTION_REPEATABLE_READ in the setUp() method, it
sets TRANSACTION_SERIALIZABLE instead.
And then the test passes -- Derby uses table level locking and all is well.
What is curious is that clearly the original test looks like it is trying to use
REPEATABLE_READ isolation, as it contains:
set isolation to RR;
at the very start of the test.
Perhaps this line in the test isn't actually working, though, and the test
is still using SERIALIZABLE, not REPEATABLE_READ isolation?
Can you try changing the test in your environment to use SERIALIZABLE
isolation and verify whether or not the test then passes for you?
> Convert store/RowLockBasic.sql to junit
> ---------------------------------------
>
> Key: DERBY-5282
> URL: https://issues.apache.org/jira/browse/DERBY-5282
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Reporter: Houx Zhang
> Assignee: Houx Zhang
> Labels: gsoc2011
> Attachments: derby-5282-1.patch, derby-5282-1.state
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DERBY-5282) Convert store/RowLockBasic.sql to
junit
Posted by "Houx Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Houx Zhang updated DERBY-5282:
------------------------------
Attachment: derby-5282-3.patch
Thanks for your advice, Knut. I have adopted them in the new patch and added a class comment. Please check it, thanks.
> Convert store/RowLockBasic.sql to junit
> ---------------------------------------
>
> Key: DERBY-5282
> URL: https://issues.apache.org/jira/browse/DERBY-5282
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Reporter: Houx Zhang
> Assignee: Houx Zhang
> Labels: gsoc2011
> Fix For: 10.9.0.0
>
> Attachments: derby-5282-1.patch, derby-5282-1.state, derby-5282-2.patch, derby-5282-2.state, derby-5282-3.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DERBY-5282) Convert store/RowLockBasic.sql to
junit
Posted by "Houx Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Houx Zhang updated DERBY-5282:
------------------------------
Attachment: (was: derby-5282-3.patch)
> Convert store/RowLockBasic.sql to junit
> ---------------------------------------
>
> Key: DERBY-5282
> URL: https://issues.apache.org/jira/browse/DERBY-5282
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Reporter: Houx Zhang
> Assignee: Houx Zhang
> Labels: gsoc2011
> Fix For: 10.9.0.0
>
> Attachments: derby-5282-1.patch, derby-5282-1.state, derby-5282-2.patch, derby-5282-2.state, derby-5282-3.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (DERBY-5282) Convert store/RowLockBasic.sql to
junit
Posted by "Houx Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Houx Zhang closed DERBY-5282.
-----------------------------
> Convert store/RowLockBasic.sql to junit
> ---------------------------------------
>
> Key: DERBY-5282
> URL: https://issues.apache.org/jira/browse/DERBY-5282
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Reporter: Houx Zhang
> Assignee: Houx Zhang
> Labels: gsoc2011
> Fix For: 10.9.0.0
>
> Attachments: derby-5282-1.patch, derby-5282-1.state, derby-5282-2.patch, derby-5282-2.state, derby-5282-3.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DERBY-5282) Convert store/RowLockBasic.sql to
junit
Posted by "Bryan Pendleton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13057850#comment-13057850 ]
Bryan Pendleton commented on DERBY-5282:
----------------------------------------
The new patch looks great. I'll see about committing it later today, when I get back to my main computer.
> Convert store/RowLockBasic.sql to junit
> ---------------------------------------
>
> Key: DERBY-5282
> URL: https://issues.apache.org/jira/browse/DERBY-5282
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Reporter: Houx Zhang
> Assignee: Houx Zhang
> Labels: gsoc2011
> Fix For: 10.9.0.0
>
> Attachments: derby-5282-1.patch, derby-5282-1.state, derby-5282-2.patch, derby-5282-2.state, derby-5282-3.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DERBY-5282) Convert store/RowLockBasic.sql to
junit
Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13057643#comment-13057643 ]
Knut Anders Hatlen commented on DERBY-5282:
-------------------------------------------
A couple post-commit review comments:
- The new test should have a license header.
- We should probably remove the try/catch in the setUp() method. If something fails in setUp(), it would be better if the test case failed. Failures that are just printed to the console are less likely to be noticed.
- The tearDown() method should call super.tearDown() before it returns so that BaseJDBCTestCase's cleanup also runs.
- Saving the original isolation level in setUp() and restoring it in tearDown() shouldn't be necessary since the connection isn't used again after tearDown().
> Convert store/RowLockBasic.sql to junit
> ---------------------------------------
>
> Key: DERBY-5282
> URL: https://issues.apache.org/jira/browse/DERBY-5282
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Reporter: Houx Zhang
> Assignee: Houx Zhang
> Labels: gsoc2011
> Fix For: 10.9.0.0
>
> Attachments: derby-5282-1.patch, derby-5282-1.state, derby-5282-2.patch, derby-5282-2.state
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DERBY-5282) Convert store/RowLockBasic.sql to
junit
Posted by "Houx Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Houx Zhang updated DERBY-5282:
------------------------------
Issue & fix info: [Patch Available]
> Convert store/RowLockBasic.sql to junit
> ---------------------------------------
>
> Key: DERBY-5282
> URL: https://issues.apache.org/jira/browse/DERBY-5282
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Reporter: Houx Zhang
> Assignee: Houx Zhang
> Labels: gsoc2011
> Attachments: derby-5282-1.patch, derby-5282-1.state, derby-5282-2.patch, derby-5282-2.state
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DERBY-5282) Convert store/RowLockBasic.sql to
junit
Posted by "Houx Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Houx Zhang updated DERBY-5282:
------------------------------
Comment: was deleted
(was: Thanks for your advice, Knut. I have adopted them in the new patch and added a class comment. Please check it, thanks.)
> Convert store/RowLockBasic.sql to junit
> ---------------------------------------
>
> Key: DERBY-5282
> URL: https://issues.apache.org/jira/browse/DERBY-5282
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Reporter: Houx Zhang
> Assignee: Houx Zhang
> Labels: gsoc2011
> Fix For: 10.9.0.0
>
> Attachments: derby-5282-1.patch, derby-5282-1.state, derby-5282-2.patch, derby-5282-2.state, derby-5282-3.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DERBY-5282) Convert store/RowLockBasic.sql to
junit
Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13057111#comment-13057111 ]
Knut Anders Hatlen commented on DERBY-5282:
-------------------------------------------
The SET ISOLATION statement follows the DB2 naming of the isolation levels, which doesn't match the names used in SQL and JDBC. And just to make things extra confusing, they both have an isolation level called "repeatable read", but not the same one, so "set isolation to RR" actually sets the isolation level to Connection.TRANSACTION_SERIALIZABLE. The mapping between DB2 isolation levels and JDBC isolation levels can be found here: http://db.apache.org/derby/docs/dev/devguide/cdevconcepts15366.html
> Convert store/RowLockBasic.sql to junit
> ---------------------------------------
>
> Key: DERBY-5282
> URL: https://issues.apache.org/jira/browse/DERBY-5282
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Reporter: Houx Zhang
> Assignee: Houx Zhang
> Labels: gsoc2011
> Attachments: derby-5282-1.patch, derby-5282-1.state
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DERBY-5282) Convert store/RowLockBasic.sql to
junit
Posted by "Houx Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Houx Zhang updated DERBY-5282:
------------------------------
Attachment: derby-5282-2.state
derby-5282-2.patch
Thanks, Bryan and Knut.
It does work with the new isolation.
> Convert store/RowLockBasic.sql to junit
> ---------------------------------------
>
> Key: DERBY-5282
> URL: https://issues.apache.org/jira/browse/DERBY-5282
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Reporter: Houx Zhang
> Assignee: Houx Zhang
> Labels: gsoc2011
> Attachments: derby-5282-1.patch, derby-5282-1.state, derby-5282-2.patch, derby-5282-2.state
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DERBY-5282) Convert store/RowLockBasic.sql to
junit
Posted by "Houx Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Houx Zhang updated DERBY-5282:
------------------------------
Attachment: derby-5282-1.state
derby-5282-1.patch
Just for rename the patches.
> Convert store/RowLockBasic.sql to junit
> ---------------------------------------
>
> Key: DERBY-5282
> URL: https://issues.apache.org/jira/browse/DERBY-5282
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Reporter: Houx Zhang
> Assignee: Houx Zhang
> Labels: gsoc2011
> Attachments: derby-5282-1.patch, derby-5282-1.state
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DERBY-5282) Convert store/RowLockBasic.sql to
junit
Posted by "Bryan Pendleton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-5282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13058156#comment-13058156 ]
Bryan Pendleton commented on DERBY-5282:
----------------------------------------
I corrected the class name in the header comment and cleaned up the trailing blanks, verified that the
test continues to run properly, and submitted the follow-on patch as revision 1141769.
> Convert store/RowLockBasic.sql to junit
> ---------------------------------------
>
> Key: DERBY-5282
> URL: https://issues.apache.org/jira/browse/DERBY-5282
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Reporter: Houx Zhang
> Assignee: Houx Zhang
> Labels: gsoc2011
> Fix For: 10.9.0.0
>
> Attachments: derby-5282-1.patch, derby-5282-1.state, derby-5282-2.patch, derby-5282-2.state, derby-5282-3.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira