You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@wicket.apache.org by solomax <gi...@git.apache.org> on 2017/11/14 03:15:49 UTC

[GitHub] wicket pull request #240: WICKET-6055 non-blocking lazy loading

Github user solomax commented on a diff in the pull request:

    https://github.com/apache/wicket/pull/240#discussion_r150728332
  
    --- Diff: wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/AjaxLazyLoadPanelTesterTest.java ---
    @@ -38,12 +38,12 @@
     	@Test
     	public void test()
     	{
    -		AjaxLazyLoadPanel panel = new AjaxLazyLoadPanel("panel")
    +		AjaxLazyLoadPanel<Component> panel = new AjaxLazyLoadPanel<Component>("panel")
     		{
     			private static final long serialVersionUID = 1L;
     
     			@Override
    -			public Component getLazyLoadComponent(final String markupId)
    +			protected Component getLazyLoadComponent(String markupId)
    --- End diff --
    
    I guess `markupId` can remain `final` here ...


---