You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/02/19 20:01:18 UTC
[jira] [Commented] (TS-4065) change metrics to counters where
appropriate
[ https://issues.apache.org/jira/browse/TS-4065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15154665#comment-15154665 ]
ASF GitHub Bot commented on TS-4065:
------------------------------------
GitHub user meeramn opened a pull request:
https://github.com/apache/trafficserver/pull/488
TS-4065: Change metrics to counters in RecordsConfig
I have fixed some metrics which have counter semantics by changing them from RECD_INT to RECD_COUNTER. Please review.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/meeramn/trafficserver TS-4065
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/488.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #488
----
commit 6738153340be24408e37fc34ac6caf28cd031735
Author: Meera Mosale Nataraja <me...@gmail.com>
Date: 2016-02-19T18:54:29Z
Change metrics to counters in RecordsConfig
----
> change metrics to counters where appropriate
> --------------------------------------------
>
> Key: TS-4065
> URL: https://issues.apache.org/jira/browse/TS-4065
> Project: Traffic Server
> Issue Type: Bug
> Components: Management API, Metrics
> Reporter: James Peach
> Assignee: Meera Mosale Nataraja
> Fix For: sometime
>
>
> In {{mgmt/RecordsConfig.cc}} almost all the metrics are registered as {{RECT_INT}} even though many (most?) of them have counter semantics. We should register the counters as {{RECT_COUNTER}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)