You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/05/26 11:51:15 UTC
[GitHub] [spark] peter-toth opened a new pull request, #36687: [SPARK-36681][CORE][TESTS][FOLLOW-UP] Handle LinkageError when Snappy native library is not available in low Hadoop versions
peter-toth opened a new pull request, #36687:
URL: https://github.com/apache/spark/pull/36687
### What changes were proposed in this pull request?
This is a follow-up to fix `LinkageError` handling in `FileSuite` to avoid test suite abort when Snappy native library is not available in low Hadoop versions:
```
23:16:22 FileSuite:
23:16:22 org.apache.spark.FileSuite *** ABORTED ***
23:16:22 java.lang.RuntimeException: Unable to load a Suite class that was discovered in the runpath: org.apache.spark.FileSuite
23:16:22 at org.scalatest.tools.DiscoverySuite$.getSuiteInstance(DiscoverySuite.scala:81)
23:16:22 at org.scalatest.tools.DiscoverySuite.$anonfun$nestedSuites$1(DiscoverySuite.scala:38)
23:16:22 at scala.collection.TraversableLike.$anonfun$map$1(TraversableLike.scala:238)
23:16:22 at scala.collection.Iterator.foreach(Iterator.scala:941)
23:16:22 at scala.collection.Iterator.foreach$(Iterator.scala:941)
23:16:22 at scala.collection.AbstractIterator.foreach(Iterator.scala:1429)
23:16:22 at scala.collection.IterableLike.foreach(IterableLike.scala:74)
23:16:22 at scala.collection.IterableLike.foreach$(IterableLike.scala:73)
23:16:22 at scala.collection.AbstractIterable.foreach(Iterable.scala:56)
23:16:22 at scala.collection.TraversableLike.map(TraversableLike.scala:238)
23:16:22 ...
23:16:22 Cause: java.lang.UnsatisfiedLinkError: org.apache.hadoop.util.NativeCodeLoader.buildSupportsSnappy()Z
23:16:22 at org.apache.hadoop.util.NativeCodeLoader.buildSupportsSnappy(Native Method)
23:16:22 at org.apache.hadoop.io.compress.SnappyCodec.checkNativeCodeLoaded(SnappyCodec.java:63)
23:16:22 at org.apache.hadoop.io.compress.SnappyCodec.getCompressorType(SnappyCodec.java:136)
23:16:22 at org.apache.spark.FileSuite.$anonfun$new$12(FileSuite.scala:145)
23:16:22 at scala.util.Try$.apply(Try.scala:213)
23:16:22 at org.apache.spark.FileSuite.<init>(FileSuite.scala:141)
23:16:22 at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
23:16:22 at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
23:16:22 at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
23:16:22 at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
```
Scala's `Try` can handle only `NonFatal` throwables.
### Why are the changes needed?
To make the tests robust.
### Does this PR introduce _any_ user-facing change?
Nope, this is test-only.
### How was this patch tested?
Manual test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] peter-toth commented on pull request #36687: [SPARK-36681][CORE][TESTS][FOLLOW-UP] Handle LinkageError when Snappy native library is not available in low Hadoop versions
Posted by GitBox <gi...@apache.org>.
peter-toth commented on PR #36687:
URL: https://github.com/apache/spark/pull/36687#issuecomment-1138458515
cc @HyukjinKwon, @viirya, @dongjoon-hyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] peter-toth commented on pull request #36687: [SPARK-36681][CORE][TESTS][FOLLOW-UP] Handle LinkageError when Snappy native library is not available in low Hadoop versions
Posted by GitBox <gi...@apache.org>.
peter-toth commented on PR #36687:
URL: https://github.com/apache/spark/pull/36687#issuecomment-1138918331
Thanks all for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #36687: [SPARK-36681][CORE][TESTS][FOLLOW-UP] Handle LinkageError when Snappy native library is not available in low Hadoop versions
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #36687: [SPARK-36681][CORE][TESTS][FOLLOW-UP] Handle LinkageError when Snappy native library is not available in low Hadoop versions
URL: https://github.com/apache/spark/pull/36687
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org