You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/07/03 18:55:28 UTC

[GitHub] [flink] mans2singh opened a new pull request #16365: [hotfix][docs][cassandra] Added missing cluster builder arg for cassa…

mans2singh opened a new pull request #16365:
URL: https://github.com/apache/flink/pull/16365


   ## What is the purpose of the change
   
   * Added cluster builder arg to setClusterBuilder method 
   
   ## Brief change log
   
   * Added missing arg to setClusterBuilder method
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] mans2singh commented on pull request #16365: [hotfix][docs][cassandra] Added missing cluster builder arg for cassa…

Posted by GitBox <gi...@apache.org>.
mans2singh commented on pull request #16365:
URL: https://github.com/apache/flink/pull/16365#issuecomment-875178952


   @leonardBang - 
   
   I've added the public methods mentioned above to the PR.  
   
   Please let me know if you have any other recommendations.  
   
   Thanks for your time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #16365: [hotfix][docs][cassandra] Added missing cluster builder arg for cassa…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16365:
URL: https://github.com/apache/flink/pull/16365#issuecomment-873458544


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c4606833b4e794ef2d15060becd41b522a50a27d",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19864",
       "triggerID" : "c4606833b4e794ef2d15060becd41b522a50a27d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9f80cf1a5609cb52e23e0bb739ebe20ec2304977",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20043",
       "triggerID" : "9f80cf1a5609cb52e23e0bb739ebe20ec2304977",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c4606833b4e794ef2d15060becd41b522a50a27d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19864) 
   * 9f80cf1a5609cb52e23e0bb739ebe20ec2304977 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20043) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] mans2singh commented on pull request #16365: [hotfix][docs][cassandra] Added missing cluster builder arg for cassa…

Posted by GitBox <gi...@apache.org>.
mans2singh commented on pull request #16365:
URL: https://github.com/apache/flink/pull/16365#issuecomment-874072415


   Thanks @xixingya for your review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #16365: [hotfix][docs][cassandra] Added missing cluster builder arg for cassa…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16365:
URL: https://github.com/apache/flink/pull/16365#issuecomment-873458544


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c4606833b4e794ef2d15060becd41b522a50a27d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19864",
       "triggerID" : "c4606833b4e794ef2d15060becd41b522a50a27d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9f80cf1a5609cb52e23e0bb739ebe20ec2304977",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20043",
       "triggerID" : "9f80cf1a5609cb52e23e0bb739ebe20ec2304977",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9f80cf1a5609cb52e23e0bb739ebe20ec2304977 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=20043) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] mans2singh commented on pull request #16365: [hotfix][docs][cassandra] Added missing cluster builder arg for cassa…

Posted by GitBox <gi...@apache.org>.
mans2singh commented on pull request #16365:
URL: https://github.com/apache/flink/pull/16365#issuecomment-875417518


   Thanks @leonardBang @wuchong 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #16365: [hotfix][docs][cassandra] Added missing cluster builder arg for cassa…

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16365:
URL: https://github.com/apache/flink/pull/16365#issuecomment-873454552


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit c4606833b4e794ef2d15060becd41b522a50a27d (Sat Jul 03 18:58:14 UTC 2021)
   
    ✅no warnings
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] mans2singh commented on pull request #16365: [hotfix][docs][cassandra] Added missing cluster builder arg for cassa…

Posted by GitBox <gi...@apache.org>.
mans2singh commented on pull request #16365:
URL: https://github.com/apache/flink/pull/16365#issuecomment-874072415


   Thanks @xixingya for your review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #16365: [hotfix][docs][cassandra] Added missing cluster builder arg for cassa…

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16365:
URL: https://github.com/apache/flink/pull/16365#issuecomment-873458544


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c4606833b4e794ef2d15060becd41b522a50a27d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "c4606833b4e794ef2d15060becd41b522a50a27d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c4606833b4e794ef2d15060becd41b522a50a27d UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #16365: [hotfix][docs][cassandra] Added missing cluster builder arg for cassa…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16365:
URL: https://github.com/apache/flink/pull/16365#issuecomment-873458544


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c4606833b4e794ef2d15060becd41b522a50a27d",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19864",
       "triggerID" : "c4606833b4e794ef2d15060becd41b522a50a27d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c4606833b4e794ef2d15060becd41b522a50a27d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19864) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #16365: [hotfix][docs][cassandra] Added missing cluster builder arg for cassa…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16365:
URL: https://github.com/apache/flink/pull/16365#issuecomment-873458544


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c4606833b4e794ef2d15060becd41b522a50a27d",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19864",
       "triggerID" : "c4606833b4e794ef2d15060becd41b522a50a27d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c4606833b4e794ef2d15060becd41b522a50a27d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19864) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #16365: [hotfix][docs][cassandra] Added missing cluster builder arg for cassa…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16365:
URL: https://github.com/apache/flink/pull/16365#issuecomment-873454552


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 9f80cf1a5609cb52e23e0bb739ebe20ec2304977 (Thu Sep 23 17:58:57 UTC 2021)
   
    ✅no warnings
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] mans2singh commented on pull request #16365: [hotfix][docs][cassandra] Added missing cluster builder arg for cassa…

Posted by GitBox <gi...@apache.org>.
mans2singh commented on pull request #16365:
URL: https://github.com/apache/flink/pull/16365#issuecomment-874746420


   @leonardBang @Airblader @wuchong @tisonkun - Can you please let me know if this PR requires any additional changes ?  Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] wuchong merged pull request #16365: [hotfix][docs][cassandra] Added missing cluster builder arg for cassa…

Posted by GitBox <gi...@apache.org>.
wuchong merged pull request #16365:
URL: https://github.com/apache/flink/pull/16365


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #16365: [hotfix][docs][cassandra] Added missing cluster builder arg for cassa…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16365:
URL: https://github.com/apache/flink/pull/16365#issuecomment-873458544


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c4606833b4e794ef2d15060becd41b522a50a27d",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19864",
       "triggerID" : "c4606833b4e794ef2d15060becd41b522a50a27d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9f80cf1a5609cb52e23e0bb739ebe20ec2304977",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "9f80cf1a5609cb52e23e0bb739ebe20ec2304977",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c4606833b4e794ef2d15060becd41b522a50a27d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19864) 
   * 9f80cf1a5609cb52e23e0bb739ebe20ec2304977 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] leonardBang commented on pull request #16365: [hotfix][docs][cassandra] Added missing cluster builder arg for cassa…

Posted by GitBox <gi...@apache.org>.
leonardBang commented on pull request #16365:
URL: https://github.com/apache/flink/pull/16365#issuecomment-874801646


   @mans2singh Thanks for the contribution, the change looks good. But IIUC,  the public methods `setDefaultKeyspace(String keyspace)` and `enableIgnoreNullFields() `  should also be considered here, could you also add them?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org