You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Sekretenko <as...@mesosphere.io> on 2019/03/28 14:12:00 UTC
Review Request 70334: Extended the glog LogSink interface to be able
to log microseconds.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70334/
-----------------------------------------------------------
Review request for mesos, Benno Evers, Greg Mann, and Joseph Wu.
Repository: mesos
Description
-------
Extended the LogSink interface to be able to log microseconds.
This makes possible to solve a problem with modules implementing custom LogSink which currently log 000000 instead of microseconds.
This is a backport of this patch: https://github.com/google/glog/pull/441 to glog 0.3.3
Diffs
-----
3rdparty/glog-0.3.3.patch 8827f34e2b4589867d13160850b76c572c85ab06
Diff: https://reviews.apache.org/r/70334/diff/1/
Testing
-------
Run existing tests, including Windows build.
Thanks,
Andrei Sekretenko
Re: Review Request 70334: Extended the glog LogSink interface to be
able to log microseconds.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70334/#review214192
-----------------------------------------------------------
PASS: Mesos patch 70334 was successfully built and tested.
Reviews applied: `['70334']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3040/mesos-review-70334
- Mesos Reviewbot Windows
On March 28, 2019, 6:27 p.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70334/
> -----------------------------------------------------------
>
> (Updated March 28, 2019, 6:27 p.m.)
>
>
> Review request for mesos, Benno Evers, Greg Mann, and Joseph Wu.
>
>
> Bugs: MESOS-9687
> https://issues.apache.org/jira/browse/MESOS-9687
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Extended the LogSink interface to be able to log microseconds.
>
> This makes possible to solve a problem with modules implementing custom LogSink which currently log 000000 instead of microseconds.
>
> This is a backport of this patch: https://github.com/google/glog/pull/441 to glog 0.3.3
>
>
> Diffs
> -----
>
> 3rdparty/glog-0.3.3.patch 8827f34e2b4589867d13160850b76c572c85ab06
>
>
> Diff: https://reviews.apache.org/r/70334/diff/1/
>
>
> Testing
> -------
>
> Run existing tests, including Windows build.
>
>
> Thanks,
>
> Andrei Sekretenko
>
>
Re: Review Request 70334: Extended the glog LogSink interface to be
able to log microseconds.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70334/#review214184
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On March 28, 2019, 11:27 a.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70334/
> -----------------------------------------------------------
>
> (Updated March 28, 2019, 11:27 a.m.)
>
>
> Review request for mesos, Benno Evers, Greg Mann, and Joseph Wu.
>
>
> Bugs: MESOS-9687
> https://issues.apache.org/jira/browse/MESOS-9687
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Extended the LogSink interface to be able to log microseconds.
>
> This makes possible to solve a problem with modules implementing custom LogSink which currently log 000000 instead of microseconds.
>
> This is a backport of this patch: https://github.com/google/glog/pull/441 to glog 0.3.3
>
>
> Diffs
> -----
>
> 3rdparty/glog-0.3.3.patch 8827f34e2b4589867d13160850b76c572c85ab06
>
>
> Diff: https://reviews.apache.org/r/70334/diff/1/
>
>
> Testing
> -------
>
> Run existing tests, including Windows build.
>
>
> Thanks,
>
> Andrei Sekretenko
>
>
Re: Review Request 70334: Extended the glog LogSink interface to be
able to log microseconds.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70334/#review214203
-----------------------------------------------------------
Ship it!
Ship It!
- Benno Evers
On March 28, 2019, 6:27 p.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70334/
> -----------------------------------------------------------
>
> (Updated March 28, 2019, 6:27 p.m.)
>
>
> Review request for mesos, Benno Evers, Greg Mann, and Joseph Wu.
>
>
> Bugs: MESOS-9687
> https://issues.apache.org/jira/browse/MESOS-9687
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Extended the LogSink interface to be able to log microseconds.
>
> This makes possible to solve a problem with modules implementing custom LogSink which currently log 000000 instead of microseconds.
>
> This is a backport of this patch: https://github.com/google/glog/pull/441 to glog 0.3.3
>
>
> Diffs
> -----
>
> 3rdparty/glog-0.3.3.patch 8827f34e2b4589867d13160850b76c572c85ab06
>
>
> Diff: https://reviews.apache.org/r/70334/diff/1/
>
>
> Testing
> -------
>
> Run existing tests, including Windows build.
>
>
> Thanks,
>
> Andrei Sekretenko
>
>
Re: Review Request 70334: Extended the glog LogSink interface to be
able to log microseconds.
Posted by Andrei Sekretenko <as...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70334/
-----------------------------------------------------------
(Updated March 28, 2019, 6:27 p.m.)
Review request for mesos, Benno Evers, Greg Mann, and Joseph Wu.
Changes
-------
Added the ASF JIRA link.
Bugs: MESOS-9687
https://issues.apache.org/jira/browse/MESOS-9687
Repository: mesos
Description
-------
Extended the LogSink interface to be able to log microseconds.
This makes possible to solve a problem with modules implementing custom LogSink which currently log 000000 instead of microseconds.
This is a backport of this patch: https://github.com/google/glog/pull/441 to glog 0.3.3
Diffs
-----
3rdparty/glog-0.3.3.patch 8827f34e2b4589867d13160850b76c572c85ab06
Diff: https://reviews.apache.org/r/70334/diff/1/
Testing
-------
Run existing tests, including Windows build.
Thanks,
Andrei Sekretenko
Re: Review Request 70334: Extended the glog LogSink interface to be
able to log microseconds.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70334/#review214176
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70334]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 28, 2019, 2:12 p.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70334/
> -----------------------------------------------------------
>
> (Updated March 28, 2019, 2:12 p.m.)
>
>
> Review request for mesos, Benno Evers, Greg Mann, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Extended the LogSink interface to be able to log microseconds.
>
> This makes possible to solve a problem with modules implementing custom LogSink which currently log 000000 instead of microseconds.
>
> This is a backport of this patch: https://github.com/google/glog/pull/441 to glog 0.3.3
>
>
> Diffs
> -----
>
> 3rdparty/glog-0.3.3.patch 8827f34e2b4589867d13160850b76c572c85ab06
>
>
> Diff: https://reviews.apache.org/r/70334/diff/1/
>
>
> Testing
> -------
>
> Run existing tests, including Windows build.
>
>
> Thanks,
>
> Andrei Sekretenko
>
>