[GitHub] [solr] tboeghk commented on pull request #1118: [SOLR-16489] CaffeineCache puts thread into infinite loop

[GitBox <gi...@apache.org>]

tboeghk commented on PR #1118:
URL: https://github.com/apache/solr/pull/1118#issuecomment-1298315534

   @ben-manes we can confirm that your change with `3.1.2-SNAPSHOT` is working! 
   
   We removed our fix from the SolrCache and can confirm that no threads inside Solr are spinning anymore. We see the following exceptions in the Solr log (I had to remove some key details as they are sensitive):
   
   ```
   java.lang.IllegalStateException: An invalid state was detected that occurs if the key's equals or hashCode was modified while it resided in the map. This violation of the Map contract can lead to non-deterministic behavior (key: ((indexed_dimensions:dame^5000.0 | MatchNoDocsQuery("") | MatchNoDocsQuery("") | selling_points:dame^1000.0 | MatchNoDocsQuery("") | MatchNoDocsQuery("") | indexed_filter_values:dame^10000.0 | target_group:dame^50000.0 | [...] text:trigema^10000.0)~0.2)~3).
   at com.github.benmanes.caffeine.cache.Caffeine.requireState(Caffeine.java:204)
   at com.github.benmanes.caffeine.cache.BoundedLocalCache.requireIsAlive(BoundedLocalCache.java:288)
   at com.github.benmanes.caffeine.cache.BoundedLocalCache.lambda$put$8(BoundedLocalCache.java:2293)
   at java.base/java.util.concurrent.ConcurrentHashMap.computeIfPresent(ConcurrentHashMap.java:1852)
   at com.github.benmanes.caffeine.cache.BoundedLocalCache.put(BoundedLocalCache.java:2292)
   at com.github.benmanes.caffeine.cache.BoundedLocalCache.put(BoundedLocalCache.java:2212)
   at com.github.benmanes.caffeine.cache.LocalAsyncCache$AsMapView.put(LocalAsyncCache.java:689)
   at org.apache.solr.search.CaffeineCache.put(CaffeineCache.java:267)
   at org.apache.solr.search.SolrIndexSearcher.getDocListC(SolrIndexSearcher.java:1437)
   at org.apache.solr.search.SolrIndexSearcher.search(SolrIndexSearcher.java:596)
   [...]
   ```
   
   We'll check what exact `Query` implementation is inserted into the cache.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org