[jira] [Resolved] (AMQ-4190) Figure out what was intended with transactions and producer flow control for topics

["Christian Posta (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/AMQ-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Christian Posta resolved AMQ-4190.
----------------------------------

       Resolution: Fixed
    Fix Version/s: 5.8.0

Fix with r1418378
Increment the counter so that logging happens
                
> Figure out what was intended with transactions and producer flow control for topics
> -----------------------------------------------------------------------------------
>
>                 Key: AMQ-4190
>                 URL: https://issues.apache.org/jira/browse/AMQ-4190
>             Project: ActiveMQ
>          Issue Type: Improvement
>          Components: Broker
>            Reporter: Christian Posta
>            Priority: Minor
>             Fix For: 5.8.0
>
>
> in Topic#send it checks to see whether memory is full, whether producer flow control is enabled, and whether it should just block the producer, or block the connection. In the "else" clause on line 389, it will block the connection waiting for space. It tries to do something different if the context is in a transaction.. but what it's trying to do is not clear. It looks like it will do exactly the same thing as it would do if it would not be in a transaction. The extra code around (count > 2) doesn't seem like it will ever hit and the log message will never print. Maybe someone was adding functionality there, but didn't finish?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira