You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ariatosca.apache.org by mxmrlv <gi...@git.apache.org> on 2017/05/08 12:34:15 UTC

[GitHub] incubator-ariatosca pull request #126: Aria 160 tests fail spordically over ...

GitHub user mxmrlv opened a pull request:

    https://github.com/apache/incubator-ariatosca/pull/126

    Aria 160 tests fail spordically over parameter binding

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/incubator-ariatosca ARIA-160-Tests-fail-spordically-over-parameter-binding

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-ariatosca/pull/126.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #126
    
----
commit b9e5fb3c842463a18080b8cd63632cfa3d701412
Author: max-orlov <ma...@gigaspaces.com>
Date:   2017-05-07T12:13:09Z

    wip

commit cadc9e5520809f1e698612bdd4ba97e926a9bccc
Author: max-orlov <ma...@gigaspaces.com>
Date:   2017-05-08T11:46:58Z

    wip

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-ariatosca pull request #126: ARIA-160 tests fail spordically over ...

Posted by ran-z <gi...@git.apache.org>.
Github user ran-z commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/126#discussion_r115428189
  
    --- Diff: tests/helpers.py ---
    @@ -34,16 +33,17 @@ def get_service_template_uri(*args):
     
     
     class FilesystemDataHolder(object):
    -    _tmpfile = tempfile.NamedTemporaryFile('w')
     
         def _load(self):
    -        return json.load(open(self._tmpfile.name))
    +        return json.load(open(self._path))
     
         def _dump(self, value):
    -        return json.dump(value, open(self._tmpfile.name, 'w'))
    +        return json.dump(value, open(self._path, 'w'))
     
    -    def __init__(self):
    -        self.clear()
    +    def __init__(self, path, reset=False):
    +        self._path = path
    +        if reset or not os.path.exists(self._path) or open(self._path).read() == '':
    --- End diff --
    
    no closing of the file?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-ariatosca pull request #126: ARIA-160 tests fail spordically over ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-ariatosca/pull/126


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-ariatosca pull request #126: ARIA-160 tests fail spordically over ...

Posted by ran-z <gi...@git.apache.org>.
Github user ran-z commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/126#discussion_r115427438
  
    --- Diff: tests/helpers.py ---
    @@ -34,16 +33,17 @@ def get_service_template_uri(*args):
     
     
     class FilesystemDataHolder(object):
    -    _tmpfile = tempfile.NamedTemporaryFile('w')
     
         def _load(self):
    -        return json.load(open(self._tmpfile.name))
    +        return json.load(open(self._path))
     
         def _dump(self, value):
    -        return json.dump(value, open(self._tmpfile.name, 'w'))
    +        return json.dump(value, open(self._path, 'w'))
     
    -    def __init__(self):
    -        self.clear()
    +    def __init__(self, path, reset=False):
    --- End diff --
    
    move init to be the first method


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-ariatosca pull request #126: ARIA-160 tests fail spordically over ...

Posted by ran-z <gi...@git.apache.org>.
Github user ran-z commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/126#discussion_r115428827
  
    --- Diff: tests/orchestrator/context/test_operation.py ---
    @@ -97,31 +103,31 @@ def basic_workflow(graph, **_):
     
         execute(workflow_func=basic_workflow, workflow_context=ctx, executor=thread_executor)
     
    -    assert global_test_holder['ctx_name'] == context.operation.NodeOperationContext.__name__
    +    assert test_holder['ctx_name'] == context.operation.NodeOperationContext.__name__
    --- End diff --
    
    TBH i'd called it `dataholder` everywhere it says simply `holder` but up to you


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---