You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2019/07/17 19:01:44 UTC
[kudu-CR] [examples] Add a complete Nifi quickstart example
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13878
Change subject: [examples] Add a complete Nifi quickstart example
......................................................................
[examples] Add a complete Nifi quickstart example
This patchs adds a brief example using Apache Nifi to ingest data into Apache Kudu.
Change-Id: I71f3bc5898c15d7bc19cffb3a91b9efac3f6928b
---
M docs/quickstart.adoc
A examples/quickstart/nifi/README.adoc
A examples/quickstart/nifi/Random_User_Kudu.xml
3 files changed, 423 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/78/13878/1
--
To view, visit http://gerrit.cloudera.org:8080/13878
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I71f3bc5898c15d7bc19cffb3a91b9efac3f6928b
Gerrit-Change-Number: 13878
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [examples] Add a complete Nifi quickstart example
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13878 )
Change subject: [examples] Add a complete Nifi quickstart example
......................................................................
Patch Set 5: Code-Review+2
Went through the steps again, and json enabling aside, this is really snappy and easy to follow :+1:
--
To view, visit http://gerrit.cloudera.org:8080/13878
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I71f3bc5898c15d7bc19cffb3a91b9efac3f6928b
Gerrit-Change-Number: 13878
Gerrit-PatchSet: 5
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 30 Jul 2019 22:20:58 +0000
Gerrit-HasComments: No
[kudu-CR] [examples] Add a complete Nifi quickstart example
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13878 )
Change subject: [examples] Add a complete Nifi quickstart example
......................................................................
Patch Set 4:
(8 comments)
http://gerrit.cloudera.org:8080/#/c/13878/3/examples/quickstart/nifi/README.adoc
File examples/quickstart/nifi/README.adoc:
http://gerrit.cloudera.org:8080/#/c/13878/3/examples/quickstart/nifi/README.adoc@5
PS3, Line 5: rt
> Kudu Quickstart Container? Environment?
Done
http://gerrit.cloudera.org:8080/#/c/13878/3/examples/quickstart/nifi/README.adoc@33
PS3, Line 33: Docker
> nit: capitalize
Done
http://gerrit.cloudera.org:8080/#/c/13878/3/examples/quickstart/nifi/README.adoc@62
PS3, Line 62: uild()
> missing semicolon
Done
http://gerrit.cloudera.org:8080/#/c/13878/3/examples/quickstart/nifi/README.adoc@61
PS3, Line 61: KuduClient client =
: new KuduClientBuilder("kudu-master-1:7051,kudu-master-2:7151,kudu-master-3:7251").build();
:
: if(client.tableExists("random_user")) {
: client.deleteTable("random_user");
: }
:
: Schema schema = new Schema(Arrays.asList(
: new ColumnSchemaBuilder("ssn", Type.STRING).key(true).build(),
: new ColumnSchemaBuilder("firstName", Type.STRING).build(),
: new ColumnSchemaBuilder("lastName", Type.STRING).build(),
: new ColumnSchemaBuilder("email", Type.STRING).build())
: );
: CreateTableOptions tableOptions =
: new CreateTableOptions().setNumReplicas(3).addHashPartitions(Arrays.asList("ssn"), 4);
: client.createTable("random_user", schema, tableOptions);
> Maybe wrap this in {}s so we can copy-paste it? per https://stackoverflow.c
This should be copy-pasteable as is.
http://gerrit.cloudera.org:8080/#/c/13878/3/examples/quickstart/nifi/README.adoc@91
PS3, Line 91: `ssn`, `firstName`, `lastName`,
> nit: maybe put quotes around these?
Done
http://gerrit.cloudera.org:8080/#/c/13878/3/examples/quickstart/nifi/README.adoc@98
PS3, Line 98: Then
> Then
Done
http://gerrit.cloudera.org:8080/#/c/13878/3/examples/quickstart/nifi/README.adoc@102
PS3, Line 102: Once the template is added to the canvas you can start each processor by
: right-clicking each processor and selecting `Start`. You can also explore
: the configuration, queue contents, and more by right-clicking on each element.
:
> This is where I got stuck running through these steps. Was there another pr
It looks like I exported the template wrong. I updated it. There should be 5 processors total.
http://gerrit.cloudera.org:8080/#/c/13878/3/examples/quickstart/nifi/README.adoc@137
PS3, Line 137: le:
> nit: ... from within the Spark quickstart container
There isn't a Spark quickstart container because there wasn't a good Spark Docker image. I plan to make a good demo image at some point in the future, but the Spark quickstart actually runs Spark on the host machine.
--
To view, visit http://gerrit.cloudera.org:8080/13878
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I71f3bc5898c15d7bc19cffb3a91b9efac3f6928b
Gerrit-Change-Number: 13878
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 18 Jul 2019 14:14:46 +0000
Gerrit-HasComments: Yes
[kudu-CR] [examples] Add a complete Nifi quickstart example
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13878
to look at the new patch set (#2).
Change subject: [examples] Add a complete Nifi quickstart example
......................................................................
[examples] Add a complete Nifi quickstart example
This patchs adds a brief example using Apache Nifi
to ingest data into Apache Kudu.
Change-Id: I71f3bc5898c15d7bc19cffb3a91b9efac3f6928b
---
M docs/quickstart.adoc
A examples/quickstart/nifi/README.adoc
A examples/quickstart/nifi/Random_User_Kudu.xml
3 files changed, 423 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/78/13878/2
--
To view, visit http://gerrit.cloudera.org:8080/13878
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I71f3bc5898c15d7bc19cffb3a91b9efac3f6928b
Gerrit-Change-Number: 13878
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [examples] Add a complete Nifi quickstart example
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13878
to look at the new patch set (#3).
Change subject: [examples] Add a complete Nifi quickstart example
......................................................................
[examples] Add a complete Nifi quickstart example
This patchs adds a brief example using Apache Nifi
to ingest data into Apache Kudu.
Change-Id: I71f3bc5898c15d7bc19cffb3a91b9efac3f6928b
---
M docs/quickstart.adoc
A examples/quickstart/nifi/README.adoc
A examples/quickstart/nifi/Random_User_Kudu.xml
3 files changed, 423 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/78/13878/3
--
To view, visit http://gerrit.cloudera.org:8080/13878
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I71f3bc5898c15d7bc19cffb3a91b9efac3f6928b
Gerrit-Change-Number: 13878
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [examples] Add a complete Nifi quickstart example
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13878 )
Change subject: [examples] Add a complete Nifi quickstart example
......................................................................
Patch Set 3:
(8 comments)
http://gerrit.cloudera.org:8080/#/c/13878/3/examples/quickstart/nifi/README.adoc
File examples/quickstart/nifi/README.adoc:
http://gerrit.cloudera.org:8080/#/c/13878/3/examples/quickstart/nifi/README.adoc@5
PS3, Line 5: rt
Kudu Quickstart Container? Environment?
http://gerrit.cloudera.org:8080/#/c/13878/3/examples/quickstart/nifi/README.adoc@33
PS3, Line 33: docker
nit: capitalize
http://gerrit.cloudera.org:8080/#/c/13878/3/examples/quickstart/nifi/README.adoc@62
PS3, Line 62: uild()
missing semicolon
http://gerrit.cloudera.org:8080/#/c/13878/3/examples/quickstart/nifi/README.adoc@61
PS3, Line 61: KuduClient client =
: new KuduClientBuilder("kudu-master-1:7051,kudu-master-2:7151,kudu-master-3:7251").build()
:
: if(client.tableExists("random_user")) {
: client.deleteTable("random_user");
: }
:
: Schema schema = new Schema(Arrays.asList(
: new ColumnSchemaBuilder("ssn", Type.STRING).key(true).build(),
: new ColumnSchemaBuilder("firstName", Type.STRING).build(),
: new ColumnSchemaBuilder("lastName", Type.STRING).build(),
: new ColumnSchemaBuilder("email", Type.STRING).build())
: );
: CreateTableOptions tableOptions =
: new CreateTableOptions().setNumReplicas(3).addHashPartitions(Arrays.asList("ssn"), 4);
: client.createTable("random_user", schema, tableOptions);
Maybe wrap this in {}s so we can copy-paste it? per https://stackoverflow.com/a/53923372
http://gerrit.cloudera.org:8080/#/c/13878/3/examples/quickstart/nifi/README.adoc@91
PS3, Line 91: ssn, firstName, lastName, email
nit: maybe put quotes around these?
http://gerrit.cloudera.org:8080/#/c/13878/3/examples/quickstart/nifi/README.adoc@98
PS3, Line 98: Them
Then
http://gerrit.cloudera.org:8080/#/c/13878/3/examples/quickstart/nifi/README.adoc@102
PS3, Line 102: Once the template is added to the canvas you can start each processor by
: right-clicking each processor and selecting `Start`. You can also explore
: the configuration, queue contents, and more by right-clicking on each element.
:
This is where I got stuck running through these steps. Was there another processor I was supposed to add? The included template only has a PutKudu processor; seems it needs a source.
http://gerrit.cloudera.org:8080/#/c/13878/3/examples/quickstart/nifi/README.adoc@137
PS3, Line 137: le:
nit: ... from within the Spark quickstart container
--
To view, visit http://gerrit.cloudera.org:8080/13878
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I71f3bc5898c15d7bc19cffb3a91b9efac3f6928b
Gerrit-Change-Number: 13878
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 18 Jul 2019 04:40:43 +0000
Gerrit-HasComments: Yes
[kudu-CR] [examples] Add a complete Nifi quickstart example
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13878 )
Change subject: [examples] Add a complete Nifi quickstart example
......................................................................
Patch Set 4:
(3 comments)
Tried it out and it works! Pretty neat. Just noting the extra step here, in case anyone else wants to try this out.
http://gerrit.cloudera.org:8080/#/c/13878/4/examples/quickstart/nifi/README.adoc
File examples/quickstart/nifi/README.adoc:
http://gerrit.cloudera.org:8080/#/c/13878/4/examples/quickstart/nifi/README.adoc@92
PS4, Line 92: value
nit: field?
http://gerrit.cloudera.org:8080/#/c/13878/4/examples/quickstart/nifi/README.adoc@100
PS4, Line 100: r Kudu` template to the canvas.
We chatted about this on Slack, but we need to also manually enable the controller service before we're able to start the processes.
http://gerrit.cloudera.org:8080/#/c/13878/4/examples/quickstart/nifi/README.adoc@101
PS4, Line 101:
: Once the template is added to the canvas you can start each processor by
: right-clicking each processor and selecting `Start`. You can also explore
: the configuration, queue contents, and more by right-clicking on each element.
You can also click Start for all the processes en masse by clicking Start for the Process Group (in the "Operate" menu).
--
To view, visit http://gerrit.cloudera.org:8080/13878
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I71f3bc5898c15d7bc19cffb3a91b9efac3f6928b
Gerrit-Change-Number: 13878
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 18 Jul 2019 22:15:36 +0000
Gerrit-HasComments: Yes
[kudu-CR] [examples] Add a complete Nifi quickstart example
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13878 )
Change subject: [examples] Add a complete Nifi quickstart example
......................................................................
Patch Set 5: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/13878
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I71f3bc5898c15d7bc19cffb3a91b9efac3f6928b
Gerrit-Change-Number: 13878
Gerrit-PatchSet: 5
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sun, 28 Jul 2019 21:49:56 +0000
Gerrit-HasComments: No
[kudu-CR] [examples] Add a complete Nifi quickstart example
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13878
to look at the new patch set (#4).
Change subject: [examples] Add a complete Nifi quickstart example
......................................................................
[examples] Add a complete Nifi quickstart example
This patchs adds a brief example using Apache Nifi
to ingest data into Apache Kudu.
Change-Id: I71f3bc5898c15d7bc19cffb3a91b9efac3f6928b
---
M docs/quickstart.adoc
A examples/quickstart/nifi/README.adoc
A examples/quickstart/nifi/Random_User_Kudu.xml
M examples/quickstart/spark/README.adoc
4 files changed, 1,166 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/78/13878/4
--
To view, visit http://gerrit.cloudera.org:8080/13878
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I71f3bc5898c15d7bc19cffb3a91b9efac3f6928b
Gerrit-Change-Number: 13878
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [examples] Add a complete Nifi quickstart example
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13878
to look at the new patch set (#5).
Change subject: [examples] Add a complete Nifi quickstart example
......................................................................
[examples] Add a complete Nifi quickstart example
This patchs adds a brief example using Apache Nifi
to ingest data into Apache Kudu.
Change-Id: I71f3bc5898c15d7bc19cffb3a91b9efac3f6928b
---
M docs/quickstart.adoc
A examples/quickstart/nifi/README.adoc
A examples/quickstart/nifi/Random_User_Kudu.xml
M examples/quickstart/spark/README.adoc
4 files changed, 1,174 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/78/13878/5
--
To view, visit http://gerrit.cloudera.org:8080/13878
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I71f3bc5898c15d7bc19cffb3a91b9efac3f6928b
Gerrit-Change-Number: 13878
Gerrit-PatchSet: 5
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [examples] Add a complete Nifi quickstart example
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13878 )
Change subject: [examples] Add a complete Nifi quickstart example
......................................................................
[examples] Add a complete Nifi quickstart example
This patchs adds a brief example using Apache Nifi
to ingest data into Apache Kudu.
Change-Id: I71f3bc5898c15d7bc19cffb3a91b9efac3f6928b
Reviewed-on: http://gerrit.cloudera.org:8080/13878
Tested-by: Grant Henke <gr...@apache.org>
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M docs/quickstart.adoc
A examples/quickstart/nifi/README.adoc
A examples/quickstart/nifi/Random_User_Kudu.xml
M examples/quickstart/spark/README.adoc
4 files changed, 1,174 insertions(+), 7 deletions(-)
Approvals:
Grant Henke: Verified
Andrew Wong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/13878
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I71f3bc5898c15d7bc19cffb3a91b9efac3f6928b
Gerrit-Change-Number: 13878
Gerrit-PatchSet: 6
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [examples] Add a complete Nifi quickstart example
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has removed a vote on this change.
Change subject: [examples] Add a complete Nifi quickstart example
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/13878
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I71f3bc5898c15d7bc19cffb3a91b9efac3f6928b
Gerrit-Change-Number: 13878
Gerrit-PatchSet: 5
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [examples] Add a complete Nifi quickstart example
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13878 )
Change subject: [examples] Add a complete Nifi quickstart example
......................................................................
Patch Set 4:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/13878/4/examples/quickstart/nifi/README.adoc
File examples/quickstart/nifi/README.adoc:
http://gerrit.cloudera.org:8080/#/c/13878/4/examples/quickstart/nifi/README.adoc@92
PS4, Line 92: value
> nit: field?
Done
http://gerrit.cloudera.org:8080/#/c/13878/4/examples/quickstart/nifi/README.adoc@100
PS4, Line 100: r Kudu` template to the canvas.
> We chatted about this on Slack, but we need to also manually enable the con
I added a section on starting controller services.
http://gerrit.cloudera.org:8080/#/c/13878/4/examples/quickstart/nifi/README.adoc@101
PS4, Line 101:
: Once the template is added to the canvas you can start each processor by
: right-clicking each processor and selecting `Start`. You can also explore
: the configuration, queue contents, and more by right-clicking on each element.
> You can also click Start for all the processes en masse by clicking Start f
I noted this as an alternative.
--
To view, visit http://gerrit.cloudera.org:8080/13878
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I71f3bc5898c15d7bc19cffb3a91b9efac3f6928b
Gerrit-Change-Number: 13878
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 25 Jul 2019 13:42:37 +0000
Gerrit-HasComments: Yes