You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by tillrohrmann <gi...@git.apache.org> on 2017/03/22 14:26:41 UTC
[GitHub] flink pull request #3596: [FLINK-6155] Introduce an endpoint id for RpcEndpo...
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/3596
[FLINK-6155] Introduce an endpoint id for RpcEndpoints
An endpoint id allows to assign a unique name to a `RpcEndpoint`. This name can be used
to look up the rpc endpoint within the RpcService. In the case of the `AkkaRpcService` implementation, it corresponds to the actor name used for the `AkkaRpcActor`.
Remove component endpoint name methods from the `HighAvailabilityServices`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink addRpcActorName
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3596.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3596
----
commit c97a3f8f9796e5e1d25eae9d3a58666ded98d3d7
Author: Till Rohrmann <tr...@apache.org>
Date: 2017-03-22T08:09:02Z
[FLINK-6155] Introduce an endpoint id for RpcEndpoints
An endpoint id allows to assign a unique name to a RpcEndpoint. This name can be used
to look up the rpc endpoint within the RpcService.
Remove component endpoint name methods from the HighAvailabilityServices
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3596: [FLINK-6155] Introduce an endpoint id for RpcEndpoints
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/3596
Failing test case has just been fixed. Merging this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3596: [FLINK-6155] Introduce an endpoint id for RpcEndpoints
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/3596
Rebasing on the latest master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3596: [FLINK-6155] Introduce an endpoint id for RpcEndpoints
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/3596
I think I have to correct myself. In the general case, there might be the need to connect from the dispatcher component to `ResourceManager`. If the `ResourceManager` runs in a different process in standalone mode, then we have to be able to configure a fixed endpoint name, I think.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3596: [FLINK-6155] Introduce an endpoint id for RpcEndpo...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3596
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3596: [FLINK-6155] Introduce an endpoint id for RpcEndpoints
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3596
Good changes!
I think we could actually drop the explicit endpoint name from the `TaskExecutor` and always let it use a random name (as is the default when no explicit name is given). That would simplify the code a bit and it should work since the connection is always established by the `TaskExecutor` towards the `ResourceManager` and `JobManager`, but never the the other way around.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3596: [FLINK-6155] Introduce an endpoint id for RpcEndpoints
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/3596
Thanks for the review @StephanEwen. You're right that it should not be necessary to assign a name to the `TaskExecutor` and the `ResourceManager`. Will change it so that these components assign a random name.
Will then rebase the PR and once Travis gives green light, I will merge it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3596: [FLINK-6155] Introduce an endpoint id for RpcEndpoints
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/3596
Travis passed. Rebasing on the latest master. If travis passes again, then I will merge this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---