You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@ip-10-146-233-104.ec2.internal> on 2016/02/04 23:54:09 UTC

[kudu-CR] KUDU-966. Add tracing for some network-related functions

Hello Jean-Daniel Cryans,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/2051

to review the following change.

Change subject: KUDU-966. Add tracing for some network-related functions
......................................................................

KUDU-966. Add tracing for some network-related functions

My current theory is that KUDU-966 (slow calls to GetMasterRegistration)
is because this call ends up calling GetFQDN(), which calls getaddrinfo()
which might be slow in the case of a broken DNS setup.

This adds traces and LOG_SLOW_EXECUTION in the relevant code paths to help
diagnose such an issue. I also added traces to other non-perf-critical methods
in the same area of the socket/networking code.

Change-Id: Id4892eb9e7f256811504cb813e539107c765700d
---
M src/kudu/util/net/net_util.cc
M src/kudu/util/net/socket.cc
2 files changed, 19 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/51/2051/1
-- 
To view, visit http://gerrit.cloudera.org:8080/2051
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id4892eb9e7f256811504cb813e539107c765700d
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans