[jira] Issue Comment Edited: (SOLR-486) Support binary formats for QueryresponseWriter

["Noble Paul (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615067#action_12615067 ] 

noble.paul edited comment on SOLR-486 at 7/22/08 9:32 PM:
----------------------------------------------------------

bq.That's a good idea - but do we actually use any iterator or Iterable objects?

We do not have it now . But NamedListCodec has a public method called _writeIterator()_ . If we leave it like that somebody may actually use it. Iterators are used not to stream objects one by one and the current method implementation does not allow it.


      was (Author: noble.paul):
    bq.That's a good idea - but do we actually use any iterator or Iterable objects?

We do not have it now . But there is a method called _writeIterator()_ It is not good to leave it there with a list-like implementation. 
  
> Support binary formats for QueryresponseWriter
> ----------------------------------------------
>
>                 Key: SOLR-486
>                 URL: https://issues.apache.org/jira/browse/SOLR-486
>             Project: Solr
>          Issue Type: Improvement
>          Components: clients - java, search
>            Reporter: Noble Paul
>            Assignee: Yonik Seeley
>             Fix For: 1.3
>
>         Attachments: SOLR-486-iterator.patch, SOLR-486-iterator.patch, SOLR-486.patch, solr-486.patch, SOLR-486.patch, SOLR-486.patch, SOLR-486.patch, SOLR-486.patch, SOLR-486.patch, SOLR-486.patch, SOLR-486.patch, SOLR-486.patch
>
>
> QueryResponse writer only allows text data to be written.
> So it is not possible to implement a binary protocol . Create another interface which has a method 
> write(OutputStream os, SolrQueryRequest request, SolrQueryResponse response)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.