You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by shankarh <gi...@git.apache.org> on 2016/12/16 11:06:17 UTC
[GitHub] geode pull request #320: GEODE-1969 : oplog closed while writing to oplog wi...
GitHub user shankarh opened a pull request:
https://github.com/apache/geode/pull/320
GEODE-1969 : oplog closed while writing to oplog with gemfire.syncWrites=true
Moved the channel force call inside the sync block.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shankarh/geode feature/GEODE-1969
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/320.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #320
----
commit e7f2410fff54ad3486475155b2c872daae0a62ce
Author: shankar <sh...@ampool.io>
Date: 2016-12-16T11:01:54Z
GEODE-1969 : oplog closed while writing to oplog with gemfire.syncWrites=true
Moved the channel force call inside the sync block
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #320: GEODE-1969 : oplog closed while writing to oplog with gemf...
Posted by dschneider-pivotal <gi...@git.apache.org>.
Github user dschneider-pivotal commented on the issue:
https://github.com/apache/geode/pull/320
We need a unit test for GEODE-1969 that reproduces that failure. Then apply your fix and the unit test should pass. The unit test should be made part of this pull request. Hope fully Oplog will allow you to mock the channel. You might need to do some refactoring of Oplog to make it friendly to mocking a unit test. I think for this ticket most of the work will be in the unit test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #320: GEODE-1969 : oplog closed while writing to oplog wi...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/geode/pull/320
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #320: GEODE-1969 : oplog closed while writing to oplog with gemf...
Posted by shankarh <gi...@git.apache.org>.
Github user shankarh commented on the issue:
https://github.com/apache/geode/pull/320
Thanks @dschneider-pivotal for the review. Will add the unit test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #320: GEODE-1969 : oplog closed while writing to oplog with gemf...
Posted by dschneider-pivotal <gi...@git.apache.org>.
Github user dschneider-pivotal commented on the issue:
https://github.com/apache/geode/pull/320
After looking over this fix we decided that it is too simple to have a reasonable unit test.
I will pull it in
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---