You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/12/21 15:17:50 UTC

[GitHub] [camel-k] gansheer commented on a diff in pull request #3951: fix(controller): ensure `container.name` trait is used by the integration controller

gansheer commented on code in PR #3951:
URL: https://github.com/apache/camel-k/pull/3951#discussion_r1054505093


##########
pkg/controller/integration/monitor.go:
##########
@@ -407,9 +407,11 @@ func getIntegrationDigest(envs []corev1.EnvVar) string {
 	return ""
 }
 
-func findIntegrationContainer(spec corev1.PodSpec) *corev1.Container {
+// findIntegrationContainer find if present the integration container in the pod spec using the integration specifications.
+func findIntegrationContainer(environment *trait.Environment, spec corev1.PodSpec) *corev1.Container {
+	integrationContainerName := environment.GetIntegrationContainerName()

Review Comment:
   You are right, I will move the `integrationContainerName := environment.GetIntegrationContainerName()` code up to the `filterPodsByReadyStatus` method.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org