You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@subversion.apache.org by da...@apache.org on 2013/05/23 06:47:44 UTC

svn commit: r1485571 - /subversion/trunk/tools/dist/release.py

Author: danielsh
Date: Thu May 23 04:47:43 2013
New Revision: 1485571

URL: http://svn.apache.org/r1485571
Log:
Followup to r1485548:

* tools/dist/release.py
  (sign_candidates): Simplify use of 'subprocess'.

Modified:
    subversion/trunk/tools/dist/release.py

Modified: subversion/trunk/tools/dist/release.py
URL: http://svn.apache.org/viewvc/subversion/trunk/tools/dist/release.py?rev=1485571&r1=1485570&r2=1485571&view=diff
==============================================================================
--- subversion/trunk/tools/dist/release.py (original)
+++ subversion/trunk/tools/dist/release.py Thu May 23 04:47:43 2013
@@ -463,9 +463,8 @@ def sign_candidates(args):
     def sign_file(filename):
         asc_file = open(filename + '.asc', 'a')
         logging.info("Signing %s" % filename)
-        proc = subprocess.Popen(['gpg', '-ba', '-o', '-', filename],
-                              stdout=asc_file)
-        proc.wait()
+        proc = subprocess.check_call(['gpg', '-ba', '-o', '-', filename],
+                                     stdout=asc_file)
         asc_file.close()
 
     if args.target: