Re: [PATCH] Improve error handling in svn_ra_serf__replay_range()

[vijay <vi...@collab.net>]

On Thursday 20 December 2012 07:52 PM, vijay wrote:
>>
>> I note that 'svnadmin create r; svnrdump dump file://$PWD/r/foo' does
>> not error --- maybe your patch fixes that too?
>
> The attached patch fixes this issue. This patch is different from the
> previous versions.
>
> We have to error out immediately if we do 'svnrdump dump
> <non-existent-url>', right?


Is it wrong to fix the issue in this way?

Thanks & Regards,
Vijayaguru


>
> I could notice a change in behavior after this patch is applied.
>
> The single revision/first revision dump is driven with the repos root
> URL using update mechanism(svn_ra_do_update()). So the following
> commands were succeeding though the dump target URL is not there in HEAD.
>
> [[[
> URL=http://svn.apache.org/repos/asf/subversion/trunk/contrib/server-side/mod_setlocale
>
>
> $ svnrdump dump $URL -r1232154 > /dev/null
> * Dumped revision 1232154.
>
> $ svnrdump dump $URL -r1232155 > /dev/null
> * Dumped revision 1232155.
> ]]]
>
> After this patch applied, the above commands will fail. Is this behavior
> correct?
>
> svnrdump should support peg-revisions to take dump of paths not present
> in HEAD.
>
> Thanks & Regards,
> Vijayaguru
>
>
>>
>>>
>>> +  expected_dump_fail_err_re = "svnrdump: E160013: '.*' path not found"
>>> +
>>> +  # Returns error as in issue #4100.
>>> +  svntest.actions.run_and_verify_svnrdump(None,
>>> svntest.verify.AnyOutput,
>>> +                                          expected_dump_fail_err_re,
>>> 1, '-q',
>>> +                                          'dump', E_url)
>>> +
>>> +
>>> +#----------------------------------------------------------------------
>>> +
>>> +
>>>
>>> ########################################################################
>>>   # Run the tests
>>>
>>
>

RE: [PATCH] Improve error handling in svn_ra_serf__replay_range()

[Gavin Baumanis <ga...@thespidernet.com>]

Ping.
This submission has received no new comments.

Gavin.

> -----Original Message-----
> From: Daniel Shahaf [mailto:danielsh@elego.de]
> Sent: Tuesday, 8 January 2013 15:49
> To: vijay
> Cc: Philip Martin; Subversion Development
> Subject: Re: [PATCH] Improve error handling in svn_ra_serf__replay_range()
> 
> vijay wrote on Tue, Jan 08, 2013 at 15:30:46 +0530:
> > On Thursday 20 December 2012 07:52 PM, vijay wrote:
> >>>
> >>> I note that 'svnadmin create r; svnrdump dump file://$PWD/r/foo'
> >>> does not error --- maybe your patch fixes that too?
> >>
> >> The attached patch fixes this issue. This patch is different from the
> >> previous versions.
> >>
> >> We have to error out immediately if we do 'svnrdump dump
> >> <non-existent-url>', right?
> >
> >
> > Is it wrong to fix the issue in this way?
> 
> I haven't had time to look into it.

Re: [PATCH] Improve error handling in svn_ra_serf__replay_range()

[Daniel Shahaf <da...@elego.de>]

vijay wrote on Tue, Jan 08, 2013 at 15:30:46 +0530:
> On Thursday 20 December 2012 07:52 PM, vijay wrote:
>>>
>>> I note that 'svnadmin create r; svnrdump dump file://$PWD/r/foo' does
>>> not error --- maybe your patch fixes that too?
>>
>> The attached patch fixes this issue. This patch is different from the
>> previous versions.
>>
>> We have to error out immediately if we do 'svnrdump dump
>> <non-existent-url>', right?
>
>
> Is it wrong to fix the issue in this way?

I haven't had time to look into it.