[GitHub] [incubator-nuttx] hotislandn commented on pull request #3001: arch:riscv64:basic porting for C906.

[GitBox <gi...@apache.org>]

hotislandn commented on pull request #3001:
URL: https://github.com/apache/incubator-nuttx/pull/3001#issuecomment-793130539


   > Hi @hotislandn thank you very much for adding support on NuttX for Allwinner C906 !
   > 
   > I think you missed to run nxstyle/checkpatch on some files:
   > 
   > ```
   > Warning: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/arch/risc-v/include/c906/chip.h:24:1: warning: #include outside of 'Included Files' section
   > Warning: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/arch/risc-v/include/c906/chip.h:25:1: warning: #include outside of 'Included Files' section
   > Warning: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/arch/risc-v/include/c906/chip.h:26:1: warning: #include outside of 'Included Files' section
   > Warning: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/arch/risc-v/include/c906/chip.h:28:1: warning: #include outside of 'Included Files' section
   > Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/arch/risc-v/src/c906/c906_idle.c:2:1: error: Too many whitespaces before relative file path
   > Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/arch/risc-v/src/c906/c906_lowputc.c:85:63: error: Left bracket not on separate line
   > Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/arch/risc-v/src/c906/c906_lowputc.c:85:4: error: Bad alignment
   > Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/arch/risc-v/src/c906/c906_lowputc.h:33:3: error: Invalid section for this file type
   > Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/arch/risc-v/src/c906/c906_serial.c:263:83: error: Long line found
   > Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/arch/risc-v/src/c906/c906_serial.c:310:79: error: Long line found
   > Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/arch/risc-v/src/c906/c906_start.c:81:6: error: Missing whitespace after keyword
   > Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/boards/risc-v/c906/smartl-c906/include/board.h:2:1: error: Relative file path does not match actual file
   > Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/boards/risc-v/c906/smartl-c906/src/c906_leds.c:31:1: error: Too many blank lines
   > Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/boards/risc-v/c906/smartl-c906/src/c906_leds.c:38:1: error: Blank line follows left brace
   > Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/boards/risc-v/c906/smartl-c906/src/c906_leds.c:39:1: error: Blank line precedes right brace at line
   > Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/boards/risc-v/c906/smartl-c906/src/c906_leds.c:43:1: error: Blank line follows left brace
   > Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/boards/risc-v/c906/smartl-c906/src/c906_leds.c:44:1: error: Blank line precedes right brace at line
   > Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/boards/risc-v/c906/smartl-c906/src/c906_leds.c:48:1: error: Blank line follows left brace
   > Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/boards/risc-v/c906/smartl-c906/src/c906_leds.c:49:1: error: Blank line precedes right brace at line
   > Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/boards/risc-v/c906/smartl-c906/src/smartl-c906.h:2:1: error: Relative file path does not match actual file
   > Error: Process completed with exit code 1.
   > ```
   
   Hi Acassis,
   
   Yes, I failed to do this which lead to those style check failures. I will update them soon.
   BTW, for another 2 build errors, which caused by the wrong toolchain used for C906, it needs a specific toolchain from T-HEAD.
   How to add this dedicated toolchain for the C906 build, or we have to use the standard toolchain but lose any vendor ISA extensions?
   Thanks a lot!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org