[GitHub] [incubator-nuttx] patacongo commented on pull request #3205: sim: do not exit simulator on up_assert (just let the task exit)

[GitBox <gi...@apache.org>]

patacongo commented on pull request #3205:
URL: https://github.com/apache/incubator-nuttx/pull/3205#issuecomment-808817692


   The is some brief overview here: 
   https://github.com/apache/incubator-nuttx/blob/master/boards/sim/sim/sim/README.txt#L152
   
   The simulator blob, nuttx.rel, is created here: 
   https://github.com/apache/incubator-nuttx/blob/master/arch/sim/src/Makefile#L318 
   .  It is created from the usual set of NuttX libraries, RELLIBS (plus 
   REQUIREDOBJS).
   
   Here the symbols are renamed: 
   https://github.com/apache/incubator-nuttx/blob/master/arch/sim/src/Makefile#L319
   
   The final executable with the host blob is created here: 
   https://github.com/apache/incubator-nuttx/blob/master/arch/sim/src/Makefile#L325 
   .  This is based on the sources in HOSTSRCS.
   
   On 3/27/2021 3:46 PM, Matias N. wrote:
   >
   > ***@***.**** commented on this pull request.
   >
   > ------------------------------------------------------------------------
   >
   > In arch/sim/src/sim/up_head.c 
   > <https://github.com/apache/incubator-nuttx/pull/3205#discussion_r602795960>:
   >
   > > @@ -125,11 +125,6 @@ void up_assert(const char *filename, int line)
   >   #ifdef CONFIG_BOARD_CRASHDUMP
   >     board_crashdump(sim_getsp(), this_task(), filename, line);
   >   #endif
   > -
   > -  /* Exit the simulation */
   > -
   > -  g_exitcode = EXIT_FAILURE;
   > -  longjmp(g_simabort, 1);
   >   }
   >
   > I don't think I'm familiar with the sim enough to do those changes 
   > correctly. I will take a look later.
   >
   > —
   > You are receiving this because you commented.
   > Reply to this email directly, view it on GitHub 
   > <https://github.com/apache/incubator-nuttx/pull/3205#discussion_r602795960>, 
   > or unsubscribe 
   > <https://github.com/notifications/unsubscribe-auth/ABFUG6XNQIJVD4VXBNIBRN3TFZG4ZANCNFSM4Z5HOXIQ>.
   >
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org