You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/04/03 13:39:27 UTC
[GitHub] [incubator-nuttx] jerpelea opened a new pull request #708: arch:
arm: sxd56xx: nxstyle fixes
jerpelea opened a new pull request #708: arch: arm: sxd56xx: nxstyle fixes
URL: https://github.com/apache/incubator-nuttx/pull/708
Fix nxstyle complains
Signed-off-by: Alin Jerpelea <al...@sony.com>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #708: arch:
arm: sxd56xx: nxstyle fixes
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #708: arch: arm: sxd56xx: nxstyle fixes
URL: https://github.com/apache/incubator-nuttx/pull/708#issuecomment-609709498
@jerpelea but there are other error too:
1. No indentation line
2. Operator/assignment must be preceded with whitespace
We can fix these before merge, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] jerpelea commented on issue #708: arch: arm:
sxd56xx: nxstyle fixes
Posted by GitBox <gi...@apache.org>.
jerpelea commented on issue #708: arch: arm: sxd56xx: nxstyle fixes
URL: https://github.com/apache/incubator-nuttx/pull/708#issuecomment-609585096
@acassis some of the CamelCases are part of teh API and have to stay as they are for now since they are used downstream in the SDK. I will progressively fix them but now is not possible to fix them all.
If there are no other complains please merge this PR so that I can submit the next one
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] jerpelea edited a comment on issue #708: arch:
arm: sxd56xx: nxstyle fixes
Posted by GitBox <gi...@apache.org>.
jerpelea edited a comment on issue #708: arch: arm: sxd56xx: nxstyle fixes
URL: https://github.com/apache/incubator-nuttx/pull/708#issuecomment-609712311
@xiaoxiang781216 done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] acassis commented on issue #708: arch: arm:
sxd56xx: nxstyle fixes
Posted by GitBox <gi...@apache.org>.
acassis commented on issue #708: arch: arm: sxd56xx: nxstyle fixes
URL: https://github.com/apache/incubator-nuttx/pull/708#issuecomment-609083266
Please fix the CamelCases. We already fixed some of Sony CamelCase, but there are many more to be fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] jerpelea edited a comment on issue #708: arch:
arm: sxd56xx: nxstyle fixes
Posted by GitBox <gi...@apache.org>.
jerpelea edited a comment on issue #708: arch: arm: sxd56xx: nxstyle fixes
URL: https://github.com/apache/incubator-nuttx/pull/708#issuecomment-609585096
@acassis some of the CamelCases are part of the API and have to stay as they are for now since they are used downstream in the SDK. I will progressively fix them but now is not possible to fix them all.
If there are no other complains please merge this PR so that I can submit the next one
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #708: arch:
arm: sxd56xx: nxstyle fixes
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #708: arch: arm: sxd56xx: nxstyle fixes
URL: https://github.com/apache/incubator-nuttx/pull/708
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] jerpelea commented on issue #708: arch: arm:
sxd56xx: nxstyle fixes
Posted by GitBox <gi...@apache.org>.
jerpelea commented on issue #708: arch: arm: sxd56xx: nxstyle fixes
URL: https://github.com/apache/incubator-nuttx/pull/708#issuecomment-609712311
I am taking a look now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services