You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@subversion.apache.org by Daniel Shahaf <d....@daniel.shahaf.name> on 2018/10/31 06:54:35 UTC

Re: svn commit: r1845312 - /subversion/trunk/tools/dist/backport.pl

Good morning Ruediger,

rpluem@apache.org wrote on Wed, 31 Oct 2018 06:45 +0000:
> Adjust grep syntax to be able to run it with Perl 5.16.3.
> 
> * tools/dist/backport.pl
>   (vote) Adjust grep syntax to be able to run it with Perl 5.16.3.
> 
> [D:other] backport.pl: Make it run with Perl 5.16.3.

Thanks for committing the fix.

In CHANGES, "developer-visible" means "visible to API consumers".
backport.pl, however, is not visible to API consumers; it's only used
by developers working on Subversion itself.  As such, this changelog
line, although syntactically correct, is wrong. The correct line would
be [c:skip].

I'll go ahead and make it so.

Cheers,

Daniel

Re: svn commit: r1845312 - /subversion/trunk/tools/dist/backport.pl

Posted by Ruediger Pluem <rp...@apache.org>.


On 2018/10/31 06:54:35, Daniel Shahaf <d....@daniel.shahaf.name> wrote: 
> Good morning Ruediger,
> 
> rpluem@apache.org wrote on Wed, 31 Oct 2018 06:45 +0000:
> > Adjust grep syntax to be able to run it with Perl 5.16.3.
> > 
> > * tools/dist/backport.pl
> >   (vote) Adjust grep syntax to be able to run it with Perl 5.16.3.
> > 
> > [D:other] backport.pl: Make it run with Perl 5.16.3.
> 
> Thanks for committing the fix.
> 
> In CHANGES, "developer-visible" means "visible to API consumers".
> backport.pl, however, is not visible to API consumers; it's only used
> by developers working on Subversion itself.  As such, this changelog
> line, although syntactically correct, is wrong. The correct line would
> be [c:skip].

Ahh, sorry. Makes sense. I misunderstood the comments in release.py regarding D:

> 
> I'll go ahead and make it so.

Thanks

Regards

Rüdiger