You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by ti...@apache.org on 2020/06/21 21:00:37 UTC
[maven-surefire] branch master updated: [SUREFIRE-1800]
SurefireForkChannel: use LoopbackAddress
This is an automated email from the ASF dual-hosted git repository.
tibordigana pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-surefire.git
The following commit(s) were added to refs/heads/master by this push:
new 1cf41ad [SUREFIRE-1800] SurefireForkChannel: use LoopbackAddress
1cf41ad is described below
commit 1cf41ad71732db3b2c6ba048f202810e778399a3
Author: Falko Modler <fa...@users.noreply.github.com>
AuthorDate: Sun Jun 21 02:36:31 2020 +0200
[SUREFIRE-1800] SurefireForkChannel: use LoopbackAddress
---
.../apache/maven/plugin/surefire/extensions/SurefireForkChannel.java | 2 +-
.../java/org/apache/maven/surefire/extensions/ForkChannelTest.java | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/extensions/SurefireForkChannel.java b/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/extensions/SurefireForkChannel.java
index 5049dcf..639944e 100644
--- a/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/extensions/SurefireForkChannel.java
+++ b/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/extensions/SurefireForkChannel.java
@@ -86,7 +86,7 @@ final class SurefireForkChannel extends ForkChannel
super( arguments );
server = open( withThreadPool( THREAD_POOL ) );
setTrueOptions( SO_REUSEADDR, TCP_NODELAY, SO_KEEPALIVE );
- InetAddress ip = InetAddress.getLocalHost();
+ InetAddress ip = InetAddress.getLoopbackAddress();
server.bind( new InetSocketAddress( ip, 0 ), 1 );
InetSocketAddress localAddress = (InetSocketAddress) server.getLocalAddress();
localHost = localAddress.getHostString();
diff --git a/maven-surefire-common/src/test/java/org/apache/maven/surefire/extensions/ForkChannelTest.java b/maven-surefire-common/src/test/java/org/apache/maven/surefire/extensions/ForkChannelTest.java
index fec93c8..16eb3a5 100644
--- a/maven-surefire-common/src/test/java/org/apache/maven/surefire/extensions/ForkChannelTest.java
+++ b/maven-surefire-common/src/test/java/org/apache/maven/surefire/extensions/ForkChannelTest.java
@@ -108,7 +108,7 @@ public class ForkChannelTest
assertThat( channel.getCountdownCloseablePermits() )
.isEqualTo( 3 );
- String localHost = InetAddress.getLocalHost().getHostAddress();
+ String localHost = InetAddress.getLoopbackAddress().getHostAddress();
assertThat( channel.getForkNodeConnectionString() )
.startsWith( "tcp://" + localHost + ":" )
.isNotEqualTo( "tcp://" + localHost + ":" )
@@ -185,7 +185,7 @@ public class ForkChannelTest
@Override
public void run()
{
- try ( Socket socket = new Socket( InetAddress.getLocalHost().getHostAddress(), port ) )
+ try ( Socket socket = new Socket( InetAddress.getLoopbackAddress().getHostAddress(), port ) )
{
socket.getOutputStream().write( sessionId.getBytes( US_ASCII ) );
byte[] data = new byte[128];