You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/08/08 16:47:42 UTC
[GitHub] [camel-website] AemieJ opened a new pull request #453: feat: provide a modified neat card layout for community & docs
AemieJ opened a new pull request #453:
URL: https://github.com/apache/camel-website/pull/453
### Layout Design Change
The card layout design for the documentation and community page seemed plain compared to the other pages of the website. Thus, included rounded background over the links for the pages and rounded border over the section to provide the card-like layout. This will fit with the new design for the frontpage in PR #442 as well.
#### Community Page
### Documentation Page
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-website] AemieJ removed a comment on pull request #453: feat: provide a modified neat card layout for community & docs
Posted by GitBox <gi...@apache.org>.
AemieJ removed a comment on pull request #453:
URL: https://github.com/apache/camel-website/pull/453#issuecomment-671077929
@aashnajena I agree with the change of width with respect to the context itself, I will make those changes.
Other than that, for the documentation page, I temporarily included them within one button as I feel buttons with the text would be highly clustered. For that, I was planning on including icons on it, and a custom tooltip on hover but I needed opinions on that change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-website] aashnajena commented on pull request #453: feat: provide a modified neat card layout for community & docs
Posted by GitBox <gi...@apache.org>.
aashnajena commented on pull request #453:
URL: https://github.com/apache/camel-website/pull/453#issuecomment-671046059
This looks fine on the community page, I'd prefer if we make the button's width just enough to fit the content. For docs, we have three different links per card, and putting them all in the same button makes it look like one combined link. We can have 3 separate buttons (there's an image on #370 showing how that might look). But we might have to think about how it will look on smaller screens because 3 buttons take up a lot of space.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-website] AemieJ edited a comment on pull request #453: feat: provide a modified neat card layout for community & docs
Posted by GitBox <gi...@apache.org>.
AemieJ edited a comment on pull request #453:
URL: https://github.com/apache/camel-website/pull/453#issuecomment-671077929
@aashnajena I agree with the change of width with respect to the context itself, I will make those changes.
Other than that, for the documentation page, I temporarily included them within one button as I feel buttons with the text would be highly clustered. For that, I was planning on including icons on it, and a custom tooltip on hover but I needed opinions on that change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-website] aashnajena commented on pull request #453: feat: provide a modified neat card layout for community & docs
Posted by GitBox <gi...@apache.org>.
aashnajena commented on pull request #453:
URL: https://github.com/apache/camel-website/pull/453#issuecomment-671046681
For community page, this looks better to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-website] zregvart merged pull request #453: CAMEL-15392: provide a modified neat card layout for community & docs
Posted by GitBox <gi...@apache.org>.
zregvart merged pull request #453:
URL: https://github.com/apache/camel-website/pull/453
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-website] AemieJ commented on pull request #453: feat: provide a modified neat card layout for community & docs
Posted by GitBox <gi...@apache.org>.
AemieJ commented on pull request #453:
URL: https://github.com/apache/camel-website/pull/453#issuecomment-671077929
@aashnajena I agree with the change of width with respect to the context itself, I will make those changes.
Other than that, for the documentation page, I temporarily included them within one button as I feel buttons with the text would be highly clustered. For that, I was planning on including icons on it, and a custom tooltip on hover but I needed opinions on that change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org