You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/10/19 17:01:06 UTC

[GitHub] [geode-native] pivotal-jbarrett commented on a change in pull request #884: GEODE-9741: Use v142 Toolchain in Visual Studio 2019 CI Pipeline

pivotal-jbarrett commented on a change in pull request #884:
URL: https://github.com/apache/geode-native/pull/884#discussion_r732072002



##########
File path: packer/windows/install-vs-2019-community.ps1
##########
@@ -21,22 +21,93 @@ write-host "Installing Visual Studio 2019 Community..."
 
 $args = @('--add Microsoft.VisualStudio.Component.CoreEditor',
           '--add Microsoft.VisualStudio.Workload.CoreEditor',
+          '--add Microsoft.NetCore.Component.Runtime.5.0',
+          '--add Microsoft.NetCore.Component.Runtime.3.1',
+          '--add Microsoft.NetCore.Component.SDK',
+          '--add Microsoft.VisualStudio.Component.NuGet',
           '--add Microsoft.Net.Component.4.6.1.TargetingPack',
           '--add Microsoft.VisualStudio.Component.Roslyn.Compiler',
+          '--add Microsoft.VisualStudio.Component.Roslyn.LanguageServices',
+          '--add Microsoft.VisualStudio.Component.FSharp',
+          '--add Microsoft.ComponentGroup.ClickOnce.Publish',
+          '--add Microsoft.NetCore.Component.DevelopmentTools',
+          '--add Microsoft.VisualStudio.Component.FSharp.WebTemplates',
+          '--add Microsoft.VisualStudio.ComponentGroup.WebToolsExtensions',
+          '--add Microsoft.VisualStudio.Component.DockerTools',
+          '--add Microsoft.NetCore.Component.Web',
           '--add Microsoft.Net.Component.4.8.SDK',
+          '--add Microsoft.Net.Component.4.7.2.TargetingPack',
+          '--add Microsoft.Net.ComponentGroup.DevelopmentPrerequisites',
+          '--add Microsoft.VisualStudio.Component.TypeScript.4.3',
+          '--add Microsoft.VisualStudio.Component.JavaScript.TypeScript',
+          '--add Microsoft.VisualStudio.Component.JavaScript.Diagnostics',
           '--add Microsoft.Component.MSBuild',
           '--add Microsoft.VisualStudio.Component.TextTemplating',
+          '--add Component.Microsoft.VisualStudio.RazorExtension',
+          '--add Microsoft.VisualStudio.Component.IISExpress',
+          '--add Microsoft.VisualStudio.Component.SQL.ADAL',
+          '--add Microsoft.VisualStudio.Component.SQL.LocalDB.Runtime',
+          '--add Microsoft.VisualStudio.Component.Common.Azure.Tools',
+          '--add Microsoft.VisualStudio.Component.SQL.CLR',
+          '--add Microsoft.VisualStudio.Component.MSODBC.SQL',
+          '--add Microsoft.VisualStudio.Component.MSSQL.CMDLnUtils',
+          '--add Microsoft.VisualStudio.Component.ManagedDesktop.Core',
           '--add Microsoft.Net.Component.4.5.2.TargetingPack',
+          '--add Microsoft.Net.Component.4.5.TargetingPack',
+          '--add Microsoft.VisualStudio.Component.SQL.SSDT',
+          '--add Microsoft.VisualStudio.Component.SQL.DataSources',
+          '--add Component.Microsoft.Web.LibraryManager',
+          '--add Component.Microsoft.WebTools.BrowserLink.WebLivePreview',
+          '--add Microsoft.VisualStudio.ComponentGroup.Web',
+          '--add Microsoft.VisualStudio.Component.Web',
+          '--add Microsoft.VisualStudio.ComponentGroup.Web.Client',
+          '--add Microsoft.Net.Component.4.TargetingPack',
+          '--add Microsoft.Net.Component.4.5.1.TargetingPack',
+          '--add Microsoft.Net.Component.4.6.TargetingPack',
+          '--add Microsoft.Net.ComponentGroup.TargetingPacks.Common',
+          '--add Component.Microsoft.VisualStudio.Web.AzureFunctions',
+          '--add Microsoft.VisualStudio.ComponentGroup.AzureFunctions',
+          '--add Microsoft.VisualStudio.Component.Azure.Compute.Emulator',
+          '--add Microsoft.VisualStudio.Component.Azure.Storage.Emulator',
+          '--add Microsoft.VisualStudio.Component.Azure.ClientLibs',
+          '--add Microsoft.VisualStudio.Component.Azure.AuthoringTools',
+          '--add Microsoft.VisualStudio.Component.CloudExplorer',
+          '--add Microsoft.VisualStudio.ComponentGroup.Web.CloudTools',
+          '--add Microsoft.VisualStudio.Component.DiagnosticTools',
+          '--add Microsoft.VisualStudio.Component.EntityFramework',
+          '--add Microsoft.VisualStudio.Component.AspNet45',
+          '--add Microsoft.VisualStudio.Component.AppInsights.Tools',
+          '--add Microsoft.VisualStudio.Component.WebDeploy',
+          '--add Microsoft.VisualStudio.Component.Debugger.JustInTime',
+          '--add Component.Microsoft.VisualStudio.LiveShare',
+          '--add Microsoft.VisualStudio.Component.WslDebugging',
           '--add Microsoft.VisualStudio.Component.IntelliCode',
+          '--add Microsoft.VisualStudio.Workload.NetWeb',
+          '--add Microsoft.Component.PythonTools',
+          '--add Component.CPython3.x64',
           '--add Microsoft.VisualStudio.Component.VC.CoreIde',
+          '--add Microsoft.VisualStudio.Component.VC.Tools.x86.x64',
+          '--add Microsoft.VisualStudio.Component.Graphics.Tools',
+          '--add Microsoft.VisualStudio.Component.VC.DiagnosticTools',
+          '--add Microsoft.VisualStudio.Component.Windows10SDK.19041',

Review comment:
       Why are we installing all these additional and unnecessary tooling in the image? This has caused issues in the past with the image builds taking very long or hanging. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org