You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/02/05 12:42:51 UTC
[GitHub] [airflow] kaxil opened a new pull request #14099: Fix Commands to install Airflow in docker/install_airflow.sh
kaxil opened a new pull request #14099:
URL: https://github.com/apache/airflow/pull/14099
It was trying to run the following command and failing
```
pip install apache-airflow[amazon. google]2.0.0rc2
```
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil edited a comment on pull request #14099: Fix Commands to install Airflow in docker/install_airflow.sh
Posted by GitBox <gi...@apache.org>.
kaxil edited a comment on pull request #14099:
URL: https://github.com/apache/airflow/pull/14099#issuecomment-774151382
> Actually we should revert it it was as intended. AIRFLOW_INSTALL_VERSION was supposed to be the "==2.0.0rc2" in this case (
>
> This is on purpose done this way, so that you could for example specify "<3.0.0" if you want to use it in your CI pipeline to build lastest 2.* image.
>
> See the docs: https://github.com/apache/airflow/blob/master/docs/apache-airflow/production-deployment.rst and plenty of examples.
>
> AIRFLOW_INSTALL_VERSION | | Optional - might be used for package installation of different Airflow version for example"==2.0.0". For consistency, you should also set`AIRFLOW_VERSION` to the same value AIRFLOW_VERSION is embedded as label in the image created.
In that case, we need to still fix it somewhere else coz the dockerbuild step here: https://github.com/apache/airflow/blob/master/dev/README_RELEASE_AIRFLOW.md#optional---manually-prepare-production-docker-image fails with "pip install failure" coz it used `pip install apache-airflow[amazon,google]2.0.0rc2
` @potiuk
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #14099: Fix Commands to install Airflow in docker/install_airflow.sh
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #14099:
URL: https://github.com/apache/airflow/pull/14099#issuecomment-774151382
> Actually we should revert it it was as intended. AIRFLOW_INSTALL_VERSION was supposed to be the "==2.0.0rc2" in this case (
>
> This is on purpose done this way, so that you could for example specify "<3.0.0" if you want to use it in your CI pipeline to build lastest 2.* image.
>
> See the docs: https://github.com/apache/airflow/blob/master/docs/apache-airflow/production-deployment.rst and plenty of examples.
>
> AIRFLOW_INSTALL_VERSION | | Optional - might be used for package installation of different Airflow version for example"==2.0.0". For consistency, you should also set`AIRFLOW_VERSION` to the same value AIRFLOW_VERSION is embedded as label in the image created.
In that case, we need to still fix it somewhere else coz the dockerbuild step here: https://github.com/apache/airflow/blob/master/dev/README_RELEASE_AIRFLOW.md#optional---manually-prepare-production-docker-image fails with "pip install failure" coz it used `pip install apache-airflow[amazon,google]2.0.0rc2
`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #14099: Fix Commands to install Airflow in docker/install_airflow.sh
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #14099:
URL: https://github.com/apache/airflow/pull/14099
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #14099: Fix Commands to install Airflow in docker/install_airflow.sh
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #14099:
URL: https://github.com/apache/airflow/pull/14099#issuecomment-774148558
Actually we should revert it it was as intended. AIRFLOW_INSTALL_VERSION was supposed to be the "==2.0.0rc2" in this case (
This is on purpose done this way, so that you could for example specify "<3.0.0" if you want to use it in your CI pipeline to build lastest 2.* image.
See the docs: https://github.com/apache/airflow/blob/master/docs/apache-airflow/production-deployment.rst and plenty of examples.
AIRFLOW_INSTALL_VERSION | | Optional - might be used for package installation of different Airflow version for example"==2.0.0". For consistency, you should also set``AIRFLOW_VERSION`` to the same value AIRFLOW_VERSION is embedded as label in the image created.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org