You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2021/04/23 04:00:10 UTC
[GitHub] [kylin] liukun4515 opened a new pull request #1644: [KYLIN-4982]add rule for submit build job: forbid submitting appending segment in the lambda stream cube
liukun4515 opened a new pull request #1644:
URL: https://github.com/apache/kylin/pull/1644
## Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
## Types of changes
What types of changes does your code introduce to Kylin?
_Put an `x` in the boxes that apply_
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [ ] I have create an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail
- [ ] Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
- [ ] Compiling and unit tests pass locally with my changes
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] If this change need a document change, I will prepare another pr against the `document` branch
- [ ] Any dependent changes have been merged
## Further comments
If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] liukun4515 commented on a change in pull request #1644: [KYLIN-4983]add rule for submit build job: forbid submitting appending segment in the lambda stream cube
Posted by GitBox <gi...@apache.org>.
liukun4515 commented on a change in pull request #1644:
URL: https://github.com/apache/kylin/pull/1644#discussion_r657576904
##########
File path: server-base/src/main/java/org/apache/kylin/rest/service/JobService.java
##########
@@ -435,6 +438,26 @@ private void checkAllowBuilding(CubeInstance cube) {
}
}
+ private void checkStreamLambdaBuildingSegment(CubeInstance cube, TSRange tsRange) {
+ Segments<CubeSegment> readycubeSegments = cube.getSegments(SegmentStatusEnum.READY);
+ if (readycubeSegments.size() <= 0) {
Review comment:
Done, remove this branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] hit-lacus commented on a change in pull request #1644: [KYLIN-4983]add rule for submit build job: forbid submitting appending segment in the lambda stream cube
Posted by GitBox <gi...@apache.org>.
hit-lacus commented on a change in pull request #1644:
URL: https://github.com/apache/kylin/pull/1644#discussion_r654171671
##########
File path: server-base/src/main/java/org/apache/kylin/rest/service/JobService.java
##########
@@ -435,6 +438,26 @@ private void checkAllowBuilding(CubeInstance cube) {
}
}
+ private void checkStreamLambdaBuildingSegment(CubeInstance cube, TSRange tsRange) {
+ Segments<CubeSegment> readycubeSegments = cube.getSegments(SegmentStatusEnum.READY);
+ if (readycubeSegments.size() <= 0) {
Review comment:
I suggest you to remove the branch: `readycubeSegments.size() <= 0` .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] lgtm-com[bot] commented on pull request #1644: [KYLIN-4982]add rule for submit build job: forbid submitting appending segment in the lambda stream cube
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #1644:
URL: https://github.com/apache/kylin/pull/1644#issuecomment-825381157
This pull request **introduces 1 alert** when merging 26697d597acc1a31735bad600f109da5e04603cd into 1c41baf008ad6444ec4b036f9e62687aacbcfae4 - [view on LGTM.com](https://lgtm.com/projects/g/apache/kylin/rev/pr-48aaea5c3564b5ed934cc9fa26609a194eb9d9eb)
**new alerts:**
* 1 for Missing space in string literal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] hit-lacus merged pull request #1644: [KYLIN-4983]add rule for submit build job: forbid submitting appending segment in the lambda stream cube
Posted by GitBox <gi...@apache.org>.
hit-lacus merged pull request #1644:
URL: https://github.com/apache/kylin/pull/1644
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] liukun4515 commented on pull request #1644: [KYLIN-4983]add rule for submit build job: forbid submitting appending segment in the lambda stream cube
Posted by GitBox <gi...@apache.org>.
liukun4515 commented on pull request #1644:
URL: https://github.com/apache/kylin/pull/1644#issuecomment-860164624
@hit-lacus PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org