You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by "Arvind Prabhakar (Created) (JIRA)" <ji...@apache.org> on 2012/02/01 19:46:58 UTC
[jira] [Created] (FLUME-950) Retire "node" in favor of "agent"
Retire "node" in favor of "agent"
---------------------------------
Key: FLUME-950
URL: https://issues.apache.org/jira/browse/FLUME-950
Project: Flume
Issue Type: Task
Affects Versions: v1.0.0
Reporter: Arvind Prabhakar
As stated in the write-ups, documentation and discussed in various presentations and meetups, Flume (ng) uses the notion of "Agent" which is different from the previous implementation's use of the term "node". While this has been discussed informally in various forums, we have not been disciplined enough to make this clear in the code itself. Consequently, the code for Flume (ng) still references "node" in many places and is confusing to say the least.
To make the code aligned with the terminology used in design discussions in various forums, I am suggesting that we formally retire the term "node" in favor of the term "agent". This will require non-trivial code and documentation changes. However, not doing it now will increase the cost of fixing this later and add to the confusion of folks transitioning from the prior implementation to current implementation.
(http://markmail.org/message/ddacmawak33i5qbr)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-950) Retire "node" in favor of "agent"
Posted by "Alexander Lorenz-Alten (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexander Lorenz-Alten updated FLUME-950:
-----------------------------------------
Attachment: move2agent.sh
> Retire "node" in favor of "agent"
> ---------------------------------
>
> Key: FLUME-950
> URL: https://issues.apache.org/jira/browse/FLUME-950
> Project: Flume
> Issue Type: Task
> Affects Versions: v1.0.0
> Reporter: Arvind Prabhakar
> Labels: build
> Attachments: move2agent.sh
>
>
> As stated in the write-ups, documentation and discussed in various presentations and meetups, Flume (ng) uses the notion of "Agent" which is different from the previous implementation's use of the term "node". While this has been discussed informally in various forums, we have not been disciplined enough to make this clear in the code itself. Consequently, the code for Flume (ng) still references "node" in many places and is confusing to say the least.
> To make the code aligned with the terminology used in design discussions in various forums, I am suggesting that we formally retire the term "node" in favor of the term "agent". This will require non-trivial code and documentation changes. However, not doing it now will increase the cost of fixing this later and add to the confusion of folks transitioning from the prior implementation to current implementation.
> (http://markmail.org/message/ddacmawak33i5qbr)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-950) Retire "node" in favor of "agent"
Posted by "Alexander Lorenz-Alten (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexander Lorenz-Alten updated FLUME-950:
-----------------------------------------
Labels: build (was: )
Status: Patch Available (was: Open)
shell script to move FLUME-728 in a new branch to fit the term agent in all sources
> Retire "node" in favor of "agent"
> ---------------------------------
>
> Key: FLUME-950
> URL: https://issues.apache.org/jira/browse/FLUME-950
> Project: Flume
> Issue Type: Task
> Affects Versions: v1.0.0
> Reporter: Arvind Prabhakar
> Labels: build
>
> As stated in the write-ups, documentation and discussed in various presentations and meetups, Flume (ng) uses the notion of "Agent" which is different from the previous implementation's use of the term "node". While this has been discussed informally in various forums, we have not been disciplined enough to make this clear in the code itself. Consequently, the code for Flume (ng) still references "node" in many places and is confusing to say the least.
> To make the code aligned with the terminology used in design discussions in various forums, I am suggesting that we formally retire the term "node" in favor of the term "agent". This will require non-trivial code and documentation changes. However, not doing it now will increase the cost of fixing this later and add to the confusion of folks transitioning from the prior implementation to current implementation.
> (http://markmail.org/message/ddacmawak33i5qbr)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-950) Retire "node" in favor of "agent"
Posted by "Alexander Lorenz-Alten (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221869#comment-13221869 ]
Alexander Lorenz-Alten commented on FLUME-950:
----------------------------------------------
The script (poor, but works) replaces:
in PropertiesFileConfigurationProvider.java
Agent => NewAgent
agent => newagent
to prevent single-type import from FlumeConfiguration.java after replacing node into agent
I think a new branch for the change should be the best solution.
The script clone the given origbranch (728) and clone them into a new (here 730), mv and replace, clean the build and build the project. The branches defined in a variable
Patches
=======
the script replace all found node / Node / NODE terms into the equivalent agent terms and replace patch FLUME-999
[INFO] Reactor Summary:
[INFO]
[INFO] Apache Flume ...................................... SUCCESS [7.276s]
[INFO] Flume NG Core ..................................... SUCCESS [3.043s]
[INFO] Flume NG Sinks .................................... SUCCESS [0.275s]
[INFO] Flume NG HDFS Sink ................................ SUCCESS [0.892s]
[INFO] Flume NG IRC Sink ................................. SUCCESS [0.515s]
[INFO] Flume NG Channels ................................. SUCCESS [0.214s]
[INFO] Flume NG JDBC channel ............................. SUCCESS [0.802s]
[INFO] Flume NG Agent .................................... SUCCESS [0.893s]
[INFO] Flume NG file-based channel ....................... SUCCESS [0.516s]
[INFO] Flume NG distribution ............................. SUCCESS [16.602s]
[INFO] Flume legacy Sources .............................. SUCCESS [0.143s]
[INFO] Flume legacy Thrift Source ........................ SUCCESS [0.599s]
[INFO] Flume legacy Avro source .......................... SUCCESS [0.458s]
[INFO] Flume NG Clients .................................. SUCCESS [0.133s]
[INFO] Flume NG Log4j Appender ........................... SUCCESS [0.385s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 33.113s
[INFO] Finished at: Sun Mar 04 13:24:47 CET 2012
[INFO] Final Memory: 27M/81M
now flume runs with:
bin/flume-ng agent -n foo -f conf/flume-conf.properties.template
> Retire "node" in favor of "agent"
> ---------------------------------
>
> Key: FLUME-950
> URL: https://issues.apache.org/jira/browse/FLUME-950
> Project: Flume
> Issue Type: Task
> Affects Versions: v1.0.0
> Reporter: Arvind Prabhakar
> Labels: build
> Attachments: move2agent.sh
>
>
> As stated in the write-ups, documentation and discussed in various presentations and meetups, Flume (ng) uses the notion of "Agent" which is different from the previous implementation's use of the term "node". While this has been discussed informally in various forums, we have not been disciplined enough to make this clear in the code itself. Consequently, the code for Flume (ng) still references "node" in many places and is confusing to say the least.
> To make the code aligned with the terminology used in design discussions in various forums, I am suggesting that we formally retire the term "node" in favor of the term "agent". This will require non-trivial code and documentation changes. However, not doing it now will increase the cost of fixing this later and add to the confusion of folks transitioning from the prior implementation to current implementation.
> (http://markmail.org/message/ddacmawak33i5qbr)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-950) Retire "node" in favor of "agent"
Posted by "Juhani Connolly (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Juhani Connolly updated FLUME-950:
----------------------------------
Affects Version/s: v1.1.0
Fix Version/s: v1.1.0
> Retire "node" in favor of "agent"
> ---------------------------------
>
> Key: FLUME-950
> URL: https://issues.apache.org/jira/browse/FLUME-950
> Project: Flume
> Issue Type: Task
> Affects Versions: v1.0.0, v1.1.0
> Reporter: Arvind Prabhakar
> Labels: build
> Fix For: v1.1.0
>
> Attachments: move2agent.sh
>
>
> As stated in the write-ups, documentation and discussed in various presentations and meetups, Flume (ng) uses the notion of "Agent" which is different from the previous implementation's use of the term "node". While this has been discussed informally in various forums, we have not been disciplined enough to make this clear in the code itself. Consequently, the code for Flume (ng) still references "node" in many places and is confusing to say the least.
> To make the code aligned with the terminology used in design discussions in various forums, I am suggesting that we formally retire the term "node" in favor of the term "agent". This will require non-trivial code and documentation changes. However, not doing it now will increase the cost of fixing this later and add to the confusion of folks transitioning from the prior implementation to current implementation.
> (http://markmail.org/message/ddacmawak33i5qbr)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira