You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/11/22 10:55:39 UTC

[GitHub] [flink] SmirAlex opened a new pull request, #21365: [FLINK-29427] Fix unstable test LookupJoinITCase by using UserCodeClassLoader

SmirAlex opened a new pull request, #21365:
URL: https://github.com/apache/flink/pull/21365

<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*

*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*

## Contribution Checklist

- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.

- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.

- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.

- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).

- Each pull request should address only one issue, not mix up code from multiple issues.

- Each commit in the pull request has a meaningful commit message (including the JIRA id)

- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.

**(The sections below can be removed for hotfixes of typos)**
-->

## What is the purpose of the change

This pull-request *tries to fix* unstable test `LookupJoinITCase` (error was not succeeded to be reproduced locally). The errors contains a message 'Trying to access closed classloader', however, test configured in the way that it loads cache only one time, and we wait until the end of this load in `LookupFullCache#open`. So 'LookupFullCache#close' shouldn't somehow affect on cache load thread, if we assume that `close` is called only after `open`.
During debugging it was found out that in `GenericRowDataKeySelector#open`, which is executed inside separate reload thread, call of `Thread.currentThread().getContextClassLoader()` returns `SubmoduleClassLoader` rather than `FlinkUserCodeClassLoader`, which is returned by the same method inside main thread. *Probably*, this ClassLoader should not be there, and this is the core of the problem. Also it closely relates to the problem about classloader leak, described in option `CoreOptions#CHECK_LEAKED_CLASSLOADER`, to which error points out.

## Brief change log

- Provide user code class loader in `CacheLoader` rather than using `Thread.currentThread().getContextClassLoader()`

## Verifying this change

- This change is already covered by existing tests.

## Does this pull request potentially affect one of the following parts:

- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
- The S3 file system connector: (no)

## Documentation

- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org