You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/06/28 08:27:00 UTC
[jira] [Updated] (HDDS-3887) Remove redundant code for
HealthyPipelineSafeModeRule
[ https://issues.apache.org/jira/browse/HDDS-3887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ASF GitHub Bot updated HDDS-3887:
---------------------------------
Labels: pull-request-available (was: )
> Remove redundant code for HealthyPipelineSafeModeRule
> -----------------------------------------------------
>
> Key: HDDS-3887
> URL: https://issues.apache.org/jira/browse/HDDS-3887
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Components: SCM
> Affects Versions: 0.5.0
> Reporter: tartarus
> Assignee: tartarus
> Priority: Minor
> Labels: pull-request-available
>
> HealthyPipelineSafeModeRule#validate
> {code:java}
> protected boolean validate() {
> if (currentHealthyPipelineCount >= healthyPipelineThresholdCount) {
> return true;
> }
> return false;
> }{code}
> this method is fat，I think direct return is ok. like this
>
> {code:java}
> return currentHealthyPipelineCount >= healthyPipelineThresholdCount;
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org