You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/04/02 05:09:00 UTC
[jira] [Work logged] (BEAM-3437) Support schema in PCollections
[ https://issues.apache.org/jira/browse/BEAM-3437?focusedWorklogId=86480&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-86480 ]
ASF GitHub Bot logged work on BEAM-3437:
----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Apr/18 05:08
Start Date: 02/Apr/18 05:08
Worklog Time Spent: 10m
Work Description: reuvenlax commented on a change in pull request #4964: [BEAM-3437] Introduce Schema class, and use it in BeamSQL
URL: https://github.com/apache/beam/pull/4964#discussion_r178487904
##########
File path: sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/impl/interpreter/operator/date/BeamSqlTimestampMinusTimestampExpressionTest.java
##########
@@ -43,13 +42,15 @@
private static final Row NULL_ROW = null;
private static final BoundedWindow NULL_WINDOW = null;
- private static final Date DATE = new Date(2017, 3, 4, 3, 2, 1);
- private static final Date DATE_MINUS_2_SEC = new DateTime(DATE).minusSeconds(2).toDate();
- private static final Date DATE_MINUS_3_MIN = new DateTime(DATE).minusMinutes(3).toDate();
- private static final Date DATE_MINUS_4_HOURS = new DateTime(DATE).minusHours(4).toDate();
- private static final Date DATE_MINUS_7_DAYS = new DateTime(DATE).minusDays(7).toDate();
- private static final Date DATE_MINUS_2_MONTHS = new DateTime(DATE).minusMonths(2).toDate();
- private static final Date DATE_MINUS_1_YEAR = new DateTime(DATE).minusYears(1).toDate();
+ private static final DateTime DATE = new DateTime()
+ .withDate(2017, 3, 4)
Review comment:
<!--thread_id:cc_178338665_t; commit:79c95678e593da730ba0472b77304ec1f916245e; resolved:1-->
<!--section:context-quote-->
> **akedin** wrote:
> formatting?
<!--section:body-->
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 86480)
> Support schema in PCollections
> ------------------------------
>
> Key: BEAM-3437
> URL: https://issues.apache.org/jira/browse/BEAM-3437
> Project: Beam
> Issue Type: Wish
> Components: beam-model
> Reporter: Jean-Baptiste Onofré
> Assignee: Jean-Baptiste Onofré
> Priority: Major
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> As discussed with some people in the team, it would be great to add schema support in {{PCollections}}. It will allow us:
> 1. To expect some data type in {{PTransforms}}
> 2. Improve some runners with additional features (I'm thinking about Spark runner with data frames for instance).
> A technical draft document has been created:
> https://docs.google.com/document/d/1tnG2DPHZYbsomvihIpXruUmQ12pHGK0QIvXS1FOTgRc/edit?disco=AAAABhykQIs&ts=5a203b46&usp=comment_email_document
> I also started a PoC on a branch, I will update this Jira with a "discussion" PR.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)