[GitHub] [iceberg] RussellSpitzer commented on a diff in pull request #7585: Adding support for custom partition spec during rewrite

["RussellSpitzer (via GitHub)" <gi...@apache.org>]

RussellSpitzer commented on code in PR #7585:
URL: https://github.com/apache/iceberg/pull/7585#discussion_r1192706550


##########
core/src/main/java/org/apache/iceberg/actions/SizeBasedFileRewriter.java:
##########
@@ -103,13 +103,16 @@
 
   private static final long SPLIT_OVERHEAD = 5 * 1024;
 
+  public static final String OUTPUT_SPEC_ID = "output-spec-id";

Review Comment:
   Needs Java doc, see above options like MAX_FILE_GROUP_SIZE
   Also this property is probably not SizeBasedFileRewriter Specific. I think it should live in RewriteDataFiles since it applies to all possible future rewrites.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org