[GitHub] [hbase] infraio commented on a change in pull request #2249: HBASE-24871 Replication may loss data when refresh recovered replicat…

[GitBox <gi...@apache.org>]

infraio commented on a change in pull request #2249:
URL: https://github.com/apache/hbase/pull/2249#discussion_r470366397



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java
##########
@@ -516,7 +516,7 @@ public void refreshSources(String peerId) throws IOException {
         ReplicationSourceInterface replicationSource = createSource(queueId, peer);
         this.oldsources.add(replicationSource);
         for (SortedSet<String> walsByGroup : walsByIdRecoveredQueues.get(queueId).values()) {
-          walsByGroup.forEach(wal -> src.enqueueLog(new Path(wal)));
+          walsByGroup.forEach(wal -> replicationSource.enqueueLog(new Path(wal)));

Review comment:
       > So the problem is that logs from recovered queues were getting added to the new "normal" queue? And these logs are never read, then?
   
   Yes. These log will be added to normal source. And will read by normal source. So this should not loss data but only affect the replicate order.
   
   @ddupg I thought the issue title need to be changed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org